From: Roland Dreier <rdreier@cisco.com>
To: akepner@sgi.com
Cc: Tony Luck <tony.luck@intel.com>,
Grant Grundler <grundler@parisc-linux.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Jes Sorensen <jes@sgi.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
David Miller <davem@davemloft.net>,
Muli Ben-Yehuda <muli@il.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] IB: add dmabarrier to ib_umem_get() prototype
Date: Wed, 30 Jan 2008 17:07:43 -0800 [thread overview]
Message-ID: <adar6fyajkw.fsf@cisco.com> (raw)
In-Reply-To: <20080130055320.GU30022@sgi.com> (akepner@sgi.com's message of "Tue, 29 Jan 2008 21:53:20 -0800")
> diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
> index 4e3128f..5b00408 100644
> --- a/drivers/infiniband/core/umem.c
> +++ b/drivers/infiniband/core/umem.c
> @@ -74,7 +74,7 @@ static void __ib_umem_release(struct ib_device *dev, struct ib_umem *umem, int d
> * @access: IB_ACCESS_xxx flags for memory being pinned
> */
> struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
> - size_t size, int access)
> + size_t size, int access, int dmabarrier)
> {
> struct ib_umem *umem;
> struct page **page_list;
Two problems here, one major: this doesn't actually do anything with
the dmabarrier parameter, and one minor: it also doesn't add any
documentation for the parameter to the comment before the function.
- R.
prev parent reply other threads:[~2008-01-31 1:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 5:53 [PATCH 3/4] IB: add dmabarrier to ib_umem_get() prototype akepner
2008-01-31 1:07 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adar6fyajkw.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akepner@sgi.com \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=jes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=randy.dunlap@oracle.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox