From: Roland Dreier <rdreier@cisco.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: Re: Pull request for semaphore include changes
Date: Wed, 23 Apr 2008 09:06:39 -0700 [thread overview]
Message-ID: <adaskxcblo0.fsf@cisco.com> (raw)
In-Reply-To: <20080423160348.GA29796@parisc-linux.org> (Matthew Wilcox's message of "Wed, 23 Apr 2008 10:03:49 -0600")
> You've missed this hunk:
>
> if (filp->f_flags & O_NONBLOCK) {
> if (down_trylock(&port->sm_sem)) {
> ret = -EAGAIN;
> goto fail;
> }
> } else {
> if (down_interruptible(&port->sm_sem)) {
> ret = -ERESTARTSYS;
> goto fail;
> }
> }
Duh, thanks.
prev parent reply other threads:[~2008-04-23 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-19 18:40 Pull request for semaphore include changes Matthew Wilcox
2008-04-23 7:18 ` Geert Uytterhoeven
2008-04-23 11:13 ` Matthew Wilcox
2008-04-23 15:57 ` Roland Dreier
2008-04-23 16:03 ` Matthew Wilcox
2008-04-23 16:06 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaskxcblo0.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox