Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()

Pete Zaitcev
2007-05-31T00:04:59Z

On Wed, 30 May 2007 16:42:41 -0700, Roland Dreier <rdreier@cisco.com> wrote:

> If I just see
>
> for (pos = list_entry((head)->next, typeof(*pos), member),
> n = list_entry(pos->member.next, typeof(*pos), member);
> &pos->member != (head);
> pos = n, n = list_entry(n->member.next, typeof(*n), member))
>
> then what am I to think?

You won't catch me writing this kind of crap, so the question is moot.
Seriously, a comma operator? Admit it, you just expanded a marcro from
list.h by hand. Real people cannot write like that.

-- Pete