Re: [PATCH 0 of 20] [RFC] ipath - PathScale InfiniPath driver

Bryan O'Sullivan
2005-12-31T01:40:56Z

On Fri, 2005-12-30 at 16:10 -0800, Greg KH wrote:

> But we (the kernel community), don't really accept that as a valid
> reason to accept this kind of code, sorry.

Fair enough. I'd like some guidance in that case. Some of our ioctls
access the hardware more or less directly, while others do things like
read or reset counters.

Which of these kinds of operations are appropriate to retain as ioctls,
in your eyes, and which are best converted to sysfs or configfs
alternatives?

As an example, take a look at ipath_sma_ioctl. It seems to me that
receiving or sending subnet management packets ought to remain as
ioctls, while getting port or node data could be turned into sysfs
attributes. Lane identification could live in configfs. If you think
otherwise, please let me know what's more appropriate.

The less blind I am in doing these conversions, the fewer rounds we'll
have to go in reviewing humongous driver submission patches :-)

Thanks,

<b