Re: [PATCH 12 of 20] ipath - misc driver support code

Greg KH
2005-12-31T00:19:09Z

On Fri, Dec 30, 2005 at 03:10:09PM -0800, Bryan O'Sullivan wrote:
> On Fri, 2005-12-30 at 00:25 -0800, Greg KH wrote:
> > > + unsigned long long Control;
> > > + unsigned long long PageAlign;
> > > + unsigned long long PortCnt;
> >
> > And what's with the InterCapsNamingScheme of these variables?
>
> They're taken straight from the register names in our chip spec. I can
> squish them to lowercase-only, if that seems important.

No, but document it that this is the reason for it (along with a pointer
to your chip spec, if possible.)

thanks,

greg k-h