Re: [PATCH 0 of 20] [RFC] ipath - PathScale InfiniPath driver

Horst von Brand
2005-12-29T19:02:13Z

Bryan O'Sullivan <bos@pathscale.com> wrote:
> Following Roland's submission of our InfiniPath InfiniBand HCA driver
> earlier this month, we have responded to people's comments by making a
> large number of changes to the driver.

Many thanks!

> Here is another set of driver patches for review. Roland is on
> vacation until January 4, so I'm posting these in his place. Once
> again, your comments are appreciated. We'd like to submit this driver
> for inclusion in 2.6.16, so we'll be responding quickly to all
> feedback.
>
> A short summary of the changes we have made is as follows:

Some comments, just based on this:

[...]

> - Renamed _BITS_PER_BYTE to BITS_PER_BYTE, and moved it into
> linux/types.h

Haven't come across anything with this not 8 for a /long/ time now, and no
Linux on that in sight.

[...]

> There are a few requested changes we have chosen to omit for now:
>
> - The driver still uses EXPORT_SYMBOL, for consistency with other
> code in drivers/infiniband

I'd suppose that is your choice...

> - Someone asked for the kernel's i2c infrastructure to be used, but
> our i2c usage is very specialised, and it would be more of a mess
> to use the kernel's

Problem with that is that if everybody and Aunt Tillie does the same, the
kernel as a whole gets to be a mess.

> - We're still using ioctls instead of sysfs or configfs in some
> cases, to maintain userspace compatibility

With what? You can very well ask people to upgrade to the latest userland
utilities, and even make them run the old versions when they find that the
new interface isn't there. Happened recently with modprobe/modutils.
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513