Re: [PATCH 8 of 20] ipath - core driver, part 1 of 4

Greg KH
2005-12-31T00:19:10Z

On Fri, Dec 30, 2005 at 03:47:07PM -0800, Bryan O'Sullivan wrote:
> On Fri, 2005-12-30 at 00:39 -0800, Greg KH wrote:
>
> > > +void ipath_chip_done(void)
> > > +{
> > > +}
> > > +
> > > +void ipath_chip_cleanup(struct ipath_devdata * dd)
> > > +{
> > > +}
> >
> > What are these two empty functions for?
>
> They're just as dead as they look.

Then you might want to remove them :)

> > > +static ssize_t show_status_str(struct device *dev,
>
> > how big can this "status string" be?
>
> Just a few dozen bytes.
>
> > If it's even getting close to
> > PAGE_SIZE, this doesn't need to be a sysfs attribute, but you should
> > break it up into its individual pieces.
>
> Do you think that's still warranted, given this?

No I don't, unless you think that message will grow somehow...

thanks,

greg k-h