Re: [PATCH 0 of 20] [RFC] ipath - PathScale InfiniPath driver

Bryan O'Sullivan
2005-12-30T23:11:46Z

On Fri, 2005-12-30 at 00:00 -0800, Greg KH wrote:

> > - The driver still uses EXPORT_SYMBOL, for consistency with other
> > code in drivers/infiniband
>
> Why would that matter?

I don't want to do something gratuitously different to the prevailing
set of code in which it lives.

> > - We're still using ioctls instead of sysfs or configfs in some
> > cases, to maintain userspace compatibility
>
> Compatibility with what? The driver isn't in the kernel tree yet, so
> there's no old kernel versions to remain compatibile with :)

We already ship userspace code to customers that relies on the ioctl
interfaces.

> I also noticed that you are still using the uint64_t type variable
> types, can you please switch to the proper kernel types instead (u64 in
> this specific example.)

Yes, we'll use u64 for internal variables, and __u64 for stuff exported
to userspace, etc.

<b