From: Roland Dreier <rdreier@cisco.com>
To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: Dave Olson <olson@unixfolk.com>,
linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [openib-general] Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes
Date: Wed, 17 May 2006 22:17:50 -0700 [thread overview]
Message-ID: <adau07n3o8x.fsf@cisco.com> (raw)
In-Reply-To: <1147929311.3094.16.camel@localhost.localdomain> (Bryan O'Sullivan's message of "Wed, 17 May 2006 22:15:11 -0700")
Bryan> Wow. I have no idea where that extra "goto bail" came
Bryan> from. It's not supposed to be there.
Even without it you still leak the work structure, because there's no
schedule_work().
Now that I look at it, in uverbs_mem.c, the mm will be leaked if the
kmalloc fails...
- R.
next prev parent reply other threads:[~2006-05-18 5:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.2ho1QSA8Kf7L8EFqp3rLsB7NE9s@ifi.uio.no>
[not found] ` <fa.yXZlqXBzNi9Gq/4Q6Wc9H6bw+lU@ifi.uio.no>
2006-05-17 16:47 ` [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes Dave Olson
2006-05-17 18:08 ` [openib-general] " Roland Dreier
2006-05-18 4:13 ` Dave Olson
2006-05-18 4:55 ` Roland Dreier
2006-05-18 5:15 ` Bryan O'Sullivan
2006-05-18 5:17 ` Roland Dreier [this message]
2006-05-18 7:04 ` Dave Olson
2006-05-18 5:26 ` Dave Olson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adau07n3o8x.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=bos@pathscale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olson@unixfolk.com \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox