From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753941Ab0CKT6F (ORCPT ); Thu, 11 Mar 2010 14:58:05 -0500 Received: from sj-iport-4.cisco.com ([171.68.10.86]:14479 "EHLO sj-iport-4.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753609Ab0CKT6A (ORCPT ); Thu, 11 Mar 2010 14:58:00 -0500 Authentication-Results: sj-iport-4.cisco.com; dkim=neutral (message not signed) header.i=none X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAFPamEurR7Ht/2dsb2JhbACaYXOkUZhyhHsEgxc X-IronPort-AV: E=Sophos;i="4.49,622,1262563200"; d="scan'208";a="98925087" From: Roland Dreier To: Grant Likely Cc: Hoang-Nam Nguyen , Christoph Raisch , monstr@monstr.eu, gregkh@suse.de, benh@kernel.crashing.org, akpm@linux-foundation.org, davem@davemloft.net, sfr@canb.auug.org.au, jgarzik@pobox.com, ben-linux@fluff.org, dwmw2@infradead.org, jeremy.kerr@canonical.com, James.Bottomley@suse.de, broonie@opensource.wolfsonmicro.com, microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org, linux-ide@vger.kernel.org, netdev@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-scsi@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 25/37] drivers/infiniband: use .dev.of_node instead of .node in struct of_device References: <20100311174830.4824.19820.stgit@angua> <20100311180605.4824.3613.stgit@angua> X-Message-Flag: Warning: May contain useful information Date: Thu, 11 Mar 2010 11:57:53 -0800 In-Reply-To: <20100311180605.4824.3613.stgit@angua> (Grant Likely's message of "Thu, 11 Mar 2010 11:06:06 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Seems fine... adding EHCA guys just to make sure. > .node is being removed > > Signed-off-by: Grant Likely > --- > > drivers/infiniband/hw/ehca/ehca_main.c | 11 ++++++----- > 1 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/infiniband/hw/ehca/ehca_main.c b/drivers/infiniband/hw/ehca/ehca_main.c > index 129a6be..2639185 100644 > --- a/drivers/infiniband/hw/ehca/ehca_main.c > +++ b/drivers/infiniband/hw/ehca/ehca_main.c > @@ -291,8 +291,9 @@ static int ehca_sense_attributes(struct ehca_shca *shca) > }; > > ehca_gen_dbg("Probing adapter %s...", > - shca->ofdev->node->full_name); > - loc_code = of_get_property(shca->ofdev->node, "ibm,loc-code", NULL); > + shca->ofdev->dev.of_node->full_name); > + loc_code = of_get_property(shca->ofdev->dev.of_node, "ibm,loc-code", > + NULL); > if (loc_code) > ehca_gen_dbg(" ... location lode=%s", loc_code); > > @@ -720,16 +721,16 @@ static int __devinit ehca_probe(struct of_device *dev, > int ret, i, eq_size; > unsigned long flags; > > - handle = of_get_property(dev->node, "ibm,hca-handle", NULL); > + handle = of_get_property(dev->dev.of_node, "ibm,hca-handle", NULL); > if (!handle) { > ehca_gen_err("Cannot get eHCA handle for adapter: %s.", > - dev->node->full_name); > + dev->dev.of_node->full_name); > return -ENODEV; > } > > if (!(*handle)) { > ehca_gen_err("Wrong eHCA handle for adapter: %s.", > - dev->node->full_name); > + dev->dev.of_node->full_name); > return -ENODEV; > } > > > -- Roland Dreier For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html