public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: "Eric Van Hensbergen" <ericvh@gmail.com>
Cc: "Tom Tucker" <tom@opengridcomputing.com>,
	linux-kernel@vger.kernel.org, v9fs-devel@vger.kernel.org,
	rminnich@dancer.ca.sandia.gov, lionkov@lanl.gov
Subject: Re: [PATCH v2a] 9prdma: RDMA Transport Support for 9P
Date: Fri, 10 Oct 2008 14:43:23 -0700	[thread overview]
Message-ID: <adavdw0ktxg.fsf@cisco.com> (raw)
In-Reply-To: <a4e6962a0810101436l1297c28ewd1691f4ac7ddf412@mail.gmail.com> (Eric Van Hensbergen's message of "Fri, 10 Oct 2008 16:36:17 -0500")

 > > (in cq_comp_handler)
 > >  +               struct p9_rdma_context *c = (void *)wc.wr_id;

cast here should be

               struct p9_rdma_context *c = (void *) (unsigned long) wc.wr_id;

 > ...
 > >  +static int
 > >  +post_recv(struct p9_trans *trans, struct p9_rdma_context *c)
 > >  +       wr.wr_id = (u64)c;

and this should be

	wr.wr_id = (unsigned long) c;

 > Ouch.  I get warnings on these two compiling on 32-bit systems.

      reply	other threads:[~2008-10-10 21:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-07 14:09 [PATCH v2a] 9prdma: RDMA Transport Support for 9P Tom Tucker
2008-10-10 21:36 ` Eric Van Hensbergen
2008-10-10 21:43   ` Roland Dreier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adavdw0ktxg.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=ericvh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lionkov@lanl.gov \
    --cc=rminnich@dancer.ca.sandia.gov \
    --cc=tom@opengridcomputing.com \
    --cc=v9fs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox