Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

Rusty Russell
2007-11-27T05:00:37Z

On Monday 26 November 2007 17:15:44 Roland Dreier wrote:
> > Except C doesn't have namespaces and this mechanism doesn't create them.
> > So this is just complete and utter makework; as I said before, noone's
> > going to confuse all those udp_* functions if they're not in the udp
> > namespace.
>
> I don't understand why you're so opposed to organizing the kernel's
> exported symbols in a more self-documenting way.

No, I was the one who moved exports near their declarations. That's
organised. I just don't see how this new "organization" will help: oh good,
I won't accidentally use the udp functions any more?!?

> It seems pretty
> clear to me that having a mechanism that requires modules to make
> explicit which (semi-)internal APIs makes reviewing easier

Perhaps you've got lots of patches were people are using internal APIs they
shouldn't?

> , makes it
> easier to communicate "please don't use that API" to module authors,

Well, introduce an EXPORT_SYMBOL_INTERNAL(). It's a lot less code. But you'd
still need to show that people are having trouble knowing what APIs to use.

> and takes at least a small step towards bringing the kernel's exported
> API under control.

There is no "exported API" to bring under control. There are symbols we
expose for the kernel's own use which can be used by external modules at
their own risk.

> What's the real downside?

No. That's the wrong question. What's the real upside?

Let's not put code in the core because "it doesn't seem to hurt".

I'm sure you think there's a real problem, but I'm still waiting for someone
to *show* it to me. Then we can look at solutions.

Rusty.