From: Roland Dreier <rdreier@cisco.com>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Sam Ravnborg <sam@ravnborg.org>, Jonathan Corbet <corbet@lwn.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: RFC: reviewer's statement of oversight
Date: Mon, 08 Oct 2007 11:40:29 -0700 [thread overview]
Message-ID: <adave9hjvqa.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0710081939120.10239@fbirervta.pbzchgretzou.qr> (Jan Engelhardt's message of "Mon, 8 Oct 2007 19:45:27 +0200 (CEST)")
> >Reviewed-by:
>
> * I am maintaner or an 'important' person and have had a
> look at it in depth
I think anyone should be able to supply a Reviewed-by: tag no matter
who they are. Of course the weight that such a tag carries in the
final decision of whether or not to merge may depend on who supplied
it, but I don't think we should try to formalize that aspect.
In other words, I would define Reviewed-by: as just "I have looked at
this patch in depth." Jon's text seems like a really good summation
of that idea in more explicit language.
- R.
next prev parent reply other threads:[~2007-10-08 18:40 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 17:24 RFC: reviewer's statement of oversight Jonathan Corbet
2007-10-08 17:31 ` Pekka Enberg
2007-10-08 17:37 ` Sam Ravnborg
2007-10-08 17:45 ` Jan Engelhardt
2007-10-08 18:01 ` Jeremy Fitzhardinge
2007-10-08 18:06 ` Randy Dunlap
2007-10-08 18:16 ` Jeremy Fitzhardinge
2007-10-08 18:34 ` Stefan Richter
2007-10-08 18:52 ` J. Bruce Fields
2007-10-08 19:04 ` Stefan Richter
2007-10-08 19:26 ` Scott Preece
2007-10-08 20:16 ` Rafael J. Wysocki
2007-10-09 2:07 ` Steven Rostedt
2007-10-09 6:11 ` Stefan Richter
2007-10-09 6:27 ` Sam Ravnborg
2007-10-09 6:39 ` Stefan Richter
2007-10-09 6:47 ` Stefan Richter
2007-10-08 18:26 ` Stefan Richter
2007-10-08 18:40 ` Roland Dreier [this message]
2007-10-08 19:35 ` Scott Preece
2007-10-08 20:33 ` H. Peter Anvin
2007-10-08 21:38 ` Theodore Tso
2007-10-08 22:18 ` Rafael J. Wysocki
2007-10-08 23:20 ` Oleg Verych
2007-10-08 22:43 ` Jonathan Corbet
2007-10-08 23:06 ` Randy Dunlap
2007-10-09 3:34 ` Stephen Hemminger
2007-10-08 23:30 ` J. Bruce Fields
2007-10-09 10:28 ` Alan Cox
2007-10-08 23:42 ` Stefan Richter
2007-10-09 0:05 ` Neil Brown
2007-10-09 16:49 ` Jonathan Corbet
2007-10-09 17:25 ` Roland Dreier
2007-10-10 0:06 ` David Chinner
2007-10-15 0:27 ` Neil Brown
2007-10-09 17:44 ` Sam Ravnborg
2007-10-15 0:35 ` Neil Brown
2007-10-15 14:32 ` Sam Ravnborg
2007-10-10 13:40 ` Scott Preece
2007-10-08 18:40 ` Mark Gross
2007-10-08 18:53 ` Stefan Richter
2007-10-08 19:05 ` Al Viro
2007-10-08 19:08 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adave9hjvqa.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=corbet@lwn.net \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox