From: Roland Dreier <rdreier@cisco.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: Re: Pull request for semaphore include changes
Date: Wed, 23 Apr 2008 08:57:24 -0700 [thread overview]
Message-ID: <adawsmobm3f.fsf@cisco.com> (raw)
In-Reply-To: <20080419184029.GO20637@parisc-linux.org> (Matthew Wilcox's message of "Sat, 19 Apr 2008 12:40:30 -0600")
> drivers/infiniband/core/user_mad.c | 2 +-
Let me say up front I have no problem with this change, which moved from
<asm/semaphore.h> to <linux/semaphore.h>. So take this email as an
honest question and not any form of complaint or criticism. But looking
at that user_mad.c file in particular, I don't see any use of anything
that looks like it would come from semaphore.h.
So I'm wondering why you didn't just delete the inclusion, as you did in
other places? I can merge a follow-up that does that cleanup (which
builds and works fine on my usual architectures) but I want to avoid
breaking avr32 allyesconfig or something like that.
(Commit 2fe7e6f7 "IB/umad: Simplify and fix locking" changed the locking
scheme, so maybe you looked at an older file)
Thanks,
Roland
next prev parent reply other threads:[~2008-04-23 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-19 18:40 Pull request for semaphore include changes Matthew Wilcox
2008-04-23 7:18 ` Geert Uytterhoeven
2008-04-23 11:13 ` Matthew Wilcox
2008-04-23 15:57 ` Roland Dreier [this message]
2008-04-23 16:03 ` Matthew Wilcox
2008-04-23 16:06 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adawsmobm3f.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox