* [PATCH 3/5] drivers/infiniband: test for IS_ERR rather than 0
@ 2008-03-24 18:09 Julia Lawall
2008-03-24 19:06 ` Roland Dreier
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2008-03-24 18:09 UTC (permalink / raw)
To: rolandd, sean.hefty, hal.rosenstock, general, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
The function rdma_create_id always returns either a valid pointer or a
value made with ERR_PTR, so its result should be tested with IS_ERR, not
with a test for 0.
The problem was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)
//<smpl>
@a@
expression E, E1;
statement S,S1;
position p;
@@
E = rdma_create_id(...)
... when != E = E1
if@p (E) S else S1
@n@
position a.p;
expression E,E1;
statement S,S1;
@@
E = NULL
... when != E = E1
if@p (E) S else S1
@depends on !n@
expression E;
statement S,S1;
position a.p;
@@
* if@p (E)
S else S1
//</smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/infiniband/core/cma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
--- a/drivers/infiniband/core/cma.c 2008-03-12 14:13:13.000000000 +0100
+++ b/drivers/infiniband/core/cma.c 2008-03-24 16:10:01.000000000 +0100
@@ -1289,7 +1289,7 @@ static int iw_conn_req_handler(struct iw
new_cm_id = rdma_create_id(listen_id->id.event_handler,
listen_id->id.context,
RDMA_PS_TCP);
- if (!new_cm_id) {
+ if (IS_ERR(new_cm_id)) {
ret = -ENOMEM;
goto out;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/5] drivers/infiniband: test for IS_ERR rather than 0
2008-03-24 18:09 [PATCH 3/5] drivers/infiniband: test for IS_ERR rather than 0 Julia Lawall
@ 2008-03-24 19:06 ` Roland Dreier
0 siblings, 0 replies; 2+ messages in thread
From: Roland Dreier @ 2008-03-24 19:06 UTC (permalink / raw)
To: Julia Lawall
Cc: rolandd, sean.hefty, hal.rosenstock, general, linux-kernel,
kernel-janitors
Neat. Thanks, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-24 19:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-24 18:09 [PATCH 3/5] drivers/infiniband: test for IS_ERR rather than 0 Julia Lawall
2008-03-24 19:06 ` Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).