From: Roland Dreier <rdreier@cisco.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: "Michael S. Tsirkin" <mst@mellanox.co.il>,
Andrew Morton <akpm@osdl.org>, Hugh Dickins <hugh@veritas.com>,
William Irwin <wli@holomorphy.com>,
Gleb Natapov <gleb@minantech.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
openib-general@openib.org, Petr Vandrovec <vandrove@vc.cvut.cz>,
Badari Pulavarty <pbadari@us.ibm.com>,
Grant Grundler <grundler@parisc-linux.org>,
Matthew Wilcox <matthew@wil.cx>
Subject: Re: [PATCH] madvise MADV_DONTFORK/MADV_DOFORK
Date: Tue, 14 Feb 2006 22:09:34 -0800 [thread overview]
Message-ID: <adawtfxqhk1.fsf@cisco.com> (raw)
In-Reply-To: <43F2AEAE.5010700@yahoo.com.au> (Nick Piggin's message of "Wed, 15 Feb 2006 15:31:42 +1100")
Nick> May I ask, what is the rationale for ignoring the apparent
Nick> conventions of all architectures? For example parisc, you
Nick> appear to even go contrary to the comment.
Looking through include/asm-*/mman.h, I have to agree. The parisc
example seemly especially bad, as (in addition to being in the
reserved range as Nick notes) the DONTFORK/DOFORK values are stuck in
a block with the page size values instead of the previous block where
they seem more sensible. However, in other files like the alpha
version, where the rest of the values are in decimal, the hex defines
look rather jarring.
Michael, what led you to choose 0x30 and 0x31 for the two new values?
It does seem that keeping them uniform across architectures is a
reasonable thing to do, but as far as I can tell the values 9 and 10
are unused on all architectures, and have the added merit of not
falling in the parisc reserved range.
Do we still have a chance to change this?
- R.
next prev parent reply other threads:[~2006-02-15 6:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 15:41 madvise MADV_DONTFORK/MADV_DOFORK Michael S. Tsirkin
2006-02-13 18:23 ` Hugh Dickins
2006-02-13 19:02 ` Michael S. Tsirkin
2006-02-14 6:51 ` Gleb Natapov
2006-02-13 19:04 ` [openib-general] " Roland Dreier
2006-02-13 19:05 ` Linus Torvalds
2006-02-13 19:16 ` [openib-general] " Roland Dreier
2006-02-13 19:34 ` Linus Torvalds
2006-02-13 19:50 ` Hugh Dickins
2006-02-13 21:09 ` Michael S. Tsirkin
2006-02-13 21:57 ` Hugh Dickins
2006-02-13 22:09 ` Michael S. Tsirkin
2006-02-13 22:54 ` Hugh Dickins
2006-02-13 23:01 ` [PATCH] " Michael S. Tsirkin
2006-02-13 23:44 ` Hugh Dickins
2006-02-13 22:27 ` [openib-general] " Linus Torvalds
2006-02-13 22:55 ` Michael S. Tsirkin
2006-02-13 23:01 ` Hugh Dickins
2006-02-13 23:35 ` [PATCH] " Michael S. Tsirkin
2006-02-15 4:31 ` Nick Piggin
2006-02-15 6:09 ` Roland Dreier [this message]
2006-02-15 6:16 ` Andrew Morton
2006-02-15 6:34 ` [PATCH] Fix up MADV_DONTFORK/MADV_DOFORK definitions Roland Dreier
2006-02-15 6:48 ` Gleb Natapov
2006-02-15 7:06 ` Nick Piggin
2006-02-15 7:31 ` Bernd Eckenfels
2006-02-15 8:18 ` Michael S. Tsirkin
2006-02-15 8:13 ` [PATCH] madvise MADV_DONTFORK/MADV_DOFORK Michael S. Tsirkin
2006-02-13 20:05 ` Michael S. Tsirkin
2006-02-13 19:20 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adawtfxqhk1.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=gleb@minantech.com \
--cc=grundler@parisc-linux.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mst@mellanox.co.il \
--cc=nickpiggin@yahoo.com.au \
--cc=openib-general@openib.org \
--cc=pbadari@us.ibm.com \
--cc=vandrove@vc.cvut.cz \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox