From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1756760AbYKCUxX@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756760AbYKCUxX (ORCPT <rfc822;w@1wt.eu>);
	Mon, 3 Nov 2008 15:53:23 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756633AbYKCUw4
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 3 Nov 2008 15:52:56 -0500
Received: from sj-iport-2.cisco.com ([171.71.176.71]:14715 "EHLO
	sj-iport-2.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756195AbYKCUwy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 3 Nov 2008 15:52:54 -0500
X-IronPort-AV: E=Sophos;i="4.33,538,1220227200"; 
   d="scan'208";a="101175246"
From: Roland Dreier <rdreier@cisco.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-next@vger.kernel.org,
       sfr <sfr@canb.auug.org.au>, rolandd@cisco.com, ericvh@gmail.com,
       akpm <akpm@linux-foundation.org>, davem@davemloft.net,
       netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net/9p: limit RDMA to INET
References: <20081103111731.d12dbb84.randy.dunlap@oracle.com>
X-Message-Flag: Warning: May contain useful information
Date: Mon, 03 Nov 2008 12:52:50 -0800
In-Reply-To: <20081103111731.d12dbb84.randy.dunlap@oracle.com> (Randy Dunlap's
	message of "Mon, 3 Nov 2008 11:17:31 -0800")
Message-ID: <aday700v8f1.fsf@cisco.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-OriginalArrivalTime: 03 Nov 2008 20:52:51.0255 (UTC) FILETIME=[22D73C70:01C93DF6]
Authentication-Results: sj-dkim-3; header.From=rdreier@cisco.com; dkim=pass (
	sig from cisco.com/sjdkim3002 verified; ); 
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

 > Make 9p's RDMA option depend on INET since it uses Infiniband rdma_*
 > functions and that code depends on INET.  Otherwise 9p can try to
 > use symbols which don't exist.
 > 
 > ERROR: "rdma_destroy_id" [net/9p/9pnet_rdma.ko] undefined!

Good catch.

 >  config NET_9P_RDMA
 > -	depends on NET_9P && INFINIBAND && EXPERIMENTAL
 > +	depends on INET && INFINIBAND && EXPERIMENTAL

I wonder if there's a way to make this depend on INFINIBAND_ADDR_TRANS
instead of INET, since that's the real dependency to get the rdma_*
symbols.  However INFINIBAND_ADDR_TRANS is a bool that gets set to y iff
INET and INFINIBAND are set, so it's not trivial to make a tristate
depend on it.

Maybe this patch is fine as it is, since the Kconfig dependencies are
unlikely to change anyway...

 - R.