From: Roland Dreier <rdreier@cisco.com>
To: hawkes@sgi.com
Cc: Kenneth Chen <kenneth.w.chen@intel.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Jack Steiner <steiner@sgi.com>,
Jes Sorensen <jes@sgi.com>
Subject: Re: [PATCH] fix alloc_large_system_hash roundup
Date: Wed, 15 Mar 2006 09:40:52 -0800 [thread overview]
Message-ID: <adazmjr38t7.fsf@cisco.com> (raw)
In-Reply-To: <20060315173639.11102.71657.sendpatchset@tomahawk.engr.sgi.com> (hawkes@sgi.com's message of "Wed, 15 Mar 2006 09:36:39 -0800")
> /* rounded up to nearest power of 2 in size */
> - numentries = 1UL << (long_log2(numentries) + 1);
> + numentries = 1UL << (long_log2(2*numentries - 1));
How about just using roundup_pow_of_two()? You could kill the comment
too then.
- R.
next prev parent reply other threads:[~2006-03-15 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-15 17:36 [PATCH] fix alloc_large_system_hash roundup hawkes
2006-03-15 17:40 ` Roland Dreier [this message]
2006-03-15 18:29 ` Chen, Kenneth W
2006-03-15 18:41 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adazmjr38t7.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=hawkes@sgi.com \
--cc=jes@sgi.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox