From: Roland Dreier <rdreier@cisco.com>
To: "Michael S. Tsirkin" <mst@mellanox.co.il>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [openib-general] Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
Date: Sun, 12 Feb 2006 08:37:48 -0800 [thread overview]
Message-ID: <adazmkw3543.fsf@cisco.com> (raw)
In-Reply-To: <20060212075037.GA11550@mellanox.co.il> (Michael S. Tsirkin's message of "Sun, 12 Feb 2006 09:50:37 +0200")
Michael> Basically, its as Andrew said: the lock around clear_bit
Michael> is there to ensure that ipoib_mcast_send isnt running
Michael> already when we stop the thread. Thats why test_bit has
Michael> to be inside the lock, too.
Makes sense I guess. If I'm understanding correctly, the lock isn't
really there to serialize the bit ops, but rather to make sure
ipoib_mcast_send() won't do anything after we clear the bit.
Does that mean that there's no reason to take the lock around the set_bit()?
- R.
next prev parent reply other threads:[~2006-02-12 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-11 20:22 [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped Roland Dreier
2006-02-11 20:22 ` [git patch review 2/4] IPoIB: Fix another send-only join race Roland Dreier
2006-02-11 20:22 ` [git patch review 3/4] IB/mthca: Don't print debugging info until we have all values Roland Dreier
2006-02-11 20:22 ` [git patch review 4/4] IPoIB: Yet another fix for send-only joins Roland Dreier
2006-02-11 22:02 ` [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped Andrew Morton
2006-02-12 2:03 ` Roland Dreier
2006-02-12 7:50 ` [openib-general] " Michael S. Tsirkin
2006-02-12 8:13 ` Kyle Moffett
2006-02-12 8:19 ` Michael S. Tsirkin
2006-02-12 16:37 ` Roland Dreier [this message]
2006-02-12 16:56 ` [openib-general] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adazmkw3543.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@mellanox.co.il \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox