From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B4F825FA05 for ; Thu, 9 Apr 2026 00:42:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775695325; cv=none; b=KwQI7UZ4tsUJNmPbD3frvF2cyogcrzuF6J7NCAWaNNfV8Nv1OkVWl1LEFDbKVNXviaAOEbPIL3HsPML0w8cS9sXzEGg+yipd2+XcBp4FBAB58hJGJ2IJ6snzKkn0d1gyA5LQhQvejWzeDXLtC2kdDBiqfFI/ch3Vs4F6dfExhM0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775695325; c=relaxed/simple; bh=I8+D2rIPYlmBL8Vtp9AQuj++1M4cYDSlEqpsNTwvx5M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KAMJ/kjNfMBoi25ePOULGjlSwfcBtlawJt13QIsEE7JrkFwr1BCSvgkMH7vWzQFvwVzKQjsR2FuOptetZlqyNKk2j3FW89sXoPj3ykYcikDMNFh+tERu2kneBKRDKI7f68tdv9VnLIhOO5VubcJfYCODS2oD8HR519Af310gMTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BJrdtkpA; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KYHSRnkp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BJrdtkpA"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KYHSRnkp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775695323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t4QXOBa/UPZ9Yv/mDvjcaoQFWTAL3SoG9ObyNB8G5Q0=; b=BJrdtkpAGsRACgTrEWMWZwUOmvzKdwCi6DPoIE7u1Y0U5nESU0f9nLe/23Z2UKAe8V3yC8 aY8rNc5T4AvOkbvTmaz227o2iSF7gvBCTdtv9BZSPVjxz7pHV3sG392hyom3sKhM2xLtkd SgzNf5xud0bAnS91/1y8uTZpspdM/VM= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-gnBEq6w7NPKBZGqq8RvPdg-1; Wed, 08 Apr 2026 20:41:59 -0400 X-MC-Unique: gnBEq6w7NPKBZGqq8RvPdg-1 X-Mimecast-MFC-AGG-ID: gnBEq6w7NPKBZGqq8RvPdg_1775695319 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50d84b5f73bso21602151cf.0 for ; Wed, 08 Apr 2026 17:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775695319; x=1776300119; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=t4QXOBa/UPZ9Yv/mDvjcaoQFWTAL3SoG9ObyNB8G5Q0=; b=KYHSRnkpiMUsLlxHaqpbS23w8JDN/UmxRar2cvbLbFI+rIuO1mU/LXEGRTX+mlyLuQ e5/ipAV0Thpdhv4B9DHqjFjbt8PawMvTvIF4Nx0RRwz9O6xfSNZTTDEa9YCaPzbqvlV8 FN9spV+Uibc+6zhH47llqgTmUHnRgnzyQt9SoPvNi07m0PIbK/c/AO/DBovg9uS0Ev25 DHXoHQalP3bENkpqS+B9VhNBi3JJFLZfXtTjKoQIHe3Ogh6IjHXJwsCboPJyea/u7PrG qtTPL4Z+0UT2M64IONi8VUADiIYk+EBL/7tadfQaxHR09PrXLBDsK69skFdUTq8VAur7 mrHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775695319; x=1776300119; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=t4QXOBa/UPZ9Yv/mDvjcaoQFWTAL3SoG9ObyNB8G5Q0=; b=EZ/fyBAHv1S/Vq3LWWp3CqJT1HOpcEVuHS6FwQLHAGMXIQN+1cSr1RL2jY+7JSR/gX R+fPTzWJO+cd3eK15NofW08iNf8RIRIbs6+dDqecc62qLEVOwvaT1p6ssBr3wZxq+bJl ZZ15beuBWtK8SmmDtsfur4f5sWptw15GorR1mSPd8fMAyblPl4QgUmn5CsZobuIpbxec IZ/DrOTRgbgFrhXK9pWr7NdczQDDDGhQEnmyiCH0eVteiWF4jsyuWcamiAhLjQktSB99 VIH8BN/pjr9RZuAoRVT4y6FhaidCs8K1LQEqGC60lgo2Vwu/zpECwQCS1DtPfLDujK+v v4eg== X-Forwarded-Encrypted: i=1; AJvYcCWlcNsgIou7VYxGuihJz1kRbfaO4jBK/I0HE6lowk0QgVD0AyFu0bhRudkp04i9U9H1Klm0+w/tkCx3V5A=@vger.kernel.org X-Gm-Message-State: AOJu0YzFQDe2DLlLpuPqUjCjB8TlWyHk9ZGo33sfjaRJCBEIQSU1jk1B sWuJCLTG9ou7O1Er0zKoro6DNjhBTjfOwWGQkYezpW8otPhJgqrl9UxpKrAr/TY5ydfpkScviP4 DNEnuhug74zxpL/tCGLvyDZ7E7aQScCiVd5Z1b8MuyiEKi/TAgHsoB1RNp98XoWuE2w== X-Gm-Gg: AeBDiesxTUpQAfGZa6WN0h5s7ta0SSjmYfPOsFNwxnrxFV1qzbghQAy7KxOR4REmBwO YvPUzHr0b6qCBKISRD7bcv8jAC7D7gWyCO2QHUA6GWITN1f5cDEVyAKNi3V39AgROG26Vlx9ZV/ C9gOjLCyZMBvUg1hePXOonC6qdjcz65LR7ZP5MBvuixwUNvoF0F0WIl5dhsAzQ1L05BSAH2qv6h klICiahY6IeOETGvR3F8oVuO1/TFzyZGWUuLo6XY+mQaxKtb2O49b0Ixb1DpiTP7mx50ke0YYm6 AyzKgnYp+yw0JK0Jt78f3M2RQiBrSzRHsO005SF8Wd7bgbSkQOny/2iJRyfj3x5tzOXig3wMZyy Lxnn2GbF/jVJb5GGRq2/5FgcuB4dE/tJ2Chijrf12rB7YcTOb2OjdbH25 X-Received: by 2002:a05:622a:5c07:b0:50d:84e4:e1f6 with SMTP id d75a77b69052e-50dc228af69mr23516771cf.33.1775695319031; Wed, 08 Apr 2026 17:41:59 -0700 (PDT) X-Received: by 2002:a05:622a:5c07:b0:50d:84e4:e1f6 with SMTP id d75a77b69052e-50dc228af69mr23516491cf.33.1775695318605; Wed, 08 Apr 2026 17:41:58 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50dac753208sm39931121cf.20.2026.04.08.17.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 17:41:57 -0700 (PDT) Date: Wed, 8 Apr 2026 20:41:54 -0400 From: Brian Masney To: Marek Vasut Cc: linux-clk@vger.kernel.org, Michael Walle , Conor Dooley , Krzysztof Kozlowski , Michael Turquette , Michael Walle , Rob Herring , Stephen Boyd , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 6/6] clk: fsl-sai: Add MCLK generation support Message-ID: References: <20260409002952.319668-1-marex@nabladev.com> <20260409002952.319668-6-marex@nabladev.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260409002952.319668-6-marex@nabladev.com> User-Agent: Mutt/2.3.0 (2026-01-25) On Thu, Apr 09, 2026 at 02:29:06AM +0200, Marek Vasut wrote: > The driver currently supports generating BCLK. There are systems which > require generation of MCLK instead. Register new MCLK clock and handle > clock-cells = <1> to differentiate between BCLK and MCLK. In case of a > legacy system with clock-cells = <0>, the driver behaves as before, i.e. > always returns BCLK. > > Note that it is not possible re-use the current SAI audio driver to > generate MCLK and correctly enable and disable the MCLK. > > If SAI (audio driver) is used to control the MCLK enablement, then MCLK > clock is not always enabled, and it is not necessarily enabled when the > codec may need the clock to be enabled. There is also no way for the > codec node to specify phandle to clock provider in DT, because the SAI > (audio driver) is not clock provider. > > If SAI (clock driver) is used to control the MCLK enablement, then MCLK > clock is enabled when the codec needs the clock enabled, because the > codec is the clock consumer and the SAI (clock driver) is the clock > provider, and the codec driver can request the clock to be enabled when > needed. There is also the usual phandle to clock provider in DT, because > the SAI (clock driver) is clock provider. > > Acked-by: Michael Walle > Signed-off-by: Marek Vasut Reviewed-by: Brian Masney