From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C9893A63F3 for ; Thu, 9 Apr 2026 09:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775728198; cv=none; b=T3n1Ejz+xzbS8ZyQ4p+WRUB5IoGpiwvr9yTkIifH4CUPnYQLIjCM/RedOXochD6lu0VwTFy68agyV4ygkEariNfR9aH5KiUoQWg6NkO4dJGVAO9xlu5bosHH8uHIraI0ccM/gvIvOZePRDNrBfWUrbZgmsvJQTDnv/SquUwB5xc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775728198; c=relaxed/simple; bh=BjHgzWPU4OMPOehpMtEWVLp3gJWo8761wDntRpP7FUM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HZVcFGXck80NLyLkBPU0eLQybqx3HC0wuKyZXbNiy64L0CXPMMhWsxcdIwvTSK47QhWfYD0FnKHPbtsPZITgiVUQEcz1xE0tSyAhU7CKrXLHqJ0pRmWZPFx397FLF5I43Hd5HgsU93NNYa6wO2zorJfkvldc+SAGAbDixw4S8kI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qRXm6yKt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qRXm6yKt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D49A8C4CEF7; Thu, 9 Apr 2026 09:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775728198; bh=BjHgzWPU4OMPOehpMtEWVLp3gJWo8761wDntRpP7FUM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qRXm6yKtFM4JonFvvIPvLquXxSuua7wUDhiSi4nuNc+n1HUAG0Hic97qoWEMA13na llhWgdVpWdByBAERoJ/zilD0GC/FmqkhLxOx6sUYxkLsQygWNXbzhTC+qSSYvCzDDI 9p1Eas9Ga0iOyrEbW5fTgEfRHhCn22qhsL6GjxiHM8NvhoDPEYIIQCQFOSeF6gO3WT WJ+zGKYikv5e9tHVN2Vf/YbjRjYPbD7kdpJRYQX46Gd7HQG75ItC3VM1GHk0i64bDl LB/wSCFfFi8AOzDbIH0ECovwAYQ8SYkUEvFQZh4utnQTLRFdp6QdPKBS5wI4a5V77w yBepCnWs55MBw== Date: Thu, 9 Apr 2026 11:49:52 +0200 From: Niklas Cassel To: Anand Moon , Shawn Lin Cc: Vinod Koul , Neil Armstrong , Heiko Stuebner , "open list:GENERIC PHY FRAMEWORK" , "moderated list:ARM/Rockchip SoC support" , "open list:ARM/Rockchip SoC support" , open list Subject: Re: [PATCH v1] phy: rockchip-snps-pcie3:phy: Configure clkreq_n and PowerDown for all lanes Message-ID: References: <20260409044939.7647-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260409044939.7647-1-linux.amoon@gmail.com> +Shawn Hello Anand, On Thu, Apr 09, 2026 at 10:19:30AM +0530, Anand Moon wrote: > During the rk3588_p3phy_init sequence, the driver now explicitly Please use imperative mood, active voice. > configures each lane's CON0 register to ensure > - PIPE 4.3 Compliance: clkreq_n (bit 6) is forced low (asserted) to meet > sideband signal requirements. > - Active Power State: PowerDown[3:0] (bits 11:8) is set to P0 > (Normal Operational State) to ensure the PHY is fully powered and ready > for link training. > > These changes ensure that all lanes are consistently transitioned from > reset into a known-good operational state, preventing undefined behavior > and ensuring the PHY is ready for high-speed data transmission. First describe the problem, then describe how you fix it. Kind regards, Niklas