Re: [PATCH V10 3/4] iio: adc: Add support for QCOM PMIC5 Gen3 ADC

Jishnu Prakash
2026-03-17T13:33:53Z

Hi Daniel,

On 2/24/2026 2:01 AM, Jonathan Cameron wrote:
> On Mon, 23 Feb 2026 17:49:18 +0530
> Jishnu Prakash <jishnu.prakash@oss.qualcomm.com> wrote:
>
>> Hi Jonathan,
>>
>> On 2/7/2026 10:26 PM, Jonathan Cameron wrote:
>>> On Fri, 6 Feb 2026 18:45:02 +0530
>>> Jishnu Prakash <jishnu.prakash@oss.qualcomm.com> wrote:
>>>
>>>> Hi Jonathan,
>>>>
>>>> On 1/31/2026 11:09 PM, Jonathan Cameron wrote:
>>>>> On Fri, 30 Jan 2026 17:24:20 +0530
>>>>> Jishnu Prakash <jishnu.prakash@oss.qualcomm.com> wrote:
>>>>>
>>>>>> The ADC architecture on PMIC5 Gen3 is similar to that on PMIC5 Gen2,
>>>>>> with all SW communication to ADC going through PMK8550 which
>>>>>> communicates with other PMICs through PBS.
>>>>>>
>>>>>> One major difference is that the register interface used here is that
>>>>>> of an SDAM (Shared Direct Access Memory) peripheral present on PMK8550.
>>>>>> There may be more than one SDAM used for ADC5 Gen3 and each has eight
>>>>>> channels, which may be used for either immediate reads (same functionality
>>>>>> as previous PMIC5 and PMIC5 Gen2 ADC peripherals) or recurring measurements
>>>>>> (same as ADC_TM functionality).
>>>>>>
>>>>>> By convention, we reserve the first channel of the first SDAM for all
>>>>>> immediate reads and use the remaining channels across all SDAMs for
>>>>>> ADC_TM monitoring functionality.
>>>>>>
>>>>>> Add support for PMIC5 Gen3 ADC driver for immediate read functionality.
>>>>>> ADC_TM is implemented as an auxiliary thermal driver under this ADC
>>>>>> driver.
>>>>>>
>>>>>> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
>>>>> Hi Jishnu
>>>>>
>>>>> Whilst there are a couple of comments below, I think this is ready to go.
>>>>> Unfortunately this is just a few days too late to merge for this coming
>>>>> cycle as I need to send the IIO pull request today or tomorrow (due to going
>>>>> through char-misc) so this would get no soak time in next.
>>>>>
>>>>> Also, I'm not sure how we actually want to merge this given close coupling with
>>>>> the thermal driver. Perhaps best bet is I do an immutable branch of next rc1
>>>>> once available that we pull into both trees. That would have the first 3 patches
>>>>> on it.
>>>>>
>>>>> Jonathan
>>>>>
>>>>>> diff --git a/drivers/iio/adc/qcom-spmi-adc5-gen3.c b/drivers/iio/adc/qcom-spmi-adc5-gen3.c
>>>>>> new file mode 100644
>>>>>> index 000000000000..f8168a14b907
>>>>>> --- /dev/null
>>>>>> +++ b/drivers/iio/adc/qcom-spmi-adc5-gen3.c
>>
>> ....
>>
>>>>
>>>> Also, is it alright if I push the next series to address
>>>> your comments immediately? Would you be able to include patches 1-3
>>>> in the immutable branch you mentioned, once it's available?
>>> It's fine to post a v11. I'll only be building that immutable tree
>>> after 7.0-rc1 is out (or 6.20-rc1 depending on Linus' decision on naming
>>> for the cycle that is about to start)
>>>
>>
>> It looks like kernel 7.0-rc1 is out now and I had posted v11 here earlier:
>> https://lore.kernel.org/all/20260209105438.596339-1-jishnu.prakash@oss.qualcomm.com/,
>>
>> so can you please check this latest series and pick patches 1-3 if there
>> are no issues?
>
> Sure. Immutable branch created. However, I'd suggest the thermal folk don't
> pick this up until it's had a little soak time. Today I've pushed it out for
> 0-day to have a look (as part of the testing branch of iio.git). Once those
> results come in I'll push it out as togreg and linux-next will pick it up.
>
> https://web.git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=ib-iio-thermal-qcom-pmic5
> https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git ib-iio-thermal-qcom-pmic5
>

Jonathan has picked patches 1-3 of this series in an immutable branch and I see
they are also present in linux-next now. Is it possible for you to pick
patch 4 into the thermal tree?

Link: https://lore.kernel.org/all/20260130115421.2197892-5-jishnu.prakash@oss.qualcomm.com/

Thanks,
Jishnu

> Thanks,
>
> Jonathan
>
>>
>> Thanks,
>> Jishnu
>>
>>> Thanks,
>>>
>>> Jonathan
>>
>