Re: [PATCH V10 4/4] thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring

Jonathan Cameron
2026-02-07T16:55:37Z

On Fri, 6 Feb 2026 18:45:22 +0530
Jishnu Prakash <jishnu.prakash@oss.qualcomm.com> wrote:

> Hi Jonathan,
>
> On 1/31/2026 11:24 PM, Jonathan Cameron wrote:
> > On Fri, 30 Jan 2026 17:24:21 +0530
> > Jishnu Prakash <jishnu.prakash@oss.qualcomm.com> wrote:
> >
> >> Add support for ADC_TM part of PMIC5 Gen3.
> >>
> >> This is an auxiliary driver under the Gen3 ADC driver, which implements the
> >> threshold setting and interrupt generating functionalities of QCOM ADC_TM
> >> drivers, used to support thermal trip points.
> >>
> >> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
> >
> > Hi Jishnu.
> >
> > Some minor editorial style stuff below if you are spinning again.
> > Otherwise this looks good to me
> >
> > Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> > Given I expect this patch will go through the thermal tree and not IIO.
>
> Just to confirm, would it be fine to keep your Reviewed-by tag in place
> if I only make changes in this patch to address your comments, in the
> next patch series?
When you say next patch series do you mean a v11? Or a separate follow up series?
We have time now as the necessary immutable branch won't be for at least 2 weeks
(need rc1 to be released).

Yes. You only need to drop tags if making significant changes from what
was tagged. If you do drop them once given, call out why under the --- for the
new patch.

Jonathan

>