From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79AF933CEB0 for ; Thu, 9 Apr 2026 07:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775719705; cv=none; b=iWHzQ1MaW+1LtHJtTP80iySPa5/do9jxTa5Uvn7w7AOZIbwnd/sxPLTnKYMwF52y70Hh4iuNC7V3bz9xXLQGcQm29bDaUtVmnUMX/Ik8xQoq9tv1LTt8gP+3JObM0579ixYrcjEgfe5finokXE0yXiofDe86Ck3GLLKLXTuUEa0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775719705; c=relaxed/simple; bh=AFuuA2kCB0WPBJmWs5H/bbbfp3vCGHCkATOf0ZR5z9M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JEC3K94Aj7aQgS6fAJqdYekXfXZwD2nFHHHCJcc3Nccx5NXKu2vgLUaMqALPgymjvtQhcTc0KLevA8CCA6o5U8uMJfZGjYQgjKJt5LjX4rHfakB37CFWN6HtJlarVeqCl3+90D3rd0ZHdmq9y+W7Q7j7gsGIIdfioq4PY+XLRPU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=snl255t/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="snl255t/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DECB2C4CEF7; Thu, 9 Apr 2026 07:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775719705; bh=AFuuA2kCB0WPBJmWs5H/bbbfp3vCGHCkATOf0ZR5z9M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=snl255t/ijvpw2tmon99P0lAzmqZktGYSNqXj8saf8pOUOiHC+uzvhCYZorST+wn6 Fp6CHfYF0mvg5/ifr+XSdFAelF7GKuSMtEiIcaO16BS7uaraJ9qEHKIWOGmz37NhP5 ULjT2tDHlrmtFXlhJzfArfl6ZQ6odmZp2eDoRHmlu2Sl/9nrJtFcOl4l4i927QIN3O e8tiuqSUxQCCBAS2WRTqOHnq8O30WFOg5SSgxhWrJg0x1TV6o29pvY5SEWPJhOorLG VeI/+My+OY7gbTBwIb/Xyy2nEljyJxrQjt6BDITKpFZk6ythIwhBr1wM3i17MHaVbQ ToN6G9ZCqGCVQ== Date: Thu, 9 Apr 2026 08:28:19 +0100 From: Lorenzo Stoakes To: Ye Liu Cc: Andrew Morton , David Hildenbrand , Ye Liu , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/khugepaged: use ALIGN helpers for PMD alignment Message-ID: References: <20260409014323.2385982-1-ye.liu@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260409014323.2385982-1-ye.liu@linux.dev> On Thu, Apr 09, 2026 at 09:43:22AM +0800, Ye Liu wrote: > From: Ye Liu > > PMD alignment in khugepaged is currently implemented using a mix of > rounding helpers and open-coded bitmask operations. > > Use ALIGN() and ALIGN_DOWN() consistently for PMD-sized address range > alignment, matching the preferred style for address and size handling. > > No functional change intended. > > Signed-off-by: Ye Liu LGTM, so: Reviewed-by: Lorenzo Stoakes > > Changes in v2: > - Switch to ALIGN()/ALIGN_DOWN() per David's suggestion. > - Also convert collapse_scan_mm_slot() to keep PMD alignment helpers > consistent within khugepaged. > - Update the changelog accordingly. > - Link to v1:https://lore.kernel.org/all/20260408093534.2373007-1-ye.liu@linux.dev/ > --- > mm/khugepaged.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 1e2bff40d014..1b1d1a881ec3 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2518,8 +2518,8 @@ static void collapse_scan_mm_slot(unsigned int progress_max, > cc->progress++; > continue; > } > - hstart = round_up(vma->vm_start, HPAGE_PMD_SIZE); > - hend = round_down(vma->vm_end, HPAGE_PMD_SIZE); > + hstart = ALIGN(vma->vm_start, HPAGE_PMD_SIZE); > + hend = ALIGN_DOWN(vma->vm_end, HPAGE_PMD_SIZE); > if (khugepaged_scan.address > hend) { > cc->progress++; > continue; > @@ -2835,8 +2835,8 @@ int madvise_collapse(struct vm_area_struct *vma, unsigned long start, > mmgrab(mm); > lru_add_drain_all(); > > - hstart = (start + ~HPAGE_PMD_MASK) & HPAGE_PMD_MASK; > - hend = end & HPAGE_PMD_MASK; > + hstart = ALIGN(start, HPAGE_PMD_SIZE); > + hend = ALIGN_DOWN(end, HPAGE_PMD_SIZE); > > for (addr = hstart; addr < hend; addr += HPAGE_PMD_SIZE) { > enum scan_result result = SCAN_FAIL; > -- > 2.43.0 >