RE: [PATCH net v2 2/2] net: phy: micrel: remove ksz9131_resume()

Ovidiu Panait
2026-04-09T12:58:22Z

Hi Russell,

>
> I think we need a simple solution for 7.0, but subject to Andrew's
> agreement, I think we should consider having phy_init_hw() inside
> phy_resume(), and a series of cleanup patches that result from that
> change, including getting rid of unnecessary code in micrel.c for
> the next kernel cycle. As I say, subject to Andrew's agreement, please
> can you look into this. Thanks.
>

I think the phy_init_hw() should be inside __phy_resume(), as some drivers
call phy_start()/phylink_start() directly in their resume paths, without
calling into phy_resume() first.

Some drivers also call phylink_resume() in their resume paths, which goes
through phylink_start() -> phy_start().

I think this will cover all the cases.

Ovidiu

> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!