From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 910F62E0925 for ; Thu, 9 Apr 2026 15:11:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775747502; cv=none; b=g5UzL3v6klQOLpyxeq4r+5DTMNqEsx7fzFQ/4cxXYxil9WX8PryQmVQ33iWsZdW0JtL1bfAX1gxDiZ0skeaWfcph9Khp6KFzhVObb7PEDpcranr3yYpDf5fHaXzG5+8k8KxSKTBtj7mj2JBRa7Zg+mVqFaazrnPZARE5nE02Zoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775747502; c=relaxed/simple; bh=KFCI6V1rO1y+xOef/LA1LfimklhqeVXX7IveWVt1pR0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jYd5m0klvpH9KPe/vYmoufCJFxf8w3anhWSdt/7LKFlB8H/uXLrynOqxHD20w7V0aVSPjnWx4ENOXw9TJAXS/sanDkXJLAtY7kTsvrjIpLEGq0lZLA51kgRudFrPRLrtSOE6gLTCDEv+xjh9hbrxATRkEptQ55/xeYntfYAbNig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n7I0kteo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n7I0kteo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D58BC116C6; Thu, 9 Apr 2026 15:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775747502; bh=KFCI6V1rO1y+xOef/LA1LfimklhqeVXX7IveWVt1pR0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n7I0kteoBfVBAO4NM+dn3SiWgNPYH6WufMcI7EfNaUzOSVb62RGST4az+Oy9VXVCy KINxPsK34ExMnEypjO5Hmxm3BQB01JZ2AKZq30Rq1t3QgQS+dYwHE1YnwGp3fKGMym 9artXLDZNPjS6t46RhIpbtEHfpY3rYEDKBNsvMkOIgEFaxKbiDyZaLRzRWs4SvN+k2 uqfmHtkPaVVjqecf6/wdMT39JqZ1S50nFcgrpgQ+L96s9ZBncM4kcTQ1h4/0Xgir8w Bd/tSati6bvFhu3I3D1eizTb0gp8XutMzrmWvf7tKQWdBH51JqSU7XD1woZoqDaabZ 2LFAuBdKpaFow== Date: Thu, 9 Apr 2026 18:11:35 +0300 From: Mike Rapoport To: Breno Leitao Cc: Alexander Graf , Pasha Tatashin , Pratyush Yadav , SeongJae Park , Andrew Morton , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH] kho: call kho_kexec_metadata_init() for both boot paths Message-ID: References: <20260409-kho_fix_merge_issue-v1-1-710c84ceaa85@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260409-kho_fix_merge_issue-v1-1-710c84ceaa85@debian.org> On Thu, Apr 09, 2026 at 03:31:40AM -0700, Breno Leitao wrote: > kho_kexec_metadata_init() was placed after the fdt check, causing it to > run only on the fresh boot path (no incoming FDT) and skipping metadata > initialization on the KHO restore path. > > The original patch[1] was based on commit 5c9e55fecf93658 ("Add linux-next > specific files for 20260312"), which included commit d7176a010afce8 > ("kho: fix deferred init of kho scratch"). That commit has since been > rebased and reworked in linux-next, changing the code flow so that > kho_kexec_metadata_init() is no longer reached on the restore path. > > Fix this by moving the call before the fdt check so it runs regardless > of whether an incoming FDT is present. > > Link: https://lore.kernel.org/all/20260309-kho-v8-5-c3abcf4ac750@debian.org/ [1] > Fixes: 047117e78331a ("kho: kexec-metadata: track previous kernel chain") > Signed-off-by: Breno Leitao Acked-by: Mike Rapoport (Microsoft) > --- > kernel/liveupdate/kexec_handover.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) -- Sincerely yours, Mike.