From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B9D73DD530 for ; Thu, 9 Apr 2026 17:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775755016; cv=none; b=lXra5oVN3kghUbOH6UVVd3pIZwj81trchBbiB/8980xMTSd+BD9RawAGhTWpl1hY5v8XQO8K9wpy+e1o0coXz2Kl3cLynylREJBufYPtunWngR3LQrNnk8jWSig/RVoT+WXlzFUzni16fy0oXy66DP4WB/5xev2lyh0dso3jrlM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775755016; c=relaxed/simple; bh=S60+iELf201hWfWsA0+5HzASsARSxTciNv62Lq5+S90=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xylw19Vlp9iUFp2tyCLPrbau150Ejwga+iWnDVTnL+/5oNl00yTYYcdsnqWheH5M5IbJkUJYX4HRO16Z99ipgZYTtilUlbGxdPZpan4cYqcfX7X3yuxtMWYGetnzjIo90wvlRuGtvlom27qKTC3nHKta2q9A9RANBtau+sLirfs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ix9GuZZA; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ix9GuZZA" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-12c287eb77fso345959c88.1 for ; Thu, 09 Apr 2026 10:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775755011; x=1776359811; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OiUmxJypMk7dUgMF/8X+eU6lB0Kg/0QHff8vgI/w/kA=; b=Ix9GuZZA7oD3oe45n0dpQmNG+x2p3bO3hgebWxOV2WoySs6B/HLyE6lPOdXKM1guQQ /O31QDbYhoG+obtxcw03evTeIhKf2vU5JrIIsH3ylr6+RunTX9vpy5NCRAbgZwSIpp/S 7jftrBtpowJOe9riVQ60YmAm4o8MBNkll0nXQSaDvYZ9Dks9RVCswpJNh69uNQWg5q37 zfMGmpM1OMsSrCn2tU+iFMQ9X5gjw3DBc0MLFOzmkCCaLM4qbjjVHhdfAphEfet8yso9 yrjwYi+No1UGdcvaX5/yv2aYpsEGlQVhs20REHeZWDCVsnDWKMBRiuPw86e02y/L0Cps WQSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775755011; x=1776359811; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OiUmxJypMk7dUgMF/8X+eU6lB0Kg/0QHff8vgI/w/kA=; b=UmO05rj5jy+El2RGcHIgQXqlPJdz5vT/El57bMqILykqv+7nVQc+Ybsvy34Ji57o14 3ToMxD6neEjJZc99+dql/kGS8uJjF/naQw/aCqXKs766KZ6HDYGUyJv+/vDFC/AtwpIp drW4FIscOTNLFTiAmpf5zsA9NHkh+2eSOMMVhJvIe5x04J/bKCkqMjcw314OIIb0rakJ W/Nrl6vMKZlkYO02wFzF0a3ZPOIz9HrQ3M7iHKn/yAJsUe3poIYw0U+/RXm6aQSVUecb tMvbg8kxt2yAYZvhKyLjEMY/9WfpM9eeHvcFa+JyNcnMA/+/qtG93g2eJynU6F3DB0LJ hYuA== X-Forwarded-Encrypted: i=1; AJvYcCX9K8uizdlaqKmiptGJMOGk2PAvPRgGJMG+3PeA8maCWiNOJPJiKAy7vZi1/Nlkd6+aP3vucE7qBcTuO74=@vger.kernel.org X-Gm-Message-State: AOJu0YyMivCHYoh2de59cfIBsDwadM8UVk5JtZygEFlsJkawZWii9FTT oeiiw4wzAGvY05DdA+K1Uhef6Lr6nEgbWh1ikHnKUP29bUDhBzZvQ5yB X-Gm-Gg: AeBDietCGEIGPLXQlASuklu5xftN1mXw/eZOKsdb12cKq7MuxSZkpJzaN4iKL6eQdup pWtosIgjhT+rFeoZNqtYIYa8Atvxq0o/Czi+wFs7RCdJFxwkf+yNH2JJnVijIoGATWORaQZGdCq j0i1QN+siSu2dLGlfNiChk3Un0b5VCz3mToR1pLPQudYbRvgJ+fzNuW8ZJpzB5NwPnLR5KeRNlQ oZIuqetW4L3RFFhYXN0n2q8bpio7SaLuDtQlC4xgoDAQ/2uw84bNpg3BnYD5GeLcHU3AwBV10LI rw0iUfFrJQaudxHZYGUZK+7/B6g+BoqL2jTTJtr6XMVDDK+JbAC6/y06l6dWVg7mMdpc5eV4fHL hq0m2RVOW8h0NG8M161rS4bhdIlIXtMcQQYVzPffLocCPN8k3lQTA07bOUBFv+5cmr3R/8Rgt3i 8emove4NvhZV/AqQ3+qJR6IxNcYPge6TdABjkGIJluBEIhntZ8QkB5uh/C7lksSBOp X-Received: by 2002:a05:693c:2b17:b0:2c3:5dc0:a06b with SMTP id 5a478bee46e88-2d40defc97fmr3118618eec.20.1775755011019; Thu, 09 Apr 2026 10:16:51 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:12ff:7738:6560:2618]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2d55ff826dcsm484882eec.13.2026.04.09.10.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 10:16:50 -0700 (PDT) Date: Thu, 9 Apr 2026 10:16:46 -0700 From: Dmitry Torokhov To: Conor Dooley Cc: Jingyuan Liang , Jiri Kosina , Benjamin Tissoires , Jonathan Corbet , Mark Brown , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-trace-kernel@vger.kernel.org, devicetree@vger.kernel.org, hbarnor@chromium.org, tfiga@chromium.org, Dmitry Antipov , Jarrett Schultz Subject: Re: [PATCH v3 09/11] dt-bindings: input: Document hid-over-spi DT schema Message-ID: References: <20260402-send-upstream-v3-0-6091c458d357@chromium.org> <20260402-send-upstream-v3-9-6091c458d357@chromium.org> <20260409-defuse-thank-4b038128fac5@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260409-defuse-thank-4b038128fac5@spud> On Thu, Apr 09, 2026 at 05:02:11PM +0100, Conor Dooley wrote: > On Thu, Apr 02, 2026 at 01:59:46AM +0000, Jingyuan Liang wrote: > > Documentation describes the required and optional properties for > > implementing Device Tree for a Microsoft G6 Touch Digitizer that > > supports HID over SPI Protocol 1.0 specification. > > > > The properties are common to HID over SPI. > > > > Signed-off-by: Dmitry Antipov > > Signed-off-by: Jarrett Schultz > > Signed-off-by: Jingyuan Liang > > --- > > .../devicetree/bindings/input/hid-over-spi.yaml | 126 +++++++++++++++++++++ > > 1 file changed, 126 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/input/hid-over-spi.yaml b/Documentation/devicetree/bindings/input/hid-over-spi.yaml > > new file mode 100644 > > index 000000000000..d1b0a2e26c32 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/hid-over-spi.yaml > > @@ -0,0 +1,126 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/input/hid-over-spi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: HID over SPI Devices > > + > > +maintainers: > > + - Benjamin Tissoires > > + - Jiri Kosina > > Why them and not you, the developers of the series? > > > + > > +description: |+ > > + HID over SPI provides support for various Human Interface Devices over the > > + SPI bus. These devices can be for example touchpads, keyboards, touch screens > > + or sensors. > > + > > + The specification has been written by Microsoft and is currently available > > + here: https://www.microsoft.com/en-us/download/details.aspx?id=103325 > > + > > + If this binding is used, the kernel module spi-hid will handle the > > + communication with the device and the generic hid core layer will handle the > > + protocol. > > This is not relevant to the binding, please remove it. > > > + > > +allOf: > > + - $ref: /schemas/input/touchscreen/touchscreen.yaml# > > + > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - microsoft,g6-touch-digitizer > > + - const: hid-over-spi > > + - description: Just "hid-over-spi" alone is allowed, but not recommended. > > + const: hid-over-spi > > Why is it allowed but not recommended? Seems to me like we should > require device-specific compatibles. Why would we want to change the driver code to add a new compatible each time a vendor decides to create a chip that is fully hid-spi-protocol compliant? Or is the plan to still allow "hid-over-spi" fallback but require device-specific compatible that will be ignored unless there is device-specific quirk needed? > > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + reset-gpios: > > + maxItems: 1 > > + description: > > + GPIO specifier for the digitizer's reset pin (active low). The line must > > + be flagged with GPIO_ACTIVE_LOW. > > + > > + vdd-supply: > > + description: > > + Regulator for the VDD supply voltage. > > + > > + input-report-header-address: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + minimum: 0 > > + maximum: 0xffffff > > + description: > > + A value to be included in the Read Approval packet, listing an address of > > + the input report header to be put on the SPI bus. This address has 24 > > + bits. > > + > > + input-report-body-address: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + minimum: 0 > > + maximum: 0xffffff > > + description: > > + A value to be included in the Read Approval packet, listing an address of > > + the input report body to be put on the SPI bus. This address has 24 bits. > > + > > + output-report-address: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + minimum: 0 > > + maximum: 0xffffff > > + description: > > + A value to be included in the Output Report sent by the host, listing an > > + address where the output report on the SPI bus is to be written to. This > > + address has 24 bits. > > + > > + read-opcode: > > + $ref: /schemas/types.yaml#/definitions/uint8 > > + description: > > + Value to be used in Read Approval packets. 1 byte. > > + > > + write-opcode: > > + $ref: /schemas/types.yaml#/definitions/uint8 > > + description: > > + Value to be used in Write Approval packets. 1 byte. > > Why can none of these things be determined from the device's compatible? > On the surface, they like the kinds of things that could/should be. Why would we want to keep tables of these values in the kernel and again have to update the driver for each new chip? It also probably firmware-dependent. Thanks. -- Dmitry