From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Francisco Maestre <francisco@maestretorreblanca.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] speakup: speakup_soft: fix comment style and repeated word
Date: Fri, 10 Apr 2026 01:33:12 +0200 [thread overview]
Message-ID: <adg3ONvnpCNSv5v3@end> (raw)
In-Reply-To: <20260409220535.98479-1-francisco@maestretorreblanca.com>
Francisco Maestre, le jeu. 09 avril 2026 17:05:35 -0500, a ecrit:
> Fix two comment style issues in speakup_soft.c:
>
> - Remove duplicated word 'the' in a block comment ('the the' -> 'the')
> - Move the closing '*/' of the block comment to its own line, as
> required by the kernel coding style
>
> Assisted-by: Claude:claude-opus-4-5
> Signed-off-by: Francisco Maestre <francisco@maestretorreblanca.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/accessibility/speakup/speakup_soft.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accessibility/speakup/speakup_soft.c b/drivers/accessibility/speakup/speakup_soft.c
> index 6d4468246..57d83b82f 100644
> --- a/drivers/accessibility/speakup/speakup_soft.c
> +++ b/drivers/accessibility/speakup/speakup_soft.c
> @@ -446,8 +446,9 @@ static int softsynth_adjust(struct spk_synth *synth, struct st_var_header *var)
> if (var->var_id != PUNC_LEVEL)
> return 0;
>
> - /* We want to set the the speech synthesis punctuation level
> - * accordingly, so it properly tunes speaking A_PUNC characters */
> + /* We want to set the speech synthesis punctuation level
> + * accordingly, so it properly tunes speaking A_PUNC characters
> + */
> var_data = var->data;
> if (!var_data)
> return 0;
> --
> 2.50.1 (Apple Git-155)
>
--
Samuel
<Y> C'ETAIT PAS UN BUG !
<y> :ppp
<y> c ce qu'on dit ;)
<Y> (j'ai appuye sur ON, ca peut arriver, non ?)
-+- #hp debuggue IRCprime -+-
prev parent reply other threads:[~2026-04-09 23:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 22:05 [PATCH 1/4] speakup: speakup_soft: fix comment style and repeated word Francisco Maestre
2026-04-09 23:33 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adg3ONvnpCNSv5v3@end \
--to=samuel.thibault@ens-lyon.org \
--cc=chris@the-brannons.com \
--cc=francisco@maestretorreblanca.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox