From: Brian Norris <briannorris@chromium.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, Lukas Wunner <lukas@wunner.de>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI/portdrv: Allow probing even without child services
Date: Thu, 9 Apr 2026 16:41:20 -0700 [thread overview]
Message-ID: <adg5IPWdCSv1UqFE@google.com> (raw)
In-Reply-To: <adg0OFkVnT3OiSJd@google.com>
On Thu, Apr 09, 2026 at 04:20:27PM -0700, Brian Norris wrote:
> So is pci_set_master() a one-way operation done in child services (never
> call pci_clear_master()), and the only clear is via
> pcie_portdrv_remove() -> pci_disable_device()?
One other thought about this: it's actually a non-trivial question as to
whether the port is actually going to use MSI (and therefore, need bus
mastering). It depends on the result of pcie_init_service_irqs(),
whether we succeed with MSI or INTx.
We don't actually attempt to answer that question today. But if we did,
we'd have to be scattering that code across all our IRQ-utilizing child
services.
I wonder if all that churn is worthwhile, when it's a relatively
rare/strange case that a port really does *not* want bus mastering
enabled.
Brian
prev parent reply other threads:[~2026-04-09 23:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 1:15 [PATCH v2] PCI/portdrv: Allow probing even without child services Brian Norris
2026-02-19 22:25 ` Bjorn Helgaas
2026-02-20 2:35 ` Brian Norris
2026-02-20 16:40 ` Bjorn Helgaas
2026-04-09 23:20 ` Brian Norris
2026-04-09 23:41 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adg5IPWdCSv1UqFE@google.com \
--to=briannorris@chromium.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mani@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox