From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f41.google.com (mail-dl1-f41.google.com [74.125.82.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2373A39A818 for ; Thu, 9 Apr 2026 23:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775778084; cv=none; b=D71CIu9Lob2GbjaTILgWnSE5a+G8FSBk53dB49BLsmhCXu/YqND8l6ckDMeGRkDMunG12kT5DFm5hxjrvZAJh0Z91JKdIvAllr3LAbtu+h06qUiA/TygfRloS3Tjx+rYm0QMiINB8zvjJy79Po6I81tuFiCxF28uLjkStUIbFI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775778084; c=relaxed/simple; bh=crIvwTLDdPJZQO2fSBCNhoREP2VUZ/EBIc0gjhGlosM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=st+JZsSBEYLYlYih1C6ZQz8M+0KqhdqXBvZ9XojCOapy1t2K3ak1uc0DQpxLckqoymXgXf1Euug4C8Xy6aPK8VwkeKxmh4iVMvjknMpShJ0N4bLvezmsOn3H+XWh29MOk59tic9FpHm98PZm3p6dSZBxZHreeh6ru9D8OUaWkzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=JblYIJIF; arc=none smtp.client-ip=74.125.82.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JblYIJIF" Received: by mail-dl1-f41.google.com with SMTP id a92af1059eb24-12c2575ff49so1087889c88.1 for ; Thu, 09 Apr 2026 16:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1775778082; x=1776382882; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=crIvwTLDdPJZQO2fSBCNhoREP2VUZ/EBIc0gjhGlosM=; b=JblYIJIFhjpw6THx6+gJ3znqFs7U9ihTBmwm0kkPor7FS7jcG/WO0bBYg/EzkO4aSC R5EVKGbiHGgkfAncFWB7NaBCAxI+/Te46GQYQ1+0lx0kYRX+PsBUh+NihbHjUvcoFqOO elbNPsd0Dp9AMfRWw/rzP14Wr/Aw9YejHqp5s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775778082; x=1776382882; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=crIvwTLDdPJZQO2fSBCNhoREP2VUZ/EBIc0gjhGlosM=; b=ovigsHmunBU6dSf3t/vABBNoGbQWPTGl0WdzOuwOGewLvnX/9Iavo0svzhXFq1T0oN jhXiApE8hIwI53OQfLRLuI/hGhuADJVCYJYOfWboC2qtfCd0j+o1tnmbNPrTm/GOlF+E rl70h45wdaGgYnsEPsjLigujSVVOxYUAqcJOqydleCPQYalvDbjYuDhJJwIwT3ET+2vR HUgFzfOeJ57p1vG+dNW93iJm4nvHYAkh4Yl0H4jFcxqcxzOwiFP1n9PYUNoQKtZH67lZ RBZMJ40tA3oSi3njG/6a8ZQKGw09pdBN7Ge3Zd14Noqh5LOOkI6VLgQ9ozJtMa1UiZmC Cy6w== X-Forwarded-Encrypted: i=1; AJvYcCWhOLSd9bApUswd4S8Y6PCj+OavAVnYvmHN4Tduga5sDI4PCsf6INYVhwTfSzWKOD2+grbP42e/S2g4/k8=@vger.kernel.org X-Gm-Message-State: AOJu0YyK85heaP6GF9xwkWhBSjqRlyFeZzWi937LamyK92VtfIzvsf0L 3O6Ky+UJGn++347kVDsmZ/6U0DMxVyxNw8+J2BEZ1SC1pKn26nQmQAEuytWO070kuw== X-Gm-Gg: AeBDieuV+8O3sS9b6lNnC9m8kUyPr0tSZuBPZlWfo4HEGTC9MNRIpC7Hj8AwPp0yRH9 bKPimpgQ8B0DTJcjn2TwPvPPBHxce3Qy2659FY//NwgJDMopZVi1wZIiH3KH7zpxqj00TUinClZ EKfwqW3VZGkyiLlhsQKZZEPj0wKU1rVzkuKRIE8JGKftfh37H4d6DG7KiZ65Hq8fh8HXds0lEv1 TqTK78r+xvYfS/B313SjKUneyVIoqFCZjbNDo0tiaTohu+S2CwqQYYdcCkePzGCF/EeVzq8dDQe WwPYpCvEHmJQw21EhZ6bB73EsBRXeblX/oCpJ9kfuZ+Ca6UC8spNI6Qt9HKKwESk3GxDM8M3hJI h2sC7612BiHeA2YayhF/xWJuNd65I7u/06SSKeGL03AVlQDn4/l1t+hWHRJ4ZSjm3jbL9ycxMUp HCVgWXohCwa2saRL6+KqPFTTnyV3EIxnqKOfL1W8pgcj5pbJa6YdFHjaHmF3nblg== X-Received: by 2002:a05:7022:6183:b0:11b:1c7e:27d0 with SMTP id a92af1059eb24-12c34dbeaddmr714661c88.0.1775778082256; Thu, 09 Apr 2026 16:41:22 -0700 (PDT) Received: from localhost ([2a00:79e0:2e7c:8:5d1f:ad34:cf0d:7e41]) by smtp.gmail.com with UTF8SMTPSA id a92af1059eb24-12c345b6208sm1610261c88.8.2026.04.09.16.41.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2026 16:41:21 -0700 (PDT) Date: Thu, 9 Apr 2026 16:41:20 -0700 From: Brian Norris To: Bjorn Helgaas Cc: Bjorn Helgaas , linux-kernel@vger.kernel.org, Lukas Wunner , Manivannan Sadhasivam , linux-pci@vger.kernel.org Subject: Re: [PATCH v2] PCI/portdrv: Allow probing even without child services Message-ID: References: <20260220164046.GA3528004@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Apr 09, 2026 at 04:20:27PM -0700, Brian Norris wrote: > So is pci_set_master() a one-way operation done in child services (never > call pci_clear_master()), and the only clear is via > pcie_portdrv_remove() -> pci_disable_device()? One other thought about this: it's actually a non-trivial question as to whether the port is actually going to use MSI (and therefore, need bus mastering). It depends on the result of pcie_init_service_irqs(), whether we succeed with MSI or INTx. We don't actually attempt to answer that question today. But if we did, we'd have to be scattering that code across all our IRQ-utilizing child services. I wonder if all that churn is worthwhile, when it's a relatively rare/strange case that a port really does *not* want bus mastering enabled. Brian