From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f67.google.com (mail-oo1-f67.google.com [209.85.161.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AB9817A2EA for ; Thu, 9 Apr 2026 20:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775767183; cv=none; b=Ynv3kziwVuCoAdJmV0ncOdp0zXho99ViC8gp+JNl4o0JT+cJFNadWLR9gJQMFDtJ8REkDw9oRO4iKo05SLXVuoX3d+h4wiJaihlW5KAEGAuYfoRZov0gxVqlnRSSHzrOUg/TnNE6Gho5PG11t2C3V2oE4DZd5dcRAzfAAJCtwbs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775767183; c=relaxed/simple; bh=I6om3OEZGkpPFZjSPD54Qu+bAXoJ6oSuuv5lmOezLdY=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ij59ZF3AS/Sg2r/B/CcBkInPQ2/fP8zMKKa3EDU9KBtDGE2aoQDmwAtiq60j0afvL/eUKK7XZFvYt5UJQNZAH7J333cwt2JEmJEgAhbva1dI8hkPupVfjT/i6d4GeSFOkiQooeaN2SfmgqAdaTLoEDdb08T3t7+ir5J8pqb9m9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OV+dpRB0; arc=none smtp.client-ip=209.85.161.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OV+dpRB0" Received: by mail-oo1-f67.google.com with SMTP id 006d021491bc7-68be75dc734so68660eaf.1 for ; Thu, 09 Apr 2026 13:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775767181; x=1776371981; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=3gxGTAqT3EkLbothhbi5OZZyjvwP1p7B/VxIjHUK88A=; b=OV+dpRB0f4cStbE8GVIq9f/bQLbMmvUgGd/puyNisxsbbP6xZiSrhDd10BFEo0ehGp baeCRMv0f6vubqKxURzZZsoPkSQlLn+YrP6kXJkOFFLD9he8kb1hxSNzD3L877H94BaQ 7wl5NKAygIG4Bm73+kY5c+4b1xykLLZYRFi+en96kuf/LlEpZNLiz5/SBT766s3TTzZl ET+gDsqJjfIuw9xNz22TsP0s5eOjpU+MgJ8hZQluEMUJ4FD50XBl6xFQ2XtLIJd8d8Uw XJ/Lka10Bi0+pYIiRl5oxTzkAuIm9/IXbWwhnKtUHTm23ac7rV26jtkR6oaghBAGNQRA wHjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775767181; x=1776371981; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3gxGTAqT3EkLbothhbi5OZZyjvwP1p7B/VxIjHUK88A=; b=InxKFvWevRUeXoS0zaIbR/q1ZidO1iLU9uFXnWGO6F9IYqsj0yXp8V7dI8E7aJeb8c HXJu+DIFfm17FdypddyWFpKW+mGyJFqHmMrcKtJsnok9l6r2crBjF8nZ5bUXy1bosK6l QLSP9cclFJgzdaTGTIi9xE8vNvIfilmEI1dKsiyp5miXkyVTxMJ5tBikXb46w3SgJNp8 FbaeS9biwizUstNCmZaFxkbPCarFRhNRB3VGTBlIun6gqxGW0HSDS3DG+l97tnMXdNv8 cQ5uvs+ZuXsUVm+Spzwju529SqTPp9y/7asrQ/FeXpN7bczglAak9fmQr5eHSm4mmX0H cb+Q== X-Forwarded-Encrypted: i=1; AJvYcCWZ0Vv4gEObPXoZ8tN/0ABaXDXbFYQGf7pdHqbed+/oAEhlNgeBYN8HLbAcchbydiA41AZb/BYCPefQVoY=@vger.kernel.org X-Gm-Message-State: AOJu0YyHcieutaZFeXJY3w84/npy6ecE++xVWzIbjZvESi829vIO3nOp daSYUSuBn0R8doo2BZcqFZdMeskcyQGgduQltP2tEKU1kar7/EfwZMDB X-Gm-Gg: AeBDievhMqIx4wIuuAUoFlDzo7RqCa5AwWlSDV6Dn846EUQbGaSoFArEeInriHq/oga 59o8sA/ptyrBTnRx4rf2pjjFSC1ZhpiHv0pu3kV/TFjG/e5+uein5+HyGbS5ra4wstUZ23UAzlF OMlTmfmIyD6/W5H01cAGWwkeNfWAmvwvWYJSzvZd3U5WgfvK7TQ9F5hekQQN4TEKljUenp0xHhz gusdZMSu5A8rLr+NgyrKf5uhg3fJF8fk15LjoZ+Bbr4dpKFj24zqQoD/TkzLhhyRcm6fv7/flNN 2OiV+RLvg0LNZ78DREGpF6ZwpOeNKxLqZZ87APg+1vA+U1RvTzl3IHhwai2cFgqOdpr6N/T/0ou XTyZlq4etPoWz1UMcgUCYbkR741W/3azEB4k3PVs6QiCxRU9ABD5CkmgVu5CRqw8bmbe8Oz6lTG /7E8MQXUYyWdh9pgG18Q== X-Received: by 2002:a05:6820:1ca0:b0:688:c97d:bfa9 with SMTP id 006d021491bc7-68be5b5ac6emr306577eaf.8.1775767181463; Thu, 09 Apr 2026 13:39:41 -0700 (PDT) Received: from localhost ([2a03:2880:12ff:43::]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-423dd396960sm614963fac.2.2026.04.09.13.39.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 13:39:41 -0700 (PDT) From: Stanislav Fomichev X-Google-Original-From: Stanislav Fomichev Date: Thu, 9 Apr 2026 13:39:40 -0700 To: Andrew Lunn Cc: Stanislav Fomichev , Jakub Kicinski , Hangbin Liu , Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 5/5] ethtool: strset: check nla_len overflow Message-ID: References: <20260408-b4-ynl_ethtool-v2-0-7623a5e8f70b@gmail.com> <20260408-b4-ynl_ethtool-v2-5-7623a5e8f70b@gmail.com> <20260408173943.2c239ae8@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On 04/09, Andrew Lunn wrote: > > I guess... Should we update ethtool.yaml doc to tell the users to prefer > > ioctl over netlink for strset-get and mention this new EMSGSIZE? > > No. The ioctl is deprecated. It can still be used for drivers which > need it, but netlink is the preferred method. I'm with you on deprecating ioctl and pushing for netlink, but I'm not sure how we can recommend this specific api call if it consistently can return EMSGSIZE for some devices? Or am I reading this whole series wrong?