From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30B163A5E94 for ; Fri, 10 Apr 2026 08:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775810189; cv=none; b=Szvm3yRlLedrNXoFuKVuZ7Ev32373TiQsob3Bq4idB+iMC2uoRHD7csrZWH62WQSFNm1wBo547mAd5S4+fnCD79b1RMrZmuOHEEZN+ATShZ2dfocDjMl7/ybOUif7f63tRd9lM+bfNrUl4Oo8l/X+691lmLHstFdyONRbVGkYyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775810189; c=relaxed/simple; bh=AxgP8c47gAUCi2wMx3yIR+EuLZ1MEOnbjNDACsoNfbg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XTVakXIDDq/G8eoYrqYst5aYcEeTrG/9V4RzkEKG3Jer0fsG68sfBDGFSpuUpJlzjlwvn/sOJAY1hwYtZZfOISj4jTJsHzMRSNSkr/cmoruhZV5vLvqx0FAMwUVNz1rDIVEGHWAms5RsnSmMX244Qfr1cJngedOkmLL/uCvWNyg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=H4dMTgia; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=GH2ig9nN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H4dMTgia"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="GH2ig9nN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775810187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AxgP8c47gAUCi2wMx3yIR+EuLZ1MEOnbjNDACsoNfbg=; b=H4dMTgiaaZ/0nGsemDGuSy5/XiJOFnKkFb2ghNoZzaBCF3FjgXI13Kmrv7HQ78hM4zeof9 REsstwXGrY1FFrk364iLdt2UgDCoL+7+EYNg3rogp+pI/DcXXKmZ4/pFwqFb1MPMk93iPl vZhZ5X6kR/Ruc6qDQ7MeWTrHpNq9oOc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-569-hMWx6Gh9NXmpGGczmAC08A-1; Fri, 10 Apr 2026 04:36:26 -0400 X-MC-Unique: hMWx6Gh9NXmpGGczmAC08A-1 X-Mimecast-MFC-AGG-ID: hMWx6Gh9NXmpGGczmAC08A_1775810185 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-488ba2919b9so12847015e9.1 for ; Fri, 10 Apr 2026 01:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775810185; x=1776414985; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AxgP8c47gAUCi2wMx3yIR+EuLZ1MEOnbjNDACsoNfbg=; b=GH2ig9nNf3p8jf3cmd9G4lIeJ6C/YCtrp8KzFbD3roG40QNT4/6FRkcoWsrobxU+hd ZuawADGnaYTCs8CFGQ2KyR+k7QE2PY0bbp4yKah/xIovk2zVntq9C7ufk5xStcQqURum sW7gWCNvv0SFS7oPslt99jo+qdKV3wA3zyx5h9rnH5q1xfhTcyhgFtWcDH1+jlypsfcd 54sjqp3aGECJshnFQpekytYQGx+4L8CeMmd3bWA9jA8Nd6NZ5moigi16kB5gT0fpdMq2 Mv2tmhlsf4xJvA69y5+eY4yG+snpPxz3Usnkv9a+5D8rRBjE4hrhb19xZegGbd9bIaRp pGow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775810185; x=1776414985; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AxgP8c47gAUCi2wMx3yIR+EuLZ1MEOnbjNDACsoNfbg=; b=qYZHwRael3vNwJMHhqjzxremYnPNU2yr2LIk2UxDPcMeok+aci0tm4DCdu312Qy+Oe VsGTIzsOcH+2S5c8SB1On7SqvV7b3ngKkK5TTfRYj6jr3cQxZf46fhaHTxrCCsFtUSbY 70Nk21qyve+mlo1GSdg+dOjsM+sxEFmlXnTGW7cgWTdkn95aF/g8K+FY2ccnpR/7lNR4 p/LJBGQWAF547fBag7TpvYbqS/7GnrXQqP4sbwWmED2+Kij0rAlQci+1RFA8haVKD7w4 PDnT8vs/QeZGT9OoehzJehK5GnpSS2n5x2ky6+1pa6Ly3ia1/kLWnlKu00Kxt5XNTekn cm/w== X-Forwarded-Encrypted: i=1; AJvYcCUoQG8MON9XgfVRYskuhIYyQjiYDrZFORDGjEbxgf3SnUfZsnyJY8eOV9lEtXasaS/RlgLbcZxDJfKt8bA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxe7ToHaHh+ZlXQL44c5rEJimjpGDw+4vMLrqX9vRkW9s07NOti awg3rpbHL9nrfURzNQ81PULFQSocnwfyq8C0SqCOzT3PbUsKK4ljUy2ohkLs9JnR0MiUypRJ08c /n/J1OcMdFW5MBDjR+QtZOIegNGsEX+wiYyDimGMYlVKg4P3e7CzR0kN1ZxJTG88GYA== X-Gm-Gg: AeBDievRuupR+VJ/QDHx79yOE4JSyKEs0Bm3X5PHNk7wgaS5HjCbb9Fz2ubxaranA4+ OM1//GLvANqB6FXUw5Ny+kuKnN1VkUFCRz0XB/UytGswJXoXaWpYEO1+PCEPfUjkTUjGxt9xcSj ryfWO9zMITGCg9WEXXp+SXAcsqXonX2JJoty4q8Ezi+jko07V58L3hahLPsyGaM1JTkBDYi1avJ uC617rFOBGnR0oWo1CRs6xU+19d2JM+DWfBhlsxW2uPDHvqYmw6zxUllDLlmvIrH02gY5e5+eJ2 xPG11/wSd2BYVqzLmUS6MR8F0fmw8rKklNRXe7fybAOfeF3cwm1PUFrYRJF4yLoaFqgAxcHgsq4 Eh+kmoYo/cLjm1JMeGdhedoy62MoQeGC8cbIQTav1jbGF/EwnQzmVNQjSfz1VIJ41LY+/6akZ4Q == X-Received: by 2002:a05:600c:8209:b0:488:9ed3:148f with SMTP id 5b1f17b1804b1-488d684ba0emr25033255e9.21.1775810184722; Fri, 10 Apr 2026 01:36:24 -0700 (PDT) X-Received: by 2002:a05:600c:8209:b0:488:9ed3:148f with SMTP id 5b1f17b1804b1-488d684ba0emr25032745e9.21.1775810184278; Fri, 10 Apr 2026 01:36:24 -0700 (PDT) Received: from sgarzare-redhat (host-79-45-205-236.retail.telecomitalia.it. [79.45.205.236]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d525c931sm56045695e9.0.2026.04.10.01.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 01:36:23 -0700 (PDT) Date: Fri, 10 Apr 2026 10:36:18 +0200 From: Stefano Garzarella To: Norbert Szetei Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 net] vsock: fix buffer size clamping order Message-ID: References: <180118C5-8BCF-4A63-A305-4EE53A34AB9C@doyensec.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <180118C5-8BCF-4A63-A305-4EE53A34AB9C@doyensec.com> On Thu, Apr 09, 2026 at 06:34:12PM +0200, Norbert Szetei wrote: >In vsock_update_buffer_size(), the buffer size was being clamped to the >maximum first, and then to the minimum. If a user sets a minimum buffer >size larger than the maximum, the minimum check overrides the maximum >check, inverting the constraint. > >This breaks the intended socket memory boundaries by allowing the >vsk->buffer_size to grow beyond the configured vsk->buffer_max_size. > >Fix this by checking the minimum first, and then the maximum. This >ensures the buffer size never exceeds the buffer_max_size. > >Fixes: b9f2b0ffde0c ("vsock: handle buffer_size sockopts in the core") >Suggested-by: Stefano Garzarella >Signed-off-by: Norbert Szetei >--- >v3: > - Added Fixes and Suggested-by tags. > > net/vmw_vsock/af_vsock.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Stefano Garzarella