From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A6E72F9C37 for ; Fri, 10 Apr 2026 09:23:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813031; cv=none; b=W/O384eMcsbmt0Sbbm6KbZlcJYXCIiqTXdIgcqlirnMzbO1cq/xGbQo4IAT2qYOkOqQIGfJ7kNsDxqngV4ePi10/b76wZsobVc6L6AvaAE+xRN16FaSVXyVJ1O823isYOptKlv8OPZv4B3+7VhtKvJcPPtuZZewss+Lkr6HEGIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813031; c=relaxed/simple; bh=/MvG26F6r8AdWZ/UPLzCsxRajfilKgPD/xEfQajPc14=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MXJMxm6iANk124eleO/vaFPvyjQVIk1x0LcWQgPMCPiIcQTtJx/mLa1Hl5JfNASrCLB+N/l48xAmnSozk7TDCs2mq0iNUq05jkcRLZLI1OueD7yoSDgfXxZMapcTNFI0E1VBuECGlNmCoSIjRVEExYb24nHr5gjV3vTSKD/nZCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GxUF/3HC; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GxUF/3HC" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso15593645e9.3 for ; Fri, 10 Apr 2026 02:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775813028; x=1776417828; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/MvG26F6r8AdWZ/UPLzCsxRajfilKgPD/xEfQajPc14=; b=GxUF/3HCwU0HMwlU05X6eEwhRY3OvJi/w8TOn/8Fqvey8drPmVLIyg0nn6bg5KF7ij pUL7utyvR6Z+5dpg/7V4fAaW+RF8p6VvLK4hgbRkkU8v+HQQPi0wmqbwPRCvZyVSszz6 L/tNyOj/A926gnm2wBDgx92ZZJSwi8oncoPOGHBXkfddA4x0n5cGwIyJ9h8nJEDR/dtJ pu4Y8WFufQ9bJJvs1b9QSpKNaZHkbDxPUG6C3aQkhZdaGZiLE1uAZM2wJTNZD5U8YJD7 dlC8TXbNasbbdHwCXsW8RSSwWUx9qQwEd6m36SgFdH94ZjizsjcEFqneSQVIqvYxmk8u BvUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775813028; x=1776417828; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/MvG26F6r8AdWZ/UPLzCsxRajfilKgPD/xEfQajPc14=; b=TzQ8mE0CEemC23uaiYRQOTz2K0OzJFSFfxqUR6Ck1v2FzhOdHAd9SB8TgCjqJXu0M1 LMpWl3Sb4JwYjKUfLTftHiarpixURWf7qkvkDjxu/5FkS5P8YCVI2E/CnF8Darn7pl+e dGmUbwxDyhkbRlfX1/nX8qU47M6rK/rJt6Pe4L9lPvQHxPUf00tnY0L7joKBsSgN5yKe OyjzzsyKcdoqNdyIzSpNYdYX2MC0oeWbA0w4eYqkOsynvGsZR2l0tOXsft/i76daBV3A abM9rRvlkO6t8azjXMbaw5zJQ62lRsu539TgDGOu9d7+6mDGdOIIZozFkhlR+qBTGCbJ XOlg== X-Forwarded-Encrypted: i=1; AJvYcCUpwve90W3sDZ4ZSwSOpGcpiYnSlONO1dDE6UyS6pALW9Tz7SAyJCJGeO03KmMnysPfWRReJGfRIZ+cqQs=@vger.kernel.org X-Gm-Message-State: AOJu0YyHsitvyR9TVHm7/9aWVb+NPIdZMREda7XkDR1+1gJE2KVKkGyJ T13OMnMqlJjSzrNKm3a5NMspV29YbaMdQYOGwruo+sifuXLl4RuW3wWi X-Gm-Gg: AeBDieuF6Ne6iFUUSXHU3QSpSQ2Kyl0HHICXtoPuYqUiuabp3eVzYKycvrLMVPgzkfT v+YJqFl4vIOFJBuOwTDQF+p1ZkWYvk6wz9kaVX8qXnaLVk8tS3tDid7ZNuLxIFNoCzHiBLQlxLn EwF7kEuEqBzh72831SAAt89sRyVY+/ZwpXIq9CG7uYoB51Xn32Afp1DXg02FULPQqaJYKewb7Do AoVZBlmBMTMwH/Y6Nwhs10fQ4SfEMAGmb7Ya4K0wZ30HJfJSK/0y/rpywxdLlyFBHmTB103mLSR +XCIlpniuZoIhkI7s6tGX1sYfxE25/DDu2vD7lP290GM91WHF41Y7jflDqPq3p7Vht3ZAmPIN3T xEcBmgrJ+G0czHJC4JTLquBO3nTVAPpqcg0Z06+usDieI8nBSaRf6O84k9yuVlOzmJpiT4zrNVb 855gesY0cen7dGVMyhoGps4QGuXzlM1w== X-Received: by 2002:a05:600c:c088:b0:486:fa35:aef2 with SMTP id 5b1f17b1804b1-488d67bf744mr20047265e9.4.1775813028369; Fri, 10 Apr 2026 02:23:48 -0700 (PDT) Received: from gmail.com ([2a00:f41:1c39:1fd5:2a0c:50ff:fe2f:36f4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d592db30sm52202595e9.10.2026.04.10.02.23.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 02:23:47 -0700 (PDT) Date: Fri, 10 Apr 2026 11:23:45 +0200 From: "Jose A. Perez de Azpillaga" To: Mohamed El Harake Cc: hansg@kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, andy@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] media: atomisp: avoid ACPI package count underflow in gmin_cfg_get_dsm Message-ID: References: <20260409214158.3248-1-mohamedharake2006@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260409214158.3248-1-mohamedharake2006@gmail.com> On Fri, Apr 10, 2026 at 12:41:58AM +0300, Mohamed El Harake wrote: > From: Mohamad El Harake > > gmin_cfg_get_dsm() iterates over ACPI _DSM package elements as > key/value pairs using obj->package.count - 1 as the loop bound. > > If package.count is 0, the subtraction underflows and may lead > to out-of-bounds access. > > Use i + 1 < obj->package.count instead. how was this bug tested? and is there any way to reproduce this? -- regards, jose a. p-a