From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0534D37C0F2 for ; Fri, 10 Apr 2026 10:12:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775815940; cv=none; b=Akd/5M8cBRT4IgoJ54bwfTWoRLvc6ZsZrrTscOMwR1RsRpy+zNLQ2tIGV23Gx3n4pk4mMi+GcZ9mglT87IZWAYFnIPwvWnxNR6BFXeXxW3pr/GTrmi1I9cfRY8XeW9YIneHIQ34LKsiDzhIV7UUhcW0t/V2Vd3WXyxWUBqSDie0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775815940; c=relaxed/simple; bh=H0fXTkWi3cEW1grzTO2UpwdTEZU5njLYXMU7g8OxhcQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=N9bov8Pmzx8wb6aSPu1EUFKIh0RnCxTHEaF3CPWeOVEIcVaObZ77OJhqhvdyya95UOWWXSvfIcwQcKaKGYO4RSB7SF8rhIaDBm80UpoN2ASudmF8345IQ/nGQxYL+JHTKPxrzE5nCbyjLxN4gXxuwzMJylv5yQ0Mv7PQH6n/XJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gGEwk05u; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gGEwk05u" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488a041eae5so13102585e9.1 for ; Fri, 10 Apr 2026 03:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775815937; x=1776420737; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=2joo26VZqK/l7L0t7ywj7SByOmdQBrAhyw+E9lx2JP0=; b=gGEwk05u65i7OyrFU09sm3cibL2EYJ3yVES5ZR4aCtwm+o5T5hvE1D/aFwqvuDvoto 6x4+Q6rCSxgCNbNIxyyeON19h0981U1gOM7HMkqSpIANW9XKHNFLUgvsz1/mu/65+N6M SyiIjbVLPi2FJyfxp7M5tv5qnLXcQHvCiIFCdrIUcmM1+v+l1QsobnglzCazgoUqIRZ5 sPm6/x5vQ/wFZB/ub8OAPxIm9D262LqIplHmSIw2bMLDfAYzx+Eah9zAcRFGh1JU68xi Dpr4GiuPbeSYD+S5S5MKr+OvZN0mdqIl2qC+sAbeBJdf2MAtLx5P/QI05FylJN6Z1xcw AxnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775815937; x=1776420737; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2joo26VZqK/l7L0t7ywj7SByOmdQBrAhyw+E9lx2JP0=; b=dZRKsR+ZgQUtM6ja2kOYiMtRNtlBOZ2jmWZgp0SALoMPNrf0SYvR7LS7u7/ddMQe9b xs+H9Fv3k9xxYCoY62CA3eIKo/UdWY+jv5J4dkhN14CClO85xHAi8mkEn4zuvOHfpKHF MkzGgL2JVkiaB1zj2IqPP3auChbCPfyv3+QLxkVWLJQAjU0lus/RARlo1a97lcfLu4Pf GKMXNcKziJ0P3CYDbg5oCU5jM3xk7sHSwu3EaZEl51LpiywtDo2hSCOkzQRkxvlAvnoi JHjfJiOoa51iiUePwz0Xa7c67H7+PlnP1ydaomXfscH5FrKYI0PUasTCcxjm/rl9yptk mtXQ== X-Forwarded-Encrypted: i=1; AJvYcCUS/8KQElmrHIrRdE+0vIFO3iW7yRHFJnrvXKzzkBxZYbv2PXGXUI3PUnHPmaVw1fdmcMDpjtl+HEA07eY=@vger.kernel.org X-Gm-Message-State: AOJu0YwKVzVCgk84PtEW1PEqkCmABNp3PzGKzyGLyBJXoqbNhwx4ISc3 Hoam16P4J05JKPs25W5JmVYM574Q2V8XZiotU9cQhGhi2dDAadcB+N0q X-Gm-Gg: AeBDieuUviCyWuU1wBx/xkiibmNoe9OMtS6jMnhU3XSKt+JBSs51kcsYtiDMLqQQ5n5 M+wuYa6PF6GRgOk3X5oicfAudTEx3RenfUM/VVBHchUWyMlx2eKKl2DF3f3gNMrkvNMp8GY4fUL 8y2gMZGiJFa5d5kO1gQNHtpe3DF+ENKWgcAHAKpKDJM7eXTJBC8C13dsX7/9imolTxdxGAdOY65 a8LBWwE78vIvSnDrTN8iiLOrYYikqrfheDHn8ITtPS3kipNOIdUtXdxEhznwwSj2B1kIJMnPvuI h64p+OtoMNtkpn9DOD2/Ic2vJw7P0iAXwn9dQquJAaMNYN93KUlbQCktmutY8T6qIVqv3UGkiQY DO9kGzuOmM73A/KIAz7iFNMF1vm6YVDTxRtG0i7ZtB3GnGIK+z9IUCopDaUofCrY0MZ8vpYHAix IinsOLorL24zCuqZvxgr0= X-Received: by 2002:a05:600c:a109:b0:488:b239:77ec with SMTP id 5b1f17b1804b1-488d683d510mr22075085e9.17.1775815937325; Fri, 10 Apr 2026 03:12:17 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d5b3cbb2sm63943005e9.13.2026.04.10.03.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 03:12:16 -0700 (PDT) Date: Fri, 10 Apr 2026 13:12:13 +0300 From: Dan Carpenter To: Jishnu Prakash Cc: Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Dan Carpenter , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] iio: adc: qcom-spmi-adc5-gen3: Fix off by one in adc5_gen3_get_fw_channel_data() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding The > in "if (chan > ADC5_MAX_CHANNEL)" should be >= to prevent an out of bound read of the adc->data->adc_chans[] array. Fixes: baff45179e90 ("iio: adc: Add support for QCOM PMIC5 Gen3 ADC") Signed-off-by: Dan Carpenter --- This email is a free service from the Smatch-CI project [smatch.sf.net]. drivers/iio/adc/qcom-spmi-adc5-gen3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/qcom-spmi-adc5-gen3.c b/drivers/iio/adc/qcom-spmi-adc5-gen3.c index f8168a14b907..48c793b18d11 100644 --- a/drivers/iio/adc/qcom-spmi-adc5-gen3.c +++ b/drivers/iio/adc/qcom-spmi-adc5-gen3.c @@ -482,7 +482,7 @@ static int adc5_gen3_get_fw_channel_data(struct adc5_chip *adc, sid = FIELD_GET(ADC5_GEN3_VIRTUAL_SID_MASK, chan); chan = FIELD_GET(ADC5_GEN3_CHANNEL_MASK, chan); - if (chan > ADC5_MAX_CHANNEL) + if (chan >= ADC5_MAX_CHANNEL) return dev_err_probe(dev, -EINVAL, "%s invalid channel number %d\n", name, chan); -- 2.53.0