From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33EE33815F7 for ; Fri, 10 Apr 2026 10:14:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775816099; cv=none; b=YI4ub9QcvP1oay5HKNVlTqE2caeS1pLn33EKypxDdcl1a6+TiU6IMhbW4bV0FYz0bMCXJkOBIR2hlVkPuNYhTxqLDmygUPHHylXkff+tvSkt5Zyde51QnLjpjUzr3Lk9ENqto1XkXdNAu7TU4jxFMKylugwOGCtWME/T6IgJTgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775816099; c=relaxed/simple; bh=IihIOiUIq6J3kKC+sZ83vzkP5vrokwK8p+1gz1V/X9A=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=dnwgF3zpWGTCndDC60jfM+zYP1P7yt588+aGuoSZNdXHg+bnF8D62k/adf8iDYBMWGE4Tw5YdcCYYkD/hrSBNdIWyCVm58qNoSNHrOs1G5o04BgNh7zXIKExbZiDfohmVZJMnIY4/mIe1YVbxRjmusbn979GrZmxyq9pfNgog2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kdlzHwlN; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kdlzHwlN" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-43cf8d550bdso1826404f8f.0 for ; Fri, 10 Apr 2026 03:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775816097; x=1776420897; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ucUH4IDgpTJ1+uFHppA4Ul5fmREvzaKgT+OImbEPYwU=; b=kdlzHwlN+RxT5pculOX+gIL1NH1fNU4R1v4Ji1TurIHy2F0SLv9UgvHIuOYaA/7P5d 9Ft+s4Uo/yQ4xdS3sWF9g4wYFwzYhd6PVExWVAxPxHbYURJy2W+woLmmEiDrE1NftgDq WInj5+5cEpxcr8YMBkFMbzidfDMqafhm1Nk1ayfg0XtXlLao6r9mm1eKdAUG7oFxRQ1N 8S+nuNlc29FCu6oPsBI8cbmwj8ko9EC2Ax/ARA3a/JD08NMNZXFuEYHADutouSf3fHBS We3T0KmBdaPIDK74gydRiobQhlRp7p3Eg6A4lYccxP20xJT2Ftv7fRQW8gLwimzG7TrE xf9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775816097; x=1776420897; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ucUH4IDgpTJ1+uFHppA4Ul5fmREvzaKgT+OImbEPYwU=; b=KCeHK7MaCsChnRQInzJ+Dp9I2V9cgM0dsOLT0gQ5FL1DS2EyjPXdKx8UtfSItao1e8 +m23tbgfxdzFjQv+gsz2SApfPnnL2rIg14OIC5mXWQ1tX95/VKopgjLyvMAgoBSSHpWh 65YhWaTBpj7N4S3RnA8OZaz6q+B6Loxw9WkpWkrU1qeu24JzEqbuPzYQ9ePYzcNUXNfu EKPLut1B5kswBFYMnPxRaaNT/xBwVV+89MTsyw7mgZCfcAsvpa+GTmn9djFStlliENg+ 720lDSx5Usj5ct970ys8gLBhkVct9++dEOpT13IgK/OZGFeGX2v7znQMlOITroPIfQl0 O0rQ== X-Forwarded-Encrypted: i=1; AJvYcCUXK7uho6mglX7U7QyS6DTmkGQaCeIKZm0iFamaG+0LzUAHOvHIvk9gnoojddDC7bCQuQwywntCFZLBSnw=@vger.kernel.org X-Gm-Message-State: AOJu0YybsssAqpbueKt0e5p5NkcayGQKnbRiuB0UMgpVhx97L62nK2UD t6Uyj+4wRRuGMjvob/cNUIrtuoBCpuUbGzGgsVp8wioMFCsPou4tIGnQ X-Gm-Gg: AeBDietpP2TOCs+NAqdVtAA3d82ZvzTnpI0vuC4lcrK9mkEO6O7EQqeOi/S0vjNxDlk X5ZalKp60TCt5CMg20t8naUfErWjd7Vt+Af2wBSEfhkOloN/q+Z4nnS0E0BNHEmiw1RqWgp0zoz Z0eAgWQ087m5MDcB4pILN+quhVjLZf8DVgAs/KTMijIe2Wvhcd2XdsVfC0FLr/AboZCR10/VaWX 7jzIW/03FuCPQl4klFPILzywN/GCtZ3jpLhtWjtwvCjYbUTUzEoa1ymxpJtErCgGy98RaGlgGA3 6y9rsXC+/B1bg+/Fsmj0TKAX2Khxej2h9Jn3qPULFCVUDCd3Sx6zh0xgZtnkianx3TdQ32vfPyf E+8uz3WH2f5nxAMo54gDvvHim3eMpYSS8SyCTx8NRnD9RiQKLZ2vvtmR9SOuUKAn6RBUJYMnOq9 GuNIqTegnnyXJl0CipM20= X-Received: by 2002:a05:600c:c0c8:b0:488:8bdd:cfb9 with SMTP id 5b1f17b1804b1-488d67bbbf8mr22272095e9.1.1775816096505; Fri, 10 Apr 2026 03:14:56 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63deb904sm6833358f8f.9.2026.04.10.03.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 03:14:55 -0700 (PDT) Date: Fri, 10 Apr 2026 13:14:52 +0300 From: Dan Carpenter To: Yang Xiuwei Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe , Bart Van Assche , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] scsi: bsg: fix buffer overflow in scsi_bsg_uring_cmd() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding The bounds checking in scsi_bsg_uring_cmd() does not work because cmd->request_len is a u32 and scmd->cmd_len is a u16. We check that scmd->cmd_len is valid but if the cmd->request_len is more than USHRT_MAX it would still lead to a buffer overflow when we do the copy_from_user(). Fixes: 7b6d3255e7f8 ("scsi: bsg: add io_uring passthrough handler") Signed-off-by: Dan Carpenter --- This email is a free service from the Smatch-CI project [smatch.sf.net]. drivers/scsi/scsi_bsg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_bsg.c b/drivers/scsi/scsi_bsg.c index c3ce497a3b94..e80dec53174e 100644 --- a/drivers/scsi/scsi_bsg.c +++ b/drivers/scsi/scsi_bsg.c @@ -137,11 +137,11 @@ static int scsi_bsg_uring_cmd(struct request_queue *q, struct io_uring_cmd *iouc return PTR_ERR(req); scmd = blk_mq_rq_to_pdu(req); - scmd->cmd_len = cmd->request_len; - if (scmd->cmd_len > sizeof(scmd->cmnd)) { + if (cmd->request_len > sizeof(scmd->cmnd)) { ret = -EINVAL; goto out_free_req; } + scmd->cmd_len = cmd->request_len; scmd->allowed = SG_DEFAULT_RETRIES; if (copy_from_user(scmd->cmnd, uptr64(cmd->request), cmd->request_len)) { -- 2.53.0