[PATCH v2] staging: rtl8723bs: fix comparison to false

[PATCH v2] staging: rtl8723bs: fix comparison to false

[Akhil Boyapati]

Replace '== false' with '!' operator for boolean test
to adhere to Linux kernel coding style.

Reported by checkpatch:
CHECK: Using comparison to false is error prone

Signed-off-by: Akhil Boyapati <boyakhil978@gmail.com>
--- 
 drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 864cd8b6d1f1..8f18175175ee 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -1013,10 +1013,10 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 		rtw_ht_use_default_setting(padapter);
 
-		if (pmlmepriv->htpriv.sgi_20m == false)
+		if (!pmlmepriv->htpriv.sgi_20m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_20));
 
-		if (pmlmepriv->htpriv.sgi_40m == false)
+		if (!pmlmepriv->htpriv.sgi_40m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_40));
 
 		if (!TEST_FLAG(pmlmepriv->htpriv.ldpc_cap, LDPC_HT_ENABLE_RX))
-- 
2.53.0

Re: [PATCH v2] staging: rtl8723bs: fix comparison to false

[Luka Gejak]

Hi Akhil,
I am sorry to inform you, but upon checking, I have discovered that 
your change was introduced in one patch in the past. You have probably
been working on master branch(one from Linus) and not staging-next. 
Therefore, since patch wasn't merged to mainline yet, you didn't see 
that your change is already present.
Best regards,
Luka Gejak

Re: [PATCH v2] staging: rtl8723bs: fix comparison to false

[Akhil]

On Fri, Apr 10, 2026 at 08:45:13AM +0200, Luka Gejak wrote:
> Hi Akhil,
> I am sorry to inform you, but upon checking, I have discovered that 
> your change was introduced in one patch in the past. You have probably
> been working on master branch(one from Linus) and not staging-next. 
> Therefore, since patch wasn't merged to mainline yet, you didn't see 
> that your change is already present.
> Best regards,
> Luka Gejak
Hello Luka,
Thanks for letting me know, I really appreciate it. I just switched to
the staging-next branch.
Best Regards,
Akhil

Re: [PATCH v2] staging: rtl8723bs: fix comparison to false

[Luka Gejak]

On April 10, 2026 5:15:13 PM GMT+02:00, Akhil <boyakhil978@gmail.com> wrote:
>On Fri, Apr 10, 2026 at 08:45:13AM +0200, Luka Gejak wrote:
>> Hi Akhil,
>> I am sorry to inform you, but upon checking, I have discovered that 
>> your change was introduced in one patch in the past. You have probably
>> been working on master branch(one from Linus) and not staging-next. 
>> Therefore, since patch wasn't merged to mainline yet, you didn't see 
>> that your change is already present.
>> Best regards,
>> Luka Gejak
>Hello Luka,
>Thanks for letting me know, I really appreciate it. I just switched to
>the staging-next branch.
>Best Regards,
>Akhil

No problem, if you need anything else let me know and feel free to cc 
me for any further patches.
Best regards,
Luka Gejak