From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FBF12DE6F8 for ; Sat, 11 Apr 2026 08:07:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775894858; cv=none; b=QyoW+prnTeTXv8iMt2aOmeNqkwDPTgmgeT7m5XSQyeqAtQb77INX/3Od4c6ZcexRWcB7YHcjv/u7vc3O7ZzPI7+YtzD/hCeL1/rp8S0iBMvRD4XYr0Gl+1UWhP5itqZ7WCXJQ7HVEZNHV/KXocmYxJ5kc/Oe3AlmltouBBQEX8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775894858; c=relaxed/simple; bh=jTXH3qJNHehIy+z8HxDAKrnbSnBKJDeZ+LdTRhVvCyo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MIjQL52WA7n8cLprJ04rhCYIPjHmUpmlidKJRgcgk3mHuW0rTI6Xp0GmbCBo/Jbrw2pqOgPwDy4o7xR3AyI3L7uArQmLAqK+SlGnuWIJK0xwFY8wrjkqHerngnfnl0o6Hs//V0Ar9LfrF7Spie0AUADilFyV9EFZj2ehMQUzgvc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ghxnh9Aa; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ghxnh9Aa" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43d03db7f87so1766574f8f.3 for ; Sat, 11 Apr 2026 01:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775894856; x=1776499656; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j54PpEAKN+VAsZTNtYfE2e2QQFNE5h8+vlAzogm3DEU=; b=Ghxnh9AaisnSaE89mf/1mgJ7vj1+8v+YV3tPyyVh4OIZievoO9fSTATl7QZxciGgK4 G2XdI01XqD2uzSo2qsexmlBhrr71leAtf/P/xvLKOlDUsaj4dtG/8eA/8lu3qOi7lk1E 3jvNA62ugjLfuYSWbUl3eunhr46znawHfRYTxx73gIIBzA//8QEW7AzZ51zPqQxikRJS O+VWqEjhggJ1IUWTCWsyek9efjTIIUZR/j7s03H5JBqJtvwptv5kcIltb7KCk8YjV1iA P9gWreHqyqpqf5MoJA6U51nv2YXIAIu4z5frsM9eFLkmwzlIjG2IeLdaoeKFjWOL6xmy JDag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775894856; x=1776499656; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j54PpEAKN+VAsZTNtYfE2e2QQFNE5h8+vlAzogm3DEU=; b=Eoxs1x30UYsOuCKi3RGU6o7UbEze7KILT+F8qbP6PhmDTM7QX6c24wgKXj2FFL9FtA FfezydoMhYPE0SKzBQSLwQ0UrKhrYLVBU3WRoUENfQyl2beRp04/VWzsH3LkXHJkEJKC 8jB7HeBVRULlx8frpZUkINSQ4T3Oa6tyq/oDQ27LFPHznj/6UCnDVRnH8QaiIS5LMG6d /9zrb7E1fE3chiENEfP14vOKswyUf5P8oa3ok29GPEiZnYzlFoForAjbr8rlSgHz8M+M y8gLcjybk3lmtSYoDY97nZ1KOoKDH47VZZkjAB9lgvrm07CSuND36KL6wy7im1dpgkcf c7Ig== X-Forwarded-Encrypted: i=1; AJvYcCV87Mdwg4V5UNxNeuQZMheR7DA0tOxtox2pYvuY2T0plhb+eunZ8D3A/nedNg8AJrLzYJdHJTq7EbGjOSE=@vger.kernel.org X-Gm-Message-State: AOJu0YxTpODrz9uZuH0w99UoU319ugOhIpnWv48dsCmEdDOgbgatuiuR E+9KIfyM5zJg+zN+dDwv9ilSBzw38bOSSS93tG5ABWMgl6FpUKkaniXR1myCzOzU X-Gm-Gg: AeBDievOBloT75sY9pLH/RxpX/fEq5na4Ii5CRuAZb4hFlZGRWlJmpFOjUkYtFeXMKq AYAqjKdAJTuWQj+LcPs2oPL/Et6R3sSbx1oO7XKskCqWNqOG+2g0AGT3MNV6mN2sjRuT6qhtw0N DXwdGvu5ScknKdfaP7dWkzkzEdEmX5zYFJ9GUSeQj6Zajdl4SzD7VH7XCHKjVWHHYURsJhsgodo 77zR0wcOCDvcjoZXcDpH01NhCidwKDKnCQlNupsP5vweIVP1KtarPIpJa5ZGAIKojvxLPgCjWh2 XYbl9qiXDPq7g835T0vueLnEwoeoRYS/Z2Hdu3fdFoqsBNWfwIVcIKn/eA2764s6Sk9J8iqjOz+ HlD7wQ7OT6pcjJV5ZtyNGGnTuh6UOmI4zWF64JqbqqsLnQ57BGIK2FhZR53HLAp0+tbKiD+h4Cc Sp+5haNU8OYF0hhpvkj1M= X-Received: by 2002:a5d:5f53:0:b0:43d:5833:fdc5 with SMTP id ffacd0b85a97d-43d642b6b90mr9902538f8f.25.1775894855766; Sat, 11 Apr 2026 01:07:35 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e468c5sm14810726f8f.20.2026.04.11.01.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 01:07:34 -0700 (PDT) Date: Sat, 11 Apr 2026 11:07:31 +0300 From: Dan Carpenter To: Adith-Joshua Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, straube.linux@gmail.com Subject: Re: [PATCH] staging: rtl8723bs: replace magic numbers with named constants Message-ID: References: <20260411052817.354594-1-adithalex29@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260411052817.354594-1-adithalex29@gmail.com> On Sat, Apr 11, 2026 at 10:58:17AM +0530, Adith-Joshua wrote: > Replace hardcoded magic numbers in rtl8723b_InitBeaconParameters() > with descriptive macros to improve readability and maintainability. > > No functional changes. > > Signed-off-by: Adith-Joshua > --- Where did you find these numbers? Presumably there is a spec somewhere? What does BCNTCFG_CW mean? This really looks like an AI patch... regards, dan carpenter