From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f176.google.com (mail-dy1-f176.google.com [74.125.82.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 209E733A715 for ; Sat, 11 Apr 2026 10:38:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775903913; cv=none; b=AIqfjmJuaY0N4iUomb5ZggDiKVnCkqErAudgOzFcEAsTwWw6+IB7BdAnAaMLFf0BJrpS3qQL2hD/6qm0oVmcd6Ek6uByNEezyMf4tnmHgcl8dDR8KlMX9ioJiWTePpsxu+Vxixq+DPf5aEAXVst8hYgv7VpjKZER1WXaUmdZIMY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775903913; c=relaxed/simple; bh=1ssmPN6eaWpsHEUpRPyPqbNx0hAfCC6bne2u4F647W0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F2neXoFc8PC1hK8x9hPLvmFOHBUYhH8yVf42oYEAOgTIW/OsyKZ+7Ia+ltsEPW+JFVvuNtN+rCD9PEg//JTXs+yd6Iv4pLH+rgDYOfsdQriEiUiUuK8p/hvJCZfr+k80ju4K92uGmeQfJTvpx/iS5iCwJhDROeJbuB1LgKjzhtQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zc5JTcIp; arc=none smtp.client-ip=74.125.82.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zc5JTcIp" Received: by mail-dy1-f176.google.com with SMTP id 5a478bee46e88-2bdd40d3c61so2498152eec.1 for ; Sat, 11 Apr 2026 03:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775903911; x=1776508711; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=m48yn0WPV4oaRj5jTwnjFikJvqvV0KXxEX/oKLKRTpY=; b=Zc5JTcIpYJirx+1Z+Z0CvkDVCpIbQS3C/YpU6oRin2gMOQwl2VijKLIWJCp599N7Su Hx/SimGNWOffVjbCeGGhVQPNBNeDTlBcaheGe91KaGGaoRZAg7XIFx1M7gluoRgRxGg1 qAnbIjfYUYmIbLB1gwK7VqO1iGK77ylaU5EYVnRYAVl38JVKpgXhlDUkVf40Fg4B77Gt kgTF94vqw1XR82a7Blixrkd7ZUrj3VTaL+MMHlHXF0zEz00ecb1pWsgELIjczMbHDmvB cRtyCXNP5WahH68mtGytuTKUKjUlUfk/8iJfL7qcy5BFJuCQaUP/5F4TEOjenKSbu5Zo 0i3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775903911; x=1776508711; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m48yn0WPV4oaRj5jTwnjFikJvqvV0KXxEX/oKLKRTpY=; b=R+fbBUN+dxxHYs2eto1GxIV8AE07MLmHgxwy4mkzXNWR4CwOHZYYazbUkvclAkL/LW I1qTpL2yNor+Wz5F4jChT33cFadS5n9ne356YAj/QwJMe+ms2trwEVML0KiiLA2pAsbV i1Qaf4yByU84vaSR1xvgcYyqwQuYKbrTXKaL1mUHEKKKGQNWDOu72QARfTbGtEb47AR4 qZ53QG2w5v2micgaIm//lnpwpKrXI9pzMn0bLSR0K/uvdfPtDUkWWcd681cDa0MukWaO jNvBG0ehKCB5Au4MwZMecN/57nemgsBsFaouBRKektv2KaK34r8pbK/kyZGw+suw2l9t 68aA== X-Forwarded-Encrypted: i=1; AJvYcCVh28rmLLXz/znf0sNhsCSeiukFOJEhzBVic3YkXLrJI8DtlxOHb4HQFCda3hVbbbpZ3bBqRfhcpJq2c0c=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1zE4TkfUha06AVxWO8hr/AVsYkG/S4MSFkaoO8/WP3tXGotJM 9L6P1QzjuA6qe0gY5h+RJxD8IUA2K6QnaTP6heU5mz+xxz8zS4Yvuj3e X-Gm-Gg: AeBDievynUHjVK/duM9R6T9LBXO9NEwleSQC7OMYf0IMg2XcfWVv0vb3S47Mv26AAsU lBGrvf0rrJDLuulJALmlVPPL+AyervzQ9nDgzDpwlhRIzItW+/QbCiqvhEquCvcG8DlYf3JbGws /UU6yegxCgvn74UGAzKyBu5uHfAUUP9T///4+OouTu18f7+25sF73nSfeC44wMZKYBgTgtJ9qpF SQjwAdZ/w1Na65Ive4YypQAIIQV6IkaYsSWNruoo+ZbBXEptcHk7ldT/1Ba+5/c/Y7RKgQ4nVia Vsl5g48T18/HCHPu9cEnFsgyYe2FEzHYfadijlfUFLgYKKJMaBIlXDsfpRDFTRT1JB1RfSCxVyT po6O7ybUZ9SHVgmhfTVJDFvFbjbCwa/jwGnqllng0PeeJu9t/jYsb0cKPcU8NpERV4KpTGEPqNL u8DOwqXoeNS9Bqw5s= X-Received: by 2002:a05:7300:7495:b0:2c8:8ae4:962a with SMTP id 5a478bee46e88-2d5870ac142mr3775954eec.2.1775903911142; Sat, 11 Apr 2026 03:38:31 -0700 (PDT) Received: from localhost ([45.86.211.12]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2d5632a64easm9136444eec.31.2026.04.11.03.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 03:38:30 -0700 (PDT) Date: Sat, 11 Apr 2026 13:38:24 +0300 From: Dan Carpenter To: Joshua Crofts Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v2 2/2] iio: frequency: ad9832: simplify bitwise math Message-ID: References: <20260411085848.75381-1-joshua.crofts1@gmail.com> <20260411085848.75381-3-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260411085848.75381-3-joshua.crofts1@gmail.com> On Sat, Apr 11, 2026 at 10:58:48AM +0200, Joshua Crofts wrote: > Refactor the ad9832_calc_freqreg by adding a BIT_ULL() > macro instead of manual bit shifting for better > readability. > > Signed-off-by: Joshua Crofts > --- > v2: > - changed ull to u64 type > > drivers/staging/iio/frequency/ad9832.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c > index 8873a6d11e..4221e51dc4 100644 > --- a/drivers/staging/iio/frequency/ad9832.c > +++ b/drivers/staging/iio/frequency/ad9832.c > @@ -112,8 +112,8 @@ struct ad9832_state { > > static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout) > { > - unsigned long long freqreg = (u64)fout * > - (u64)((u64)1L << AD9832_FREQ_BITS); > + u64 freqreg = (u64)fout * BIT_ULL(AD9832_FREQ_BITS)i; ^ This extra i char is something I really dread as a vim user. :P regards, dan carpenter