From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6055633F8B7 for ; Sat, 11 Apr 2026 10:52:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775904776; cv=none; b=ROBWENA6R1OzK9bWo3vUiiIHYCXmrXcaXVEg+tr9uRLqxtUApMs6WCec9h8Cg7oZVqGEh6aaNADAORFtjYyRY97NxO6x6Sw12kA1MyMpliLAIM2eJR0d1yA7X6Tz8HGzs3V+zwO4NhcjgTyu5RG0YiNJdxlGCgKFNCLYygE+m6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775904776; c=relaxed/simple; bh=A47CdT8W/ldJU9+4ePsSUJA97lg43ee4+6ibcowyido=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rfVQYP0LLcsiQd01IXwmCKpgs0Aiaj4T46Z74jbZDlaWsTdUO5Y+Tl6Ytrbreef9KrF/gm0maiNqe6a/LM2DYJXOCQvhsRxbvfz3y18sgwRXlDWVqMFKX7Dq5OF2HkzYMWe5a4RxPv5vxHlV79MfHXkCkHFmKnDoYRL5McdE6ZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GJooQ05L; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GJooQ05L" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2d7bdb5ffffso177261eec.1 for ; Sat, 11 Apr 2026 03:52:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775904775; x=1776509575; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/greMxALxVYb9nwCKqf7fyFdZbMiPxwcLxeI6dJ8WwM=; b=GJooQ05LDaE+O2jp52uZT/uh2qI4qw+Agvnh7gaPOtKz+wdY/XtvyAaxkFtGBs/rsQ +uFKVwbYp8eFgDWmBCy7YbOaAelsLWbOE6dIJVzIPfyjFgfEtrQUHNwxVl7cM4BQPsqB nPcCixFKHIV1sKOLeUpJFvTbK+XhQBEh4kuy+Z0Nhl9thNNSDfcP6tzL13RlhNrMpXZd yFERM1gbd6rG08NNqNvz7XcGC7J5P6R1tMmJuBzPbgAuZLpgEGSuqy6lZZEXjXXVIHcQ 8myT0/MAYx1l0f/uBmTXfY5lrOo/H3usv4LGl1dztwwSbHn2JzRHZBTPoOvLxs/G9MGM vaIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775904775; x=1776509575; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/greMxALxVYb9nwCKqf7fyFdZbMiPxwcLxeI6dJ8WwM=; b=kDa5v2C/AgjLLYuj8CknnABlfgDnmZkoBAMZaViUtCFqq/9Dj0I+XZfnUsIYn2ypBm PWnXUFcedxgMMxuy17ywGCDEodjjP6V59P0XVeHbB0UNlfAxnW5CQcnVDR/oUmcwJd3i 8LA8cLtaF+mOOfMbstJyh84D7Go9few+gtBVa3liKQdslT4o5pNrXJYZHHRjCeQxYC54 ig9rWlJuqlrJqTgirykHoo7jgaz1asGkucjIqhM5vBp8HuPcZSlmWdB2U5ZbzGlA6KjQ r9CxL0otGrJl0qpqgAe2b2ph2xVaH7zZogHRF9GWCzx00DgOVnXJKdg05jjF3i71SUf/ lSEg== X-Forwarded-Encrypted: i=1; AJvYcCUN/HxoDVQnsKauDNy6n230EZAxgaew7qXjIs+DsQUNK9S55kClx37Rhd5YdIpI0qYfWCDdTuPMNvtHUKk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9kGuDy6MzHKBLiG4MbwI+fbUIj6EHD5WX6jm5Rn0epf6ec1pW /5cgkOj+1pWiPE6ADB5rJNNX8tWFDC9IOrk1DhD50oh8dy2ar82HD110 X-Gm-Gg: AeBDieuKVfNVrRWs69/6qFvYEsrkzNCgyXobxngMdDmIfGgtyt5yJxUw8O49FvrZY7D UUa8jw9+wMAdflW31f+1KgwDFvEGZABgIv3Om/jv56u3CYJK/6kCNWzu1YZtiTxo4GrGlcPDjWz olHIDBV9LC/hh+MTYNe+BBkQx+X2T1awa9Z7NyzkUaTyYLBItKEmeYzQqqrdC7xT34R75OJZyYv yM4PkLB9I9znSoAAENFunEkwYif5tsK8XPANMp+4pfAILiPoWy4uRAX8XvwNohOgWKzxuR2SclI cBCrjmtDojo8cNvjIZGNCww6VFFiw0lYJvv784DBIkS+0+0OBID0ZQuuPQkzh9TiASbvWDMcgg8 8dkJ+kXPAkm5tfiNKnUeO1nRQqZHy93M5HmB3WrRjLSW7ZmUg0tNx+XOCcXujPCqWXji+cR1dkO cEAS2rf8UxgIgQpDk= X-Received: by 2002:a05:7301:608a:b0:2d1:d434:d001 with SMTP id 5a478bee46e88-2d58965f555mr3946040eec.17.1775904774543; Sat, 11 Apr 2026 03:52:54 -0700 (PDT) Received: from localhost ([45.86.211.12]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2d5627c44fcsm8496011eec.23.2026.04.11.03.52.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 03:52:53 -0700 (PDT) Date: Sat, 11 Apr 2026 13:52:48 +0300 From: Dan Carpenter To: Joshua Crofts Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v2 2/2] iio: frequency: ad9832: simplify bitwise math Message-ID: References: <20260411085848.75381-1-joshua.crofts1@gmail.com> <20260411085848.75381-3-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Apr 11, 2026 at 12:47:42PM +0200, Joshua Crofts wrote: > On Sat, 11 Apr 2026 at 12:38, Dan Carpenter wrote: > > > static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout) > > > { > > > - unsigned long long freqreg = (u64)fout * > > > - (u64)((u64)1L << AD9832_FREQ_BITS); > > > + u64 freqreg = (u64)fout * BIT_ULL(AD9832_FREQ_BITS)i; > > ^ > > This extra i char is something I really dread as a vim user. :P > > Damn, that's embarrassing... Should I wait 24 hours before submitting a fix > even if it's this trivial? Thanks. We're not the boss of you. Do whatever you want to. :P regards, dan carpenter