From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67CA41D5151 for ; Sun, 12 Apr 2026 10:42:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775990535; cv=none; b=mJVpafnIzTDWuffp+dBN8eTudTSQ4OPcao43eCeZyak913tx60PvMG58NkOaQqBIftzWyNHdH82d2CSYz77U6hTENSNdYGQQG6y5hcR+mXG1fAl12/9ZBCSCGtesArdZiV7SfR/iUsvJlwvJtKJrCOpCaybjBFqXIDTAtyqWttQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775990535; c=relaxed/simple; bh=hnGxa3qG9mgyUJliHHJZtavQrTVWfhpaP1QR2HnL5Bw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cVRfWYLjiQkZv6GGFvG1qmBB25LiEKeyvNoZTzTmce3cC4fTA5UC+G/svAhPQBIQuAKNVJg29jv6aSk6rI/sZxSmTUUhB6Ily40MMZaW9k2ah77IpLoBqVrQWThWn1t4VIaQRxXF3G6HhsKkpPR/AnsKSgiCM6r8BydIL9B6e5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NmTJzpZ8; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NmTJzpZ8" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-82418b0178cso1722785b3a.1 for ; Sun, 12 Apr 2026 03:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775990534; x=1776595334; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Nhr4iizw0k0+++Lyk5+s6oL67qDlXiTMljjiFK1kX3s=; b=NmTJzpZ80bOYpzI8lGfEm14bXjcSF3sqOQ8N+L+NQ+5RBmo4gQBAXkfN6JFeThiCKH sCKcXUp68CrEnn/JfrdhKH/nt5rraEb8vVAG0UECJy0/o3YsPOOF1ibGMaquc7Ehl13K 1xpbLa85xQmfzdTr8qgoSw++CgHYHhEyG1xzupqO4Vnq9gGR1Os4jeZlPHgocgr5sEU0 +Q5u7pAvC1W64Z4tx8RsAnR5kXXloZl1djbTbUj5/ISXu0AsXiV9bysCFvYu6bV6LSa/ UoWAb6qiL1CXGAt/JEFDsycEpIfQWjUu4/DGRCHruA2RhnnfOtdHRaenMsRpM0vAV7WM KhbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775990534; x=1776595334; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Nhr4iizw0k0+++Lyk5+s6oL67qDlXiTMljjiFK1kX3s=; b=sEdCB+xl8ODvs5OjNRffgDdshTSHr1hjiSIeuQGJ/YfZVPwwdn9g7tS6KtW2R3qoOY wthEaR7Il79fnBmyxsD51b19Nqs86O728hT8kapUS6wjlHmIXqlpoJPN11m/K/yhOc/D Q/iOaFesAjCbkOgN3bnrZ9tSzmmiTsWQAnrKWz3JYUFsCwHpnKrRl7C/O5iUVHHboTVu 3Qk2F7U34gUSck2Z3BtgC1UmmqkVVj565vygytaNKeZqAKlqk8DitTvjvRjjd+8JP399 lnecxRZtsPQOZQtw3ms22PbWUmPyOL587gc+C12kC1kGk/hfFoY9TnC2NpRm6/EMpUR0 0JZw== X-Forwarded-Encrypted: i=1; AFNElJ+B4uC6/78bdrStMAR8i/yjsCcJXoGOUn+nze6Ia5VhWp9hkQJbAUBA45ALe9LPjBijYbIenC4dseyDN2E=@vger.kernel.org X-Gm-Message-State: AOJu0YzbITigQ8RaJzymsiD3puPOs78wlkc9EIYT+SCpugY5GFn6/36+ G9/LuzVkTQPou4G3xjrWHN8GmRPi7E3iFHnUmUZIKLgGdfmBOlN4uBZe X-Gm-Gg: AeBDiethcMHd5W4I2TKFKuMhjySHmPFepsEzJBlycuktHokbLTMoKLYb7dtUu2AxdlR 8VEhzwSs3gmdgyza3PJNL2N+koj7VO1o/OkFze0hKaRZkzD11pGYkijJR1S1OnlSsULqxkN+gEd NDMjHm5F4CzoKpeiW6F3t6Ge+uhdSPdfWkSkfGML8M83lGZtpCgD8LLRTwFsNg9DEmPGwN7wLuy jqZ3tnAYi4WlUYFSYXPr/HnZFX5gckuyN5lvgzzMPFKcrt3twojDRSbkpk15Zak4LvCDTFKlWOr X3NN02zX9W4kXSjt6TG8j82egj62AbwqQH35B0yDj/OhS4x6EuPjXkycPV+tGbejIiVTj2QqRKq /uXX6tP8DlFgKfi/XzV2bFoUauKwKKCVYBoAIiF+VCGXilXj399/6Bma4FjFV5hWiCFwiAxP6ox LaxK+GnMyiZ7+bxuCrV34W8EirIynYahGJa13rVAeodUPcyaa2x1hZVD+K0LU= X-Received: by 2002:a05:6a00:ab0d:b0:82d:24f:2509 with SMTP id d2e1a72fcca58-82f0c131fd6mr10276431b3a.1.1775990533717; Sun, 12 Apr 2026 03:42:13 -0700 (PDT) Received: from KASONG-MC4 ([101.32.222.185]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c52cf05sm8070937b3a.61.2026.04.12.03.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 03:42:12 -0700 (PDT) Date: Sun, 12 Apr 2026 18:42:03 +0800 From: Kairui Song To: Barry Song Cc: kasong@tencent.com, linux-mm@kvack.org, Andrew Morton , Axel Rasmussen , Yuanchu Xie , Wei Xu , Johannes Weiner , David Hildenbrand , Michal Hocko , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , David Stevens , Chen Ridong , Leno Hou , Yafang Shao , Yu Zhao , Zicheng Wang , Kalesh Singh , Suren Baghdasaryan , Chris Li , Vernon Yang , linux-kernel@vger.kernel.org, Qi Zheng , Baolin Wang Subject: Re: [PATCH v4 12/14] mm/vmscan: remove sc->file_taken Message-ID: References: <20260407-mglru-reclaim-v4-0-98cf3dc69519@tencent.com> <20260407-mglru-reclaim-v4-12-98cf3dc69519@tencent.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Apr 11, 2026 at 12:43:00PM +0800, Barry Song wrote: > On Tue, Apr 7, 2026 at 8:04 PM Kairui Song via B4 Relay > wrote: > > > > From: Kairui Song > > > > No one is using it now, just remove it. > > > > Reviewed-by: Axel Rasmussen > > Reviewed-by: Baolin Wang > > Signed-off-by: Kairui Song > > Can we squash this into patch 10/14, where the user of > file_taken is removed? > The same applies to patch 13 as well :-) Thanks for the suggestion! They currently have different reviewed-by and suggested-by tags and I hoped to keep the credits for other people. Seems trivial.