From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A670D36A01E for ; Sun, 12 Apr 2026 12:58:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775998687; cv=none; b=VmjmU0HKg/ZNe7ImhEtA6Mg3hozq6j5UkAgtllew4ZG6Yl9KY7bVQlrBho/kwaoH6dUnSblorXiU0vogdiJLOc+0LsOUfDqg/8NyTaJAXGXvEH61l+gK0MaTE11OhYyoHVm73g+vrAfw5Oh0wRU2VSYaaRZ4Z+/vXhJ46uK0X4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775998687; c=relaxed/simple; bh=ODAEhkchItJTYN0hQTjTm8PYkpnYXzF/Yp3CpmGsKNg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IzYwmcLOZu8kuQ4zzNd1yv7IqtQ9NLR2CrOQ4hKCwxDedUxL+xryp4m1PYq5IQQPvJ/SXIu95xD19U372Vt2EtQQLS0XyriKuEX7COEwZDukptnztris1v3o1ehmxnEcr8LIPltWxGX8lOuucF/3ieYmzYGG2FMpEVg7vhVjksg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LwTGtYAy; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LwTGtYAy" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43cfbd17589so2344269f8f.0 for ; Sun, 12 Apr 2026 05:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775998684; x=1776603484; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=nP/0Rv4uOkvV3YE8Mcp+3h6PfpM0h7eJxFsh2cjVBaE=; b=LwTGtYAywEeBtEc/TGHrMjV10qNHXB4o7N0eRJb4tgTPJk/ECy+fq/8tMLfTb4bO10 +Nh32PmWHNU8zT0g0JFYuesaPaJSOPoK6ASl6mI1mZhCVkPJPF4tEoNMrGtmESPecrt4 hi7kmdQigdQ8aWsUCz+odVeNGBeqzZ/NqvRBp5gEPhTfjmXYh7ng7/+4oy0/QGYL+Kas e75jLfDM9+o4JfA4dws7IFL2OgY878CL4YtuDhoohVwq/mULMz3JBxhkAzMnyaB5OYyh NvLwlM3Z3E8flt5UWTKe7vhVQhJCjOWvm6DAtr0FHtTVTcldoLhjU+b2Dw321wjot/P/ TJ8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775998684; x=1776603484; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nP/0Rv4uOkvV3YE8Mcp+3h6PfpM0h7eJxFsh2cjVBaE=; b=p8f0HXXwrTclymt8CHTTJM2OSuWryFkER6JbiWxdFgHKFn9uh6+gX5CbrUJVr3++nx 0n2pTkcRZ+4LKsF4FTIFa2oTK3sulRrwx1/+VF7RSYyS17DemAvQu4K8B0+T8iNRYpNY CbT7vPTl2Y2FSykoRprOCPzYjoBchLkMHF7YR0bkR9I4litUt7wNZgdwtRHYkyDA4MLp oDZvOfnuMhPBE4vQp2DEq+47K3OsGaawHF1uqv1qM1hj495k0M0YjvcWI7iLUc1pXGup oUYmqjFRmxPrmImQrtbrb5TwFoxbulol54FKCZQ/lNkkcDc7Efus+UuRdymOqk63yqna J00A== X-Forwarded-Encrypted: i=1; AFNElJ87bJEnJh+yHIRVUIZH2Z1jivZkyX0DURNzgp15V/j9Q2rgs3ahysi8l5pstMZAeiLnSI57eimu90pQYKg=@vger.kernel.org X-Gm-Message-State: AOJu0YxD0bRcslDmkBwJ+VLSxMSce+k+ugY0FQwzjNZJktDHf+hS0wk9 68jRKN6bzxEFF6ruwtOyzDjljVB5cnxziIbB/CDkbl+ePctooU9KrSHcf6xpgg== X-Gm-Gg: AeBDieuPgMi+Aaz9uJVYsJQceEOvzuIk9SI7xnyCRO1Rf15wj9PNCXMajNbEZ+BNmwn fSDkuR39enqVkX6Bm8AJLEMoGNSAfzB8XPTE0PK4k9Hs0ZCpYLwUkrFuhdiMyjeynWIOc/V3d/K hhcPgCTMXQ3aqhKngKpYoy6MESpp/6t29D/nf1ImKIiC3w/ok76jyvc1ifTH9CckkosI82tRv29 h50gT+ukLg0qMO3V0hr5t9k9yd3A5gDXZG4k8H4HP3+lnlsbtEq/Rfy0ryfceI0zPzxmLcwobwD YNCQIK9/R2dw3QylAWMjw0DP0T623q8fSYXhjglIIwXIGwyXH0UOQk8LaH5PfZHf3xjH/Hcovh3 T+roHhp4Uvmm6FibBRTP337itLzAxNG/TCOh9GPIkKZQ5T084M8DQQvaQEcaU6jsdnP7+cgEhns p/AWmFGf3tDc5yXSwM0+0OshB2nHQ/sw== X-Received: by 2002:a05:6000:24c2:b0:43b:8f30:39bb with SMTP id ffacd0b85a97d-43d642ab9a7mr13597067f8f.24.1775998683705; Sun, 12 Apr 2026 05:58:03 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e50200sm24456048f8f.29.2026.04.12.05.58.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 05:58:02 -0700 (PDT) Date: Sun, 12 Apr 2026 15:57:59 +0300 From: Dan Carpenter To: Adith Joshua Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, straube.linux@gmail.com Subject: Re: [PATCH] staging: rtl8723bs: replace magic numbers with named constants Message-ID: References: <20260411052817.354594-1-adithalex29@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Apr 11, 2026 at 08:04:56PM +0530, Adith Joshua wrote: > Hi Dan, > > Thanks for taking a look at my patch. > > These values come from the RTL8723BS register layout(as in original vendor > driver) > > For TBTT_PROHIBIT (0x6404), the register is split into two fields. The > upper byte(0x64) is the TBTT prohibit hold time. The lower byte(0x04) is > the setup/margin time before TBTT Is this available online somewhere? I did manage to find TBTT_PROHIBIT on google for the rtl8188e driver and the explanation is here: https://android.googlesource.com/kernel/msm/+/android-7.1.0_r0.2/drivers/staging/rtl8188eu/include/rtl8188e_spec.h#296 It says that the "TBTT prohibit setup in unit of 32us." but the patch says it is in units of ms so that's wrong. > > For BCNTCFG(0x660F) the upper byte(0x66) configures AIFS value for beacon > transmission. The lower byte(0x0F) sets the contention window to the max > value I wasn't able to verify any of this. Please provide us a link to your original vendor driver. > > The intention of this change was to replace the unclear hardcoded values > with proper macros(like the todo said) > > If it is needed I’ll send a v2 with more explicit names and brief comments > for the bit fields > *grumble* It's honestly, still not clear if you used AI to write the patch or not. regards, dan carpenter