From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACB632D12F3 for ; Mon, 13 Apr 2026 03:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776052588; cv=none; b=ppBwHSiYV7rD5Gp1erFvhc2s3Xutr98sk2A9WxYhWakyqDwrQS11AKZdMYZ+5jbpUXXuvJT0Xh3dodqVgJIKd4AlNIhlc4QJaesEZLiYsiZHD7rZeV8nTEGeLyYbIUe7ZXkWOJSZ/DC2vEO07D1zx/sIrODxJUWPGY3jcE/5FGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776052588; c=relaxed/simple; bh=Ye6ecSjodBIYRJObejboSvgaGjpMkTghp2ypcRpo6PA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=epms3cKtZ8izj6QbNx2yuxZa3FbazWR9tEzj4JiXYIPri15Sj6vHc8pQhOe361WgUdTammzBPoqT+JfKVD2zyB/ZhGGLF5cYsNfLJpV3jRr80c0l722Ipob2qeNJjlGK9J95HOoic3myVOMZGzuKMublxhRlSDvvxsdInAqQWls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RTNQ9oUG; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RTNQ9oUG" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-2c156c4a9efso5391606eec.1 for ; Sun, 12 Apr 2026 20:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776052587; x=1776657387; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eLmrx+20TRfegMk1Fsd9XgfQ6YvAqFhX5JtllbLwzLE=; b=RTNQ9oUGCWy8C0GGtegICZJ/4Ivp3lTMnfqIAu0768RW6CkAYFW56P2qWFBqNZskj0 TuONKvXjUJYe5+xgfogct6lzuf92pj3XpMIOi/ue2bt0dkb3yHwcFJrm/M59/jcNuGGj RFZGfP5heI+DfxLRwbKUkM/NljNQSsUaiB7N5M/kDsi7pRrIqxbpmoI7KlsXh2WhqnuG E5cEnyp5mIz03/HPfNcA3oaAsyuhU0miJ+ZFiswnYdbDddDsq+3/WgeWIohLqOyZl4eN iD8+cEU9BINsRj+JOsD+j5VfbPdQSFqAvn1TcM94Mp0TQ/NKh79e2Nh21tCNjdj9icVk H8mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776052587; x=1776657387; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eLmrx+20TRfegMk1Fsd9XgfQ6YvAqFhX5JtllbLwzLE=; b=T6E3o3FZWAidX0djBjmtLNG20zD/gykgI2bJTAopVr+J0jqREwDphYAfNtWt5OiQH7 Zq2VCBV0a1ylLvgWY2/nH8htLy9V9zOziZN/Iao0fjpoL9UhdyEPv6F2t+MZp+vV8CyR nGkXqBnEDEQYhHvU7BmuJdmoDIowU39AbCNmXTKL4EOVTi/tQssfyXnLRu9Hg5W3enAp Vd7yGOXWABND4Ex0nvHgjdFdHgEbT54PqiJtWkLTCax36cLO5axyKskRAcSqICj4qN1t VkzFVQXLUUkT9VZnZdiTSTPXKSHbB2f6MSbtqJK0vdspOfQ2d1xe+mmumpecDQ/09pWE YBmw== X-Forwarded-Encrypted: i=1; AFNElJ/ny//psqRyUxp6/rWAFk3AW/4fHEKfl0OgnaOkEmQoV6YORHhSqArOoYqhmF3oRQUr1Ml1iR4pv3448cg=@vger.kernel.org X-Gm-Message-State: AOJu0YwyihDZblzqRVqH/8i5VAnws/3Y7BAYVVPvDjsLis+WkKQhL7+S VpVAHy2766OUwa47mFfsvVn+KqaLihjpPs6W96aSa86nCgdRfG4xnpPhZbZ6Vw== X-Gm-Gg: AeBDiesllisRKiBBRtW0Zv3txyda7LKQY7YEefzLvlOkW71/gIil/b4yePOm1DA2Hks vN1s/ejDgx6TJ8nuqrg6EbTWb+LHfs1KyMqSw7fKp+OJdc4gqDmRkpUSgv75GYxo5pA2+rLFK7k 1efhBrOb1wEAcHBGPZCiu6UtYPzG3eu9vd1h6DztJ5zKLFieWAhoTW+MBbcVDWQe8jTrS6Yv2o0 6v0zdvMeVaJqUxQzss430IRBsQSKBbODI7wDhMS+4wRXSrzyFtrCKtCenHztGAVncCURqJzv6yu R7zdHgxvDSafXE34qE5YcR1zgJPjOW2RCueS6lACWh5rvF24yNuKXvmq5jwc0XkGSme14fik18w aokysbg1pQqGYmO5EcqLLmch2ZhF3l8e/+tVdNQhhrHBeLkiJvDyVFbqRT8g/+TKY4y8r9jdOth LmGp9K6X3RnFFF1ToQnNqdkOMQs9ZJf/hqEhaVhDdN9KnObAuApYtaT5S4+CZ8tVBV X-Received: by 2002:a05:7300:b913:b0:2d9:6373:ad24 with SMTP id 5a478bee46e88-2d96373b29dmr984465eec.26.1776052586717; Sun, 12 Apr 2026 20:56:26 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:fd17:4617:989a:1816]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2d55faa586bsm17303919eec.11.2026.04.12.20.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 20:56:24 -0700 (PDT) Date: Sun, 12 Apr 2026 20:56:22 -0700 From: Dmitry Torokhov To: Bartosz Golaszewski Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , brgl@kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] driver core: platform: remove software node on release() Message-ID: References: <20260410-swnode-remove-on-dev-unreg-v1-0-cd7d305f3db2@oss.qualcomm.com> <20260410-swnode-remove-on-dev-unreg-v1-1-cd7d305f3db2@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260410-swnode-remove-on-dev-unreg-v1-1-cd7d305f3db2@oss.qualcomm.com> Hi Bartosz, On Fri, Apr 10, 2026 at 01:50:45PM +0200, Bartosz Golaszewski wrote: > If we pass a software node to a newly created device using struct > platform_device_info, it will not be removed when the device is > released. This may happen when a module creating the device is removed > or on failure in platform_device_add(). > > When we try to reuse that software node in a subsequent call to > platform_device_register_full(), it will fails with -EBUSY. Add the > missing call to device_remove_software_node() in release path. Thank you for spotting this, but I do not believe the patch is correct as it stands. We need to differentiate between nodes registered by platform devices vs nodes that already registered where we simply use them. I think we need to mark nodes that platform_device_register_full() registers form swnodes as "managed = true" so that they are cleaned up properly. See also sashiko feedback. https://sashiko.dev/#/patchset/20260410-swnode-remove-on-dev-unreg-v1-0-cd7d305f3db2%40oss.qualcomm.com Thanks. -- Dmitry