From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56EA437D12F for ; Mon, 13 Apr 2026 04:06:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776053173; cv=none; b=ppG4PPCkTCjWxougyuMFhrFZd7dXtV805cgJP2CZjU7zk1ceNxUPCHDOabrYyY+B5ZM6zoh1jOduJmxsg+8VgrEUmmXw2Rt9BUydzc1ixKnT6CF1rQu3U0k4OsaLcyBwoWJz0BK2Ud7KqvbUPG/OMMxOs1Uc2npxFy1tTjZn3TE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776053173; c=relaxed/simple; bh=mEMVuATy7dHKqzrpnkbq61aIth/jimGFihuRh/sWPLg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DcPMlqcOUieWHWeuMuR/I0/nmCI81anaziwvRncOGdrDo/O11NktFyj9IzZ8wuqZvRNQJWRHgcahp0hFQRq7UQ9JecNE63+yX2XilNMKr09rTsS3ESUN9LtYoclAe7o/VpEqYl3OCQqSRmhLa/B/6cVfJCKCMf1ZcKP7bS9IpMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n2Crb4m8; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n2Crb4m8" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-1271195d2a7so5011908c88.0 for ; Sun, 12 Apr 2026 21:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776053169; x=1776657969; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=nb0cKWhfZ2pbCxb4NS25yOctz6k2jHUyzjk8q6pYUyA=; b=n2Crb4m8vUbtzzPg05iuE0i+dYP3nznk16gbtVnbEex1RLg4imC3fE+eJANAdmLfOz k0ZZJdOqcIcG6fUU5ZYduhGIvWyJKFtsQ8Cbk/9Ikeh9S1i11nNsfhM0ZWaxR2OQTddX q/GjxrN625eVbZ20Vd4EkHDr9T1kIKnXeJRbgvhEVnxBwY2u1ghl8WPgamf1yTQKD7FE dB1jqHhGv6BdV5SXWqmSfvnpPTvSM5ODa/qrc2wJsPG6B6REzM8IQ8Q2VXcf2H66rcyk ddOxTY7IWwcX3kqVMvK26JYFtafu/35aFv/CaJd7UV4sVRKC4L+n9kv04b7r3I5aQenC 1RJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776053169; x=1776657969; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nb0cKWhfZ2pbCxb4NS25yOctz6k2jHUyzjk8q6pYUyA=; b=AWG8V0UH4XCFIHGqpzY6GKUWuOgQC+MpTXwXKG08BiUoOzLgbvAF5ETPZMh/WmV1Vo yzoTBM8xFuaLcU92xDYO42jwjgu2qL5urhmgQa5boRMyCokLvVsf3eyZ8ePzb9soIjc0 Z5GiZqPWvEbHiddPOwMt+TlqNdlycvObWZRhSQblarNqFR55hUMGa0U/Cban6c+HGLcF vzYyXkcgi5+hdPlA+UKV/J7fQ2c/1Z0ZatiA+9LqkTnlFyRVGIBjVzPJBHQAQ63duvhK VYpkvPjOVE0osTYsmDVsZRH9txlJ2cfhY0V+EfKxy1UpxTAEji+575Ix/gZROsJcsjaR Coyw== X-Forwarded-Encrypted: i=1; AJvYcCXvU6wQx8RFnWaNlngcd0Ha1x0PruGHbINqtM4a9EsoAMnf6INexGNXQ4z2D8eqSsD/DN6XBmpa23JpEB0=@vger.kernel.org X-Gm-Message-State: AOJu0YyonxdbfJlNHXM3XFsgPWXijmzrOZHNOPDYmFoU3dGw8otliTky +p/AYBvYj058Yh+x/NeZlLqi+SjjttikTmmrywjAFWDm2HLE0AdUaqxo X-Gm-Gg: AeBDietxVgqIziq5hsz7+9CS8VM0CbitrLKqK2ag3cIXm686NQIWbbLTYoktzxGhEVS uyoEaBb5wsOIs+J1ICzgDAzyjnV0cjiOwwiLGw0/ai7JI+t9TtPMqKFaNI3eZQVQA13bDiUn7IX QhqtSkliQPcv3deA1+2YnnUxczQPVXb6OL4TkgGyUTuipob8b/5/EtMeH1QbiB5kDLnK8nwBDpz uvMoWyupPMe77FzULrtK/glbLswfqNWtsXjSdK6A1LFRUtW05qX3w/cNGMVM/HVPef9VE2UvJjm zONGVj8Ufh9HxLI+VEqjvs0ykc396lFYpJIWm5NDpbTChG6NrcjqmmtSMC4sAujxhDRctEKitZA lanBgrFC70nyMxkwH1AIs2q0BLkY2ggj53sU3pfdOhXyrEESpUNgqu/klO/HDp/ASftQQ2bqBom 8hxbwnQ+dIykTBs/oruA+MahkD2KLXDOw5UkRa8XkkmZh6DjifbVyRvIPunm0cCrY2 X-Received: by 2002:a05:7022:2581:b0:12b:ec96:c936 with SMTP id a92af1059eb24-12c34eab249mr6929273c88.14.1776053169070; Sun, 12 Apr 2026 21:06:09 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:fd17:4617:989a:1816]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2d55f5c69d5sm17394977eec.3.2026.04.12.21.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 21:06:07 -0700 (PDT) Date: Sun, 12 Apr 2026 21:06:05 -0700 From: Dmitry Torokhov To: Aaron Kling Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: edt-ft5x06 - Support label device property for input name Message-ID: References: <20260409-ft5x06-label-v1-1-21e8a9ae9a60@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Apr 12, 2026 at 11:02:59PM -0500, Aaron Kling wrote: > On Sun, Apr 12, 2026 at 10:58 PM Dmitry Torokhov > wrote: > > > > Hi Aaron, > > > > On Thu, Apr 09, 2026 at 06:16:08PM -0500, Aaron Kling via B4 Relay wrote: > > > From: Aaron Kling > > > > > > The AYN Thor uses a ft5426 and a ft5452 for each screen respectively and > > > these currently get the same input name, making them indistinguishable > > > from userspace. Support setting a label in kernel dt to make these > > > report uniquely. > > > > > > Signed-off-by: Aaron Kling > > > --- > > > drivers/input/touchscreen/edt-ft5x06.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c > > > index ba8ff65f7ea671..c36497571b1aa1 100644 > > > --- a/drivers/input/touchscreen/edt-ft5x06.c > > > +++ b/drivers/input/touchscreen/edt-ft5x06.c > > > @@ -1285,7 +1285,9 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client) > > > "Model \"%s\", Rev. \"%s\", %dx%d sensors\n", > > > tsdata->name, tsdata->fw_version, tsdata->num_x, tsdata->num_y); > > > > > > - input->name = tsdata->name; > > > + if (device_property_read_string(&client->dev, "label", &input->name)) > > > + input->name = tsdata->name; > > > + > > > > You should be able to differentiate them by their sysfs path. > > My target use case is Android, which to my knowledge can only use > vid:pid or device name to differentiate input devices. The sysfs path > does not help this case. Please work with Android team to add missing functionality. Thanks. -- Dmitry