From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E3AE30B533 for ; Mon, 13 Apr 2026 05:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776058867; cv=none; b=VLxE80ZZ81QC90Q4y7YgaLPI6bWNsmxqGoOBFIQW+JFAUs91hERV3cLaEX9GnnqF2R8vmmry0Vnt92xj/Hw8lFGKPz9OzlnAdiGKcnwTE3jzKF5ccueCvOwV+b6u6Z9AGTWbeD2TYFKEB3gaHClfARk9ncYX5kZ422KsL8ISMas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776058867; c=relaxed/simple; bh=Q5Tj0+w254xGVsd/KRBlCvPQGjOgCDtEhBKlkvmXyCk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t48J+KmWe8EwlmHQ5r5gaP4Pu5FbqdJKbLlYrtnXSmzyJx+3kJOvAJeQeUyj1PyH6csf9NLgSR6GmCUnJbV6L6Hs79axql5O0W7/mzwb7dXU1+3PAj0gc2hAgDooCz+pu8EsamT6No8RsC2ILQAMnAenIUafVWtP/85XzVCczAI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HxKNmOJ3; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HxKNmOJ3" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488c21c636dso22866215e9.2 for ; Sun, 12 Apr 2026 22:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776058864; x=1776663664; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=dTmkbvlJt8h/jC4UkITQGkJt+uVKbvg0FZKUsmv0G2M=; b=HxKNmOJ30S+uzZZ5/Gtxkh/SHXoozdKwx1F4VL9J2nayI/6K2Pxq2cHNm13ddNVCtA 0fxH7Ojuf6oVN928LbZlGdJ1zbPybfDbSUNZj60SfY32NIZMIE/847MlC5L1tz5g7qKG kbMUJin21FIGvFs9fwVOszmRQseyhK4/ebWiRYBkD+kfSj66XxCbbiODTiCqczBvPhKH RAYyY97bF/ULx09pbumc84IVq/b7B75GJjtPd116nf80oNtTgtLvY84KK7AEySn3BaIf Mx7lIBiENjCaH97BWrDXJecSXW5W+3VPRGkNJi3rsfAIzu4zynFg0O+PWB6ZS5Zm0oAl znUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776058864; x=1776663664; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dTmkbvlJt8h/jC4UkITQGkJt+uVKbvg0FZKUsmv0G2M=; b=I2Y7B1upzDePLbrLdoQDAN6aQptN92R1y3O3qLeBHWvxk9BwVuZWfIXUlYh6gvbIxE DmH0h+OFqAquQLG6xT9EQCFePgn3DCM6k1L//yQK5Mwdvc9s6bvgiFeEVgFg8jh8oTOe PcHQXmSDe3e9KTqJNXq7TahnOwqSEoECWbTqnPT/fIOwVQK1hh6SorlF2UNxZhVUOPKB uVTUODa9TQhrMHKL1Ma0rVrGsdb0HriixREDSeJJNLRGuScnQvARR0hm2Cgk7mY8zB3B qyxiHAMYAzCtF5WzDx0FN1LdhOmsMEq2QoD24Ed5UAfblOV8o/FA7RdGZL6dHKZZBcdD o21w== X-Forwarded-Encrypted: i=1; AJvYcCVkPu3K5XGlM82nB+/G6fQaacCq18350fFiCpQdfEdWNOeBexghOaCNZzmqvNyBw3laQjhL2szUmjpD/Wo=@vger.kernel.org X-Gm-Message-State: AOJu0YxBW8xyyLueclaZPW76oOe4phQ/n0TuJgWkO/qEuNUJZthCmhVO Rr8OXjcfRoqd6YQ0voqffQMcyLQhZNn5yVce9vQRoU1VAcnxm6Pc7/bcd2bhlJCA X-Gm-Gg: AeBDietu59rqwJDlKATv+2fzEKjNeztaUndO00V4w3M1ZYQlI8jC7Y968MKfCVOIuZE hUZbdLLrU2YGgP5L/dRbUHsdZYqdDHK3k5hRIeYqdUgA40YfrqCyymcr3TDLDaYTlMeMrnj66A5 9zRQMJEY5B42ECE4PWawNYpN/rYKW4YrVqZqADXnEvLNUEhon4II4oC+bW965R8vmgVURR6mb28 XqhXRqahb0DsSQtKtLhZBsRi6meDraGMFaygXCHnH2HOD1VLj7sx5/0kftGq2lRa4FGoEhr+I2c tw92IxoES/wRRCRkV95VTCj8V6NgawqRQuH91KRLkUqvz+TT73+cD/Kc1zd9ZspnItmCn/IZ18F VQMSANp1Y01R+CzC97k5xwFJyOBmHV5n3p/Mga0WPEVMRnKcmWDPm6juwKczpxZYM/6gU/K91sh WQI0IBHRMNqvuGAa0eAlQ= X-Received: by 2002:a05:600c:474c:b0:485:35d3:ce59 with SMTP id 5b1f17b1804b1-488d68101edmr147475565e9.10.1776058864358; Sun, 12 Apr 2026 22:41:04 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488e4d0ed99sm79266295e9.12.2026.04.12.22.41.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 22:41:03 -0700 (PDT) Date: Mon, 13 Apr 2026 08:41:00 +0300 From: Dan Carpenter To: Adith Joshua Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, straube.linux@gmail.com Subject: Re: [PATCH] staging: rtl8723bs: replace magic numbers with named constants Message-ID: References: <20260411052817.354594-1-adithalex29@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Apr 13, 2026 at 10:51:16AM +0530, Adith Joshua wrote: > Hi Dan, Luka, > > Thanks for the review. > > Made some careless errors there... sorry about that > > Looking at it again, I see that the BCNTCFG field mapping in my patch is > wrong (I swapped AIFS and CW in the naming). The TBTT_PROHIBIT suffix was > also an assumption based on a vague comment, which I shouldn’t have relied > on. > > I was looking at: > https://android.googlesource.com/kernel/msm/+/android-7.1.0_r0.2/drivers/staging/rtl8188eu/include/rtl8188e_spec.h#296 > > and also cross-referencing with rtw88: > drivers/net/wireless/realtek/rtw88/reg.h > > And no, this wasn’t AI generated 🙂(I know the choice of emoji could be > better) > > I'll send a v2 with these corrections. > Please don't bother. This explanation is again far too vague to be checked. I would prefer to leave it as-is until we are more sure that the information is correct. Misleading documentation is worse than having none. regards, dan carpenter