From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EE93392C28 for ; Mon, 13 Apr 2026 07:27:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776065234; cv=none; b=Lsojv9ij36HJjIDP3DCS2881l/1M2592Uh0XkFHXweNSgaTEA0P/6fFVcXDebCX9cfbBuNPGK+2TKlmAbu6I7/mYoJLpJbLai9h6OZMkAKGNafUDBuf/qbEYPeiUv1RwxesU0MbGfhpqSNHaCPEWUY21BJ++6K50mxEROf7m/II= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776065234; c=relaxed/simple; bh=TMX0GVYUcC/4pa4IA0Xg1yJG8EYpQyDgj0o91746WJo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LTlxUKP42mS9WBRtpMog9Dfn3lR4Cr+0oiE4mxFyFqgZ521NW2cVqEPO9L+entsr7KRyFIPD2xz730//mr0yEdO8jUX4c9NfQUAPutjEWOAia321JUU5LchKFQu3uXl+MZdVSCiH/Gy/nrYkXhzRIAr1RfZsGPVZKSZcZCzdm1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=odHyLPlB; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="odHyLPlB" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43d03db7f87so2510448f8f.3 for ; Mon, 13 Apr 2026 00:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776065231; x=1776670031; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vB8fTOutsfZIie2qCEI929IdjXgTwcdUZphinUXaVGs=; b=odHyLPlBEcIBHkOx3uUBySRtigfT6eq5C7VXwuAGaxfu78t173EIFl2Z3QocvwqGDA i+H3UFgRmGexfz6KhKj+r6Xf4N0Cx3oVnCtY1T0OqDk5foPObshX36kAwtdco/b35PiR BJYDgR7Zfz+rZRV6kQYpe/nH+RUa7fgVnUybgys3QOgz+3Q4WOo7mJKM19Kfoh1T2Dxt ohHux8bSWp6G+vgkuXE1P/+oqxJnfLsWOu4BcfKdxKKL06Du3t+mkc/+sfyXAOKOFQT/ RRFImocuKQA4fEgqiVCviIV5rVR8EKNyQLDO8yMRoBLP6qT2UnbgwD4MTHLVYSQk6oL/ +6tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776065231; x=1776670031; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vB8fTOutsfZIie2qCEI929IdjXgTwcdUZphinUXaVGs=; b=QIwNWUItYomEFAZST9pjZXxiv0Th5Lf2j+hQoqHqTVV3DR9xGFBc/hoaCzMGELcBuK Rh1U4CXnGXuso4CjNt8wkYiHGA3KY89IV5B+Z+5ufYofC89Uki0xmWxLHS46uwLARH0s +a5Y52sGlz2vzfrCI3Us2zpxnNfLhHgiOzbDLx8wUXJrIwVIXFxnKpW2C5RqbSVv3Nl0 G7qWJMBqZl7SzD8X9bY0j457J/IT+FULfXt9Q3cveiGfkCmD1a7sF0ugFWhmyYke1Cza PVeLoLxKuRpCOEx4CSh+rt0eEyEWwLJ/qGyDHFBMEYRAN/VR0EFj1J3qmZa+PFifx742 oBzQ== X-Forwarded-Encrypted: i=1; AFNElJ8irBAuryFYa+8Qo4fuepEfLSzPbgS3G7l9Buav2skCijjEnhHVg7Ig71a4af7QwFDz2xD3eTsMtbQ/+pI=@vger.kernel.org X-Gm-Message-State: AOJu0YzescTwOTMjcBrXBYSz2LZ29dZf7gcJZ8uUOOBxyN+1xoopirc1 JL68jCpIBLeMDrdoh2dPrpdzP2lmMEQ6O4y8bRkCmrr1Ay4VKZMmK+9o X-Gm-Gg: AeBDieu0BoD/J3TAeUMPWD4XpiH8U+arelOxekQJXbhIY2axVuDIVCEjsMJsh6cw0Ix TSkRabf2zX0ocJg8TdbPUVHBfpgn2mDMscaVLRQnEi0YdQM+GVu0i1J7cRhNs8J4p7n2CyhNTFV eVVqrRLHTn2hLAjxH1OVUSUNvUJCLJpaNSvKfm3h+F465PYMc/coLxf3k0MCw3Yv2BRrS6yrJjm 3ZD7ftxAOkg6sa1fl7W5Hw+SeRZLNrc+pUBpS98AanVv3zJamQ5T+Ft3HusWGHJrrJ6PFRfjaqG lHGYHUiwmMVjYWb2E91Yii+LrlpkwTrtYIXQEji2nqIe+bM9GLav0+i4N9dAdHyt0EGtyxGFh7V WAGFXDitQL4TunN3nV+sefmZyhXUeezw3yA338yy+jMg69rAbnbCb41aHYRIIwkGgkSqulw5hqm ovKEw8RkMELYoFOhJsjLo= X-Received: by 2002:a05:6000:1447:b0:43c:fdd9:1890 with SMTP id ffacd0b85a97d-43d642c999dmr16766155f8f.51.1776065231364; Mon, 13 Apr 2026 00:27:11 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d7400708dsm12208844f8f.25.2026.04.13.00.27.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 00:27:10 -0700 (PDT) Date: Mon, 13 Apr 2026 10:27:06 +0300 From: Dan Carpenter To: Alexandru Hossu Cc: Thierry Reding , Sowjanya Komatineni , Jonathan Hunter , Luca Ceresoli , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: media: tegra-video: fix wrong return type in tegra_get_format_fourcc_by_idx() Message-ID: References: <20260411211006.150782-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260411211006.150782-1-hossu.alexandru@gmail.com> On Sat, Apr 11, 2026 at 11:10:04PM +0200, Alexandru Hossu wrote: > The function is declared to return u32, but returns -EINVAL on the error > path. Due to implicit conversion, -EINVAL (-22) becomes 0xFFFFFFEA as u32, > which is an invalid V4L2 pixel format value. > > The caller tegra_channel_enum_format() assigns this garbage value directly > to f->pixelformat and returns 0 (success) to userspace via VIDIOC_ENUM_FMT, > giving applications a silently wrong format descriptor instead of an error. > > Fix this by changing the return type to int and propagating the error > correctly in the caller. > > Signed-off-by: Alexandru Hossu > --- Do you think you could analyse this to see if it's a real bug or not. If it is then give it a Fixes tag. regards, dan carpenter