From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B2E5266581 for ; Mon, 13 Apr 2026 07:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776066458; cv=none; b=l2XxA16oQWoYbKbtqHV6s77XS+valtVZkO5nTukat8alYkkkwP/kztKQfeN5kkNIW2+QkX6mD8Q/QO7x3JLGnBp0KeJ6SlYlfJ39/k7PTuTcT9c0lAMJxjdj6TKTpJ30Dr+zHsyyiQqQ2sUcXCgSN5VgHtDC2Q2HTu5zUmMw2FI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776066458; c=relaxed/simple; bh=cogvOr4vEBotFyTJYUG5btaH273pIVXxEiy+6sWzZsM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tKuxfe78gJRErTs8GnBQoStiqJ5aXJtgmgegos2IF0pGg8VXuZcxbxOB86vMS5cc/yuNPZrcuy89/vYdc69dnI3belfGT/CY+ZR98m+p15+69w90Gq5mi/ZNF6JrqAv+Gysjpmv7Cjb5ybjDCzQvHOebW8ShtoZ9fKvTOfuThZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HfHzNmFA; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HfHzNmFA" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488b8efed61so38023605e9.1 for ; Mon, 13 Apr 2026 00:47:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776066456; x=1776671256; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4WXXmkgmkXLRFQs5TSJIo6nu0BPdGMXPBlQrEL9eq3c=; b=HfHzNmFAVg+YysRgU/jTrXJ/uwFunR5jV/Gna2ScoxY0tjg8oo4OF1rsRwPIYDdAIT QrUMgsvbHno8iHRc7PBckCXC/kG1uIIF11pP4Eyh5BBT1xtQu82n6LpKHtOP4nKrFDnI BCo2LIMbAOlXMcb7ARwEE3ePaagMUb3Te4pUq3AdCRA9zNCdlJuRZuKV548Lxl+vbNh+ faK2YTaxSSw92rQxIx4Ys15cBYF9IGLt5ivj7Hh2E8LnJ1LkA4jhPRwk5qqoks9BqAid ojBxu2qrpIu95eAgvbD9QtoOiBVSIwVrP7VbdqgXFdjkAK1v+x+u2LZnR7MoaIVI1a1Q 7byw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776066456; x=1776671256; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4WXXmkgmkXLRFQs5TSJIo6nu0BPdGMXPBlQrEL9eq3c=; b=Y6Eivo9e/kOVUMREr/cGxGG0lscd+Ag5h8lUQ/aOKMG8vwjzhSCc4IW18OoIJt6kwz zLWe3yjtkAjKVTGn6MFz3kghRVy9WJqhJODOPT72Ps4n0dArItOe9kjAI4UvD2Cc72OH qbUUBQXTf857QUaRm4jXPsdudrK72hJKQ4gxHQGOL/g7ADOwcoO+NRXHbYYkvURC/1jf 2Luj7dwfFqq0T+XoLCkpAeHsAnx87AJA+y7nE9l0nAa4iBwf6YCDpQ7smydKs1gYA4+x L17t2MGyawgzIFb7HSzA2x7HhPwVRajIq7BfqGnaWLZFZANgbkiVS1pAIGkzoXMu6ewC uU4g== X-Forwarded-Encrypted: i=1; AFNElJ8hDpwjAmJfhLNqCIB41C8GcFSQjm8XkRS9xMDSF+qSDFfXDQxA4rIkRmpBYFSl4CAjwjuTCV7mRLYsxzM=@vger.kernel.org X-Gm-Message-State: AOJu0YzIO/QoAc4X/CO+k+8uZlAvLBNtG1f7I0hm0A3H2zy8wz4gsILX 1is21DIsLAuX/Wags6XHTBZreWrMMClUM4ostrwkZnbOnDtn9GdkrdMVSiV/kcs0 X-Gm-Gg: AeBDiesdQV/3c8kTLNPYOEDvKhJCYjHWxi0MQYyiWld0ffknA4ZLyKZyuyUoSPC8Bqa GTNLiKXM2xM7jrkzOxQl147nMB+b/Lc6pCiqCZcAm4eb48od5RcQtDjpVIj7YR0JHgQoAhGYUo7 nTZ/UIeohqt3Pmn/7yPoECCUNpv6fFyrX0SX1suges8Pf/73iWV/m+OQnydbUG327+eL2zl+2Vs Toc9dgHXhy19QwDOkAi/No3FYewUlO+XQ2uuc7hwhrX6K5bTreuJkHeEV9F7YMYQuSwDcJ35x5y LxnjbD6P5g1Y3VrlDqNuIoVYDE2GsyhmJODg7JZ6KGQO2PF2OtD4xPXfyBiHvXmWX4TNSQlyit5 D4tRWcXavTR96GBz+Jz73yYRjHddsi5P7ydYXtzjijfCzbzNi7sLpJk8HNwZXaJjK91lfy/nrYy bsjwlbj0oDw779Y6uCv80= X-Received: by 2002:a05:600c:a105:b0:485:fbd2:f72 with SMTP id 5b1f17b1804b1-488d681701fmr110867815e9.1.1776066455645; Mon, 13 Apr 2026 00:47:35 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d538a296sm279835345e9.12.2026.04.13.00.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 00:47:34 -0700 (PDT) Date: Mon, 13 Apr 2026 10:47:31 +0300 From: Dan Carpenter To: Nguyen Duc Thinh Cc: Luka Gejak , gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] staging: rtl8723bs: rename dot11AuthAlgrthm to fix CamelCase Message-ID: References: <20260412130012.5832-1-ducthinh100812@gmail.com> <20260412130012.5832-3-ducthinh100812@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260412130012.5832-3-ducthinh100812@gmail.com> On Sun, Apr 12, 2026 at 08:00:12PM +0700, Nguyen Duc Thinh wrote: > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c > index 4b4012411011..3ca8c3640acc 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_ap.c > +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c > @@ -228,7 +228,7 @@ void expire_timeout_chk(struct adapter *padapter) > } > > if (psta->state & WIFI_SLEEP_STATE) { > - if (!(psta->state & WIFI_STA_ALIVE_CHK_STATE)) { > + if !(psta->state & WIFI_STA_ALIVE_CHK_STATE) { You need to be a lot more careful. regards, dan carpenter