From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3319396D1C for ; Mon, 13 Apr 2026 07:53:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776066795; cv=none; b=gEWJbWE0rNJOVhaGX10B6ywVibEj6N56emry+GYwo3v5hHqjTC2JuwH8wHDmuUvB7plD/4VKOYMNs2oBy6/daTP63m0m7Br5D7nub/yGJ1G141e0wMptCnohH1zy2KJRnG1NWk7iK1ng6ZVGmnWOyQxFES/xJCtEWj9peu/acwM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776066795; c=relaxed/simple; bh=qURxmoeHtBYQQZeErf/My6lgX3gSGhOBzfCSynLVIZY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jp0IjIDIcr1Nk8LhYHnL+J/NEugcoMfIrhV6IAzHdbTBpvkhApP2OAV+lBdR7ObbLsxFdAPrDkKzS5EgHfnecjvepcBn+RZ71Yb8KHkq+5nwG/d6N8o7Az6MkK8rkaEgnOsxqTA/I3WM6+EL0gHl6r6jKm7aJAgbZPZSsZnl5To= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gIPnpE8v; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gIPnpE8v" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488ad135063so38624705e9.0 for ; Mon, 13 Apr 2026 00:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776066792; x=1776671592; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5p9ZJZXABKCmpzl6zl3MItAQjfacdhE/eXpBJaxRNq8=; b=gIPnpE8vbQ2exAGgrElXM9dU70STAef4BFQKq90nihInyVoyXpgKxCEw9mlrbFj/kb S7S2h29ltdHHG1qeJlNWHgChOWm4Y/rRWEHgQfr7mtHD28Gwn5JRKrUgLV23IdRmzjfh tH/sr/QfsRO6eB+jLU7niWKVOc4qQedHYsXeySRo8lNL/JvS0PFbu9kza7Kb9Q+Fcgt3 5RqJTNbgeTkk9JUtJyiUQGmRAmW158HQhRcDcZvh3ZWAPQA+nkuG31bU7MWKeIPNVyOz 00Pm/L89QHb1AycLywmnOIkay8/dEdX4WqzI71z0Oc6S6kpHojXywOsVeg+nNj899hpZ oKDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776066792; x=1776671592; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5p9ZJZXABKCmpzl6zl3MItAQjfacdhE/eXpBJaxRNq8=; b=iyaLazn/AIhf29Ozk/IKKvAFBGzoxzO64ehaqLrdrAxH3SM4MGudReAXdVEwaYVea5 9cTv/ydriuUb3v7s7dUTgqn/MI+hGYZOVenAE7hWTjdDZrqKeoLdbwfHX04mr2fjGYC4 sy3cF9hOkWlvS0lEemx7qh1F8N+MnFD0+rI5RrSyT+Wr38wEVeVPPUBhHqx3T2Ib/EkZ ktK28A0QZYt30OPnVd7qPdWmvjv0naQ7ft36bVki8yFwMPeEg+c/E8B+m/PeeAVFOGsP 46+Pff/7Z4PKDwDTx1hY3YE8Y5S0zB5eSZUCWvsFC5zwWAhw3RPqGgTEY+rCzKJSwYly rbtA== X-Forwarded-Encrypted: i=1; AFNElJ8Ut7iGJv0JlqVXMaDliwxocDrWoO3R/FI+sXJfsFOdcEa6v/seCbTRHuNPdexlikM3niwA4h6+3qvH1Xw=@vger.kernel.org X-Gm-Message-State: AOJu0YwiZ3WuobAJPpfx+uKisxxJqD5BWt56cEA278z3a6IX6Y5t3edn OeTKRgEuRuUC+E2295e6u6x6ILUNGyQncDTDceOmDXDAJd+3RaSbkAnn X-Gm-Gg: AeBDietiVPQ6PyQZj2DGxjG2KpTgAopb4xz/NolZXV/EWycjwDl8aRxJXSd7NRxsnz8 X97wj6eJc9TqCkco+FCj009FKDQq0nIrBQekunyU5w7ZGwgeID31/0tTSWG4IRCFT1+EDDTrADD Oi/ZTkHDOtmd34tvccJ0mT9rN4tVeYh998Q9ENfMD04e4zvwGPPvcU0O85wV5hyoHYThDr1LZmx 4pzFCAyG+MD/LzbjwwbruwF2BNq60JSLwaloWN6bS0AN4NXp6LLOr/5HgNSnjyk8Yd3FnNmAiiX 6KnWlBfHkbS9bPeBMqKPMhILYjNT6o4k/10BfH+Bn8dxv6AKxioGvN11sqBV+FlXE9UwRrLeUnl nPz8HHRhdxudYxrp+Mj0mRV89TAOtfBgbo5+qWqVRDbyHi2qek/9uf7Dp/eHa46Obz3299Bn7UI CgU9VtvolXQe2xQAsW463xczgYDEMwIA== X-Received: by 2002:a05:600c:a11c:b0:487:2671:fb8f with SMTP id 5b1f17b1804b1-488d67fa40fmr115755205e9.8.1776066792070; Mon, 13 Apr 2026 00:53:12 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d5934a6dsm303076735e9.11.2026.04.13.00.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 00:53:11 -0700 (PDT) Date: Mon, 13 Apr 2026 10:53:08 +0300 From: Dan Carpenter To: Hungyu Lin Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: tegra-video: vi: validate format index before bitmap_set Message-ID: References: <20260412154843.29056-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260412154843.29056-1-dennylin0707@gmail.com> On Sun, Apr 12, 2026 at 03:48:43PM +0000, Hungyu Lin wrote: > tegra_get_format_idx_by_code() returns -1 when no matching format > is found. vi_tpg_fmts_bitmap_init() used the returned index directly > in bitmap_set(), which may lead to an out-of-bounds access when the > format is not present. > > This can occur when TPG is enabled on SoCs whose video_formats[] > table does not include the requested media bus formats. > > Validate the index before calling bitmap_set(). > > Signed-off-by: Hungyu Lin > --- This isn't a bug which can occur in real life since the index is always found... If there were really a bug, like say someone were writing a new driver and messed up, then this would just paper over the issue and make the bug harder to find, so in a way it makes the code worse. regards, dan carpenter