From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 907293A4520 for ; Mon, 13 Apr 2026 08:03:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776067409; cv=none; b=RHoH+RKvFe+4i0tB8B96vxL+qZYQDRkcCJNahv+c1U371OMC+klmz/YFt6ujpdjRDdDxaEbIuWdF48gVVk5bfRnIMQnRtk2kGNePVJqNssH69bULSUgAkD4NOMYEyuYAeJb2rj2N4TDH25109Afm1lVlrzowl1xughUaY9p8HCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776067409; c=relaxed/simple; bh=wAPCziRy3gqwNYDXtdaW7ysNJai/VXJp9vLcAm4gnsE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qTT1RbH9iAdtU2cqBtMMZggXvIwkKDEjqiv3q/ASLcRSmSYeYp2zsJjjzvH3FF2NHaLh1BdB4jWISjtE9uzeMnfZVClmM7yWZDOjCRBFIUTLiIQ8rBOzTWKRVSnQcg3XhAaPFZjCSewoa+bvVZm4nXg/cZmFlouLPULt+oeQpSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CMmWv0N2; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CMmWv0N2" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso64554645e9.3 for ; Mon, 13 Apr 2026 01:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776067406; x=1776672206; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FdslTYfHiFdLBysZXJi70hRjVM/Tx0Yks32sBf4zOMo=; b=CMmWv0N2LkqUZ+GdzdOIWJ9f4WUHdMtzWEXZmryjG5sI+1p8RCVHpJrP7Vk2u05CRz OR8eHq4KPb6+8apkdcYIXTVT9xul/iMQ0jjzLnfIbcvn+fAWTCLLENgpcBMbY+VB+wjB vghwXedtqYtDrEv83f2hZZz6y+TNKlbM1r9Ze+P527Wo/1t2Hyz4ndxPrSZjzQ45eFq/ 4EtsPR4vplEMLqqCxgfK/Ke2R24VcN4neDM16EpwhxL8Z/P7KcXDERnRpiSSzSNuYbMb WJLg2V3FMyI2qPDh1UABxr6cuZUc7dnD7Q9MsbGvWhDwo5Mhks17Qpu7bLXvR9lsU0D0 EvKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776067406; x=1776672206; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FdslTYfHiFdLBysZXJi70hRjVM/Tx0Yks32sBf4zOMo=; b=dpVSMRTZedJfs7nOUVBAE2jh5o6sU0fvhP+2DL53UzJLNGwiqiiIvmTPMubHrB9/Yi 03aKr5GUxXroVGUzFRdj7FpDjIjhJ1OuXIKiWXDJqqn49etUPkMnVg9hRDLi00XsCb6T 876nt3LSfbldY40BHMZPHTE4l9Be7pX0Pd2If3OThRiG6gNX8D81HFdz7d5F4tJImNY/ njSVh1ewknnTGmukVnX50TLYcPioIv+XKLWpsiiCDqTIVxChRuaLhvkfPcI2KWNDRrv7 QshLooonNMCmPGPDiVwqbG7cxaQwWFyVDHl1wlyLDaEyTWav3uN/bcHz9y1j83LHslY6 EAoQ== X-Forwarded-Encrypted: i=1; AFNElJ9Pis0YGQUYZhVKmpbAl98Uz1olaqUN7atGoOZKulK4+rCyl7I5/Dk4dYCsPYzH2uAC6bd8/RhmdTPd6+g=@vger.kernel.org X-Gm-Message-State: AOJu0YwdVhcyyEXxH1q+W2RhWmw8cHxDukDnE/stTsSlG8m1xYK6yYI5 RF/9TR7e6I//dDFnfKhPhKfbfth+e81iYuLqkt5299cLsql2Rs8IsUpI X-Gm-Gg: AeBDieuCTnDk6jFkF7f2C1C2yMel66Gd0F2609rHr33eYP85bAclgRbOW9N09+clpmm LX3bIXtMFuZY/52IUnQE5hzVjKuVcLHa8TDDyer+K4RegnHl0yuK2vo5zuK2czwzBCfE7ObTxm2 Q4YYogS0Y67aVpJpKzXFZ4F5Tg7t3tmE+geAnpZ/Si4nybH72C74TGRJxE+Mw1KJVnNqNlqj0WB ds7l1KE4WnqDfj3g8RNknDKfxz3Wm8new5nSWRowYPlggFMka6NRcf2ZUN0F71LWmj3ub2iPLoF TxK1bGqUX1S9zF3Gce86Gjb2vzJtnxnblqWTXqzml30a5dJToPjwXLSuj63xnJMcYe38ecE5r2t D1nofVgrL8qj8qmW3d2RkAUbXTOC37SclVeicYFWLx+fl8w9Oo9uurdcEUP2Vfhj2u9RRlqJI5t O3xfGDfQ5RtjaDOMaVIUU= X-Received: by 2002:a05:600c:45ce:b0:488:a8f0:35bd with SMTP id 5b1f17b1804b1-488d67df745mr174646595e9.8.1776067404611; Mon, 13 Apr 2026 01:03:24 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d5d703c1sm89816805e9.3.2026.04.13.01.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 01:03:23 -0700 (PDT) Date: Mon, 13 Apr 2026 11:03:20 +0300 From: Dan Carpenter To: Hungyu Lin Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: tegra-video: tegra210: ensure PHY is disabled in pg_mode stop path Message-ID: References: <20260412163600.29925-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260412163600.29925-1-dennylin0707@gmail.com> On Sun, Apr 12, 2026 at 04:36:00PM +0000, Hungyu Lin wrote: > tegra210_csi_port_start_streaming() enables the CSI PHY regardless > of pg_mode, but tegra210_csi_port_stop_streaming() skips disabling > the PHY when pg_mode is set due to an early return. > > Remove the early return so that the PHY disable path is always > executed, ensuring consistent teardown. > > Signed-off-by: Hungyu Lin > --- The obvious complaint is that this patch needs a Fixes tag. The early return is suspicious but I don't believe you have tested this patch. It would be better to not send untested patches like this, because there is a risk that the author wrote what they did deliberately. This code is six years old now, so the original author has probably moved on to a different project. It's not necessarily that easy to review and test the patch. On the other hand, if someone from Nvidia wants to Ack this patch then of course we'll merge the v2 of this which has a Fixes tag. Just wait for someone from Nvidia to respond before resending. regards, dan carpenter