From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DCEF3DEAF3 for ; Mon, 13 Apr 2026 14:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776090716; cv=none; b=ubKIo30iqRwnpAimJ6bUtygtXsFWvIvXqEduo71JXKQk2vBIjsIhjp6UIxv439EytrP5ZBs4P9mm6vP3u3bFVkM2tbxo+INOqWZGlR2vTYN2Ap3NrUSJ6uNUqm4TL3yNI+oQwttUEhdCNCzJDhYkNwBQNXHKXcI9IHZzxgt8Y3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776090716; c=relaxed/simple; bh=QdhecxNCn/0bG/hhCqGarFGhQ8L8s/oqkFaIkw2aROU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OaY1odDPCsICi4XTMa+B7Fs4D4E7nLhsMjg9SHubf8ZJ/w/cwlSjHvCCJD1w65VG6++bDjo7tfC9jhp8t4koTzZv6N4GrXZfg7ilQaKE+Q0AKM0T72dL4Q004VNTFN/jOywuHGu+jOKaYG3UGweADG7ANJT///wtMnLkxrRZ3Sc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=gRsqUZF2; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=txhMkBUn; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=gRsqUZF2; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=txhMkBUn; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="gRsqUZF2"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="txhMkBUn"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="gRsqUZF2"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="txhMkBUn" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E7BC36A8A9; Mon, 13 Apr 2026 14:31:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776090708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oFbE6qgRyi3Tx/DuCsdhUHkiE4vb+Obr7lf3ABpgj0s=; b=gRsqUZF2IJ8u/97AMVKL87wEa/JJ8cUvu4Soh44pE2wdx1IFOF6Sa4WsHBGoyEmPVO7BSC il61Th2+jyG4R6XD2DuRLdnVONQ9JZXCDbzaD90tKUghbN7AVMQxK0mn+qWWa4nOU6mTRM SYs1DOmqvMMpvV84KdBAX4TVRbKofd0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776090708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oFbE6qgRyi3Tx/DuCsdhUHkiE4vb+Obr7lf3ABpgj0s=; b=txhMkBUnJckYbNjRfjogV4sfoTnHQLesPlqKuImNzhqPCZGYy2AceXxP8HH8nE55TlXYTQ 7Jj3znT9gRwhVICw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gRsqUZF2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=txhMkBUn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776090708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oFbE6qgRyi3Tx/DuCsdhUHkiE4vb+Obr7lf3ABpgj0s=; b=gRsqUZF2IJ8u/97AMVKL87wEa/JJ8cUvu4Soh44pE2wdx1IFOF6Sa4WsHBGoyEmPVO7BSC il61Th2+jyG4R6XD2DuRLdnVONQ9JZXCDbzaD90tKUghbN7AVMQxK0mn+qWWa4nOU6mTRM SYs1DOmqvMMpvV84KdBAX4TVRbKofd0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776090708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oFbE6qgRyi3Tx/DuCsdhUHkiE4vb+Obr7lf3ABpgj0s=; b=txhMkBUnJckYbNjRfjogV4sfoTnHQLesPlqKuImNzhqPCZGYy2AceXxP8HH8nE55TlXYTQ 7Jj3znT9gRwhVICw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 798024AF25; Mon, 13 Apr 2026 14:31:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 9tGRG1P+3Gl3BAAAD6G6ig (envelope-from ); Mon, 13 Apr 2026 14:31:47 +0000 Date: Mon, 13 Apr 2026 16:31:37 +0200 From: Oscar Salvador To: Usama Arif Cc: Andrew Morton , David Hildenbrand , Michal Hocko , Vlastimil Babka , Muchun Song , Lorenzo Stoakes , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 5/7] mm: Make /proc/pid/smaps use the new generic pagewalk API Message-ID: References: <20260412174244.133715-6-osalvador@suse.de> <20260413141801.1465873-1-usama.arif@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260413141801.1465873-1-usama.arif@linux.dev> X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: E7BC36A8A9 On Mon, Apr 13, 2026 at 07:18:00AM -0700, Usama Arif wrote: > The old smap_gather_stats had special handling for shmem swap > accounting. For shared or readonly shmem mappings it used > shmem_swap_usage() to efficiently account swapped-out shmem pages. > For private writable shmem mappings it used smaps_pte_hole() via > smaps_shmem_walk_ops to call shmem_partial_swap_usage() for each > PTE hole. > > The new code removes all of this. The pt_range_walk API does not > have pte_hole callbacks, so shmem pages that are swapped out (and > thus have no PTE) would not be counted in the Swap field of smaps? Yes, sorry, that is one of those parts which is incomplete. I am already working on that offline, but did not have the time to prepare it for this one. -- Oscar Salvador SUSE Labs