From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77E4147A66 for ; Mon, 13 Apr 2026 10:40:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776076801; cv=none; b=VYaq9olc+FbZABVtD6+SWL28YWncBBpqXF2qTQpl+TWNiLMMbGRl95RHDZv3gNDfvITHF4NGh7px0C+fIXT1H8BHEa3Vx0S0TCSZX6cj+T1xhxWCEmXa2yCWt8mRf1rmF3C/+oZBPKA28DSbMAVyO8+NI/uTSbdfS8QRwS2+SVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776076801; c=relaxed/simple; bh=QNf9fYuRbV6pofyWiCvhwQ8+2qT1V/f57gWB0ktbdBE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LLMRJlst8DXP2V/yLaW8PGhvNFnGP4sALR8EK3l0yBETMpo4OuXr4OHCPj4wK9UQcj6eqFqQnTska3p8mWV/BHz567nJxq80Kn9QdyHujuQg9uznvKNf5y9IhXG0Uh/gMzQDHC+UrNBhJ9kBYeUAGGbt6KybeCRbvGHX37ISKXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eqdT1FPa; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eqdT1FPa" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-488a8ca4aadso49910885e9.3 for ; Mon, 13 Apr 2026 03:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776076799; x=1776681599; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=M3Qpde+l3zSHqtGuk+YhxsSmgAud6Ug9oUZZ4dBVL5c=; b=eqdT1FPa6Ut2tNUnkNpJnkSV/tu6rZa0ArpYF06TyntokdVZKHObCa6eMrpGvnJoaV PnlcGZdeiVPwHOIAU3WPweJpC2D0c6+0K+Jab0hvoZmd1efLiGelGOzV4vLOLccegk07 H9YYjScQ3kxxmfnhDM3gkLV/71ac15IxOjT5hrUed3Ei9gQ4P1EnHi0sbfwphtotSOH1 AmUF4mX3ml+SZfpNGO3RA83Yy85asDvUA11c6x35n31z1VGTjdo1wCvpl5L+5AhqNOQb wvC2E2MuncQ3SxNZW0ti99Ihl550yV98tp0J7A93WM6+Zwufd52FKllZ2wTLANJppnUS p9kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776076799; x=1776681599; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M3Qpde+l3zSHqtGuk+YhxsSmgAud6Ug9oUZZ4dBVL5c=; b=la/CipMPOaN2dV/LcL9VgFzpHCPWEahKLV3B8La+2/RvWSSahu+DQrHnDPOgoOvYE1 9WIVa72lKiqid/pCqwJcQKKln53Iett6932/isHO6enlosH4HTvS6uxElsk5l0iSXx3g vXEX304D0vTT3IsJiQm0NTjnug2zNXA+nm8YVzf8KHxjMmkaBhtXX/iuPnvytCbubxqx CxDfNQcNT2nsO12Lj1R0fJzg29u05XBvINxjCG+RqVy2YckclAN7Q+UqqqC62zdlrXfd 4eqbwmw8MvM8nZanqyZjEspjnol/vfsv+Au/nsCujgRfbCm30J7UCpZJ2R3FIso96JfG f3gg== X-Forwarded-Encrypted: i=1; AFNElJ+EKzlwy/seVGkDSPU9d8Ulsj2gxT66v2XGtIxQkEKjuG6T1zLsHnwM/ROYfd1HA+SCRBbpDsMbLTRL0cw=@vger.kernel.org X-Gm-Message-State: AOJu0YwMXWWQZHPMROM+jZdzOfzmJA+pxDGPkh4Ftaehrw2BP692mWm9 nF43tdoLdn4W/DWcONx9S+/Eh0SpKSAFMKHRTqoiSeaAVtoUQeu2oMLH0X6rsBn5onU= X-Gm-Gg: AeBDieuCx65xmc965rtFoutBDzEtvuXAdc7uk/1UavRSCnhdWjRTFAw8J+9tPcWyfHy /oNA0rqa9ZIY0pWszE/AGeP5YQWT4saqhZjHGHcLsddmNjztagaeowh9uX3KPYA8fln/o8UzaaS iSN/N+yVNUVV6Mem1LdUfD4UlAsreq5rRzL3yHcGA9sIDlP7xTvbc7xTEUYc0xZiXMRuAsJnVYO zF2A37lqQ20DJh3n/Hj9hdkZXT+Xo6wINzvFPp1+oQIkYqn2VGk0egdlcDCw6t5Ncep/0mfQZsD yLy43nc5Syxv6aZDO9ginAaY0uSditC2WrHcnSCZ2eWSWSlnlXOobF1yHVngF6PxnY/yD/31qSO uGBlMb4Ca4e326taVyn0MTkkmCID1mpf1QbYGPNO8vKNbDqiL0tmA0MC+iwRkIvi4OfJ7ZbQP0z RRAUfOrxBrB9dVA0Oo1BY= X-Received: by 2002:a05:600c:8594:b0:485:46fd:7887 with SMTP id 5b1f17b1804b1-488d67f9a73mr119380225e9.13.1776076798374; Mon, 13 Apr 2026 03:39:58 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d58bb830sm295312985e9.7.2026.04.13.03.39.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 03:39:57 -0700 (PDT) Date: Mon, 13 Apr 2026 13:39:54 +0300 From: Dan Carpenter To: Alexandru Hossu Cc: linux-tegra@vger.kernel.org, marvin24@gmx.de, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] staging: nvec: fix pm_power_off teardown in tegra_nvec_remove() Message-ID: References: <20260412205057.386856-4-hossu.alexandru@gmail.com> <69dcbf4a.050a0220.1d6d81.c4df@mx.google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: I haven't looked at if you can actually power off a system while an rmmod is in progress... I feel like a real old grandpa when I say things like, "Back in my day you weren't supposed to call rmmod on a production system, the rmmod feature was only for debugging." But the bigger picture is that linux power off is a mess. There are a dozen different ways to power off a system. Here we have a driver which just takes over the power off process by assigning a function pointer. Shouldn't we instead have a list of ways to shut down the system and have a standard way to pick which is the correct one? Instead of worrying too much about this one driver it would be better focus on the larger picture. regards, dan carpenter