From: Sean Christopherson <seanjc@google.com>
To: linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org
Subject: Re: [tip: x86/misc] x86/bug: Add printf() validation to HAVE_ARCH_BUG_FORMAT_ARGS WARNs
Date: Mon, 27 Apr 2026 12:55:13 -0700 [thread overview]
Message-ID: <ae-_IfHQ90Nn_ydP@google.com> (raw)
In-Reply-To: <177731670864.3521451.17700947894959847025.tip-bot2@tip-bot2>
On Mon, Apr 27, 2026, tip-bot2 for Sean Christopherson wrote:
> The following commit has been merged into the x86/misc branch of tip:
>
> Commit-ID: 40c4b47f41b95dff743c841536cb64014e65ef0c
> Gitweb: https://git.kernel.org/tip/40c4b47f41b95dff743c841536cb64014e65ef0c
> Author: Sean Christopherson <seanjc@google.com>
> AuthorDate: Thu, 23 Apr 2026 07:54:17 -07:00
> Committer: Dave Hansen <dave.hansen@linux.intel.com>
> CommitterDate: Mon, 27 Apr 2026 12:02:40 -07:00
>
> x86/bug: Add printf() validation to HAVE_ARCH_BUG_FORMAT_ARGS WARNs
>
> Add explicit printf() validation for x86-64's newfangled WARN
> implementation, as most (all?) compilers fail to detect basic formatting
> issues without the annotation. E.g. even goofs like printing a u64 as a
> string aren't detected:
>
> WARN_ONCE(1, "Bad message, %s", vcpu->arch.last_guest_tsc);
>
> 32-bit x86 doesn't support HAVE_ARCH_BUG_FORMAT_ARGS and uses generic
> implementations that provide printf() validation. This means there's
> now a big blind spot is code that is strictly x86-64. Inconveniently,
> new features are also frequently x86-64-only.
>
> Fix the blind 64-bit blind spot.
>
> [ dhansen: changelog tweaks to flesh out the 64-bit-only details ]
Much better than what I wrote, thanks Dave!
next prev parent reply other threads:[~2026-04-27 19:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 14:54 [PATCH v2 0/2] x86/bug: Add printf() validation to x86's custom WARNs Sean Christopherson
2026-04-23 14:54 ` [PATCH v2 1/2] x86/bug: Add printf() validation to HAVE_ARCH_BUG_FORMAT_ARGS WARNs Sean Christopherson
2026-04-23 15:12 ` Dave Hansen
2026-04-23 15:47 ` Sean Christopherson
2026-04-23 16:58 ` Dave Hansen
2026-04-27 19:05 ` [tip: x86/misc] " tip-bot2 for Sean Christopherson
2026-04-27 19:55 ` Sean Christopherson [this message]
2026-04-23 14:54 ` [PATCH v2 2/2] x86/bug: Put HAVE_ARCH_BUG_FORMAT_ARGS WARN definitions inside __ASSEMBLER__ Sean Christopherson
2026-04-27 19:05 ` [tip: x86/misc] " tip-bot2 for Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae-_IfHQ90Nn_ydP@google.com \
--to=seanjc@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox