From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 174812DB7B7 for ; Sat, 25 Apr 2026 23:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777160773; cv=none; b=Va198RL6Gf0DqNJc17tbBuTZUgY23IFTLOgnb5eavYa1ddycaNUTBHQ6Iv0sfbUnSzYG1BUPNCafPBwadZJCqWBaN+T7HR14BEK02LKtB+rCgCUCXJTdbu4lU4J/894+bvZ6ePyVUjK3Q50wvhKJ9osVFg9TaGQjFaxBPoM0tOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777160773; c=relaxed/simple; bh=bekr16LEh5if1UmDVT4unfftMsc7D/pIaIVEP+JkN/4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DtPgPYdexdge6p+3ELkcikBZE9ZzAuzB8MlJdJRaZu7F5QYXaK3xE0YS6i3TUkr3WX2kbiiIujPxMkodHNXLYICNXaiFi4ByvOsB7CfdDPRAs/Nbf2DPbQAS+l/a7Y3PmQ64q6gQmSL375maMVUWyqdFPVXZaQ/HTd7xjfXAcxg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dCFTFQam; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dCFTFQam" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC71BC2BCB0; Sat, 25 Apr 2026 23:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777160772; bh=bekr16LEh5if1UmDVT4unfftMsc7D/pIaIVEP+JkN/4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dCFTFQamBiT5ZDTGgWrgKqxq0M7DUtdTXsmVaM2PYM8bF9R8QG7TK9w4adYsYe/+1 MENTzyBl0/LvRiigdbBtLPPrdF4zaFaegze8VSwWiPFJ9MpsVLwkzxo9TIXxcuH8xs FAy6/8llwNy8y0aKbip+AO110eRyzm9yM3UrEtd7gkGNi6D3L8DD2PkJFitlJBufmV PTPncSJ0Na0YazK12PbU3GcaKzaINSJe5bZmvBNHPjKJe/SjQaMrzdm0324aV8ujZv OjRcOfV76YJgS222oL76S6r+TFOD5/jsro5en4dv2WUCM4CuvtlZm7uWwG30YeiMO+ T9A8IdcTX1e2w== Date: Sat, 25 Apr 2026 16:46:11 -0700 From: Drew Fustini To: MoeLeak Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] dts: enable rtl8723ds on lichee pi 4a Message-ID: References: <20260425070450.43148-1-i@leak.moe> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260425070450.43148-1-i@leak.moe> On Sat, Apr 25, 2026 at 03:04:50PM +0800, MoeLeak wrote: > --- > .../boot/dts/thead/th1520-lichee-pi-4a.dts | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) Hello, thanks for sending this patch. Please resend with a full commit message including a Signed-off-by: tag [1]. What branch did you use to create this patch? It does not apply to mainline. > > diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts > index a5b00c48d..46d3f21e3 100644 > --- a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts > +++ b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts > @@ -29,6 +29,7 @@ aliases { > i2c2 = &i2c2; > i2c3 = &i2c3; > i2c4 = &i2c4; > + wifi0 = &rtl8723ds; > }; > > chosen { > @@ -119,6 +120,12 @@ vcc5v_usb: regulator-vcc5v_usb { > enable-active-high; > regulator-always-on; > }; > + > + wifi_pwrseq: wifi-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&ioexp2 4 GPIO_ACTIVE_LOW>; This is not a valid phandle in the mainline dts for the th1520. Did you base this patch on the vendor kernel? Thanks, Drew [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html