Re: [PATCH] dts: enable rtl8723ds on lichee pi 4a

Drew Fustini
2026-04-25T23:46:12Z

On Sat, Apr 25, 2026 at 03:04:50PM +0800, MoeLeak wrote:
> ---
> .../boot/dts/thead/th1520-lichee-pi-4a.dts | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)

Hello, thanks for sending this patch. Please resend with a full commit
message including a Signed-off-by: tag [1].

What branch did you use to create this patch? It does not apply to
mainline.

>
> diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> index a5b00c48d..46d3f21e3 100644
> --- a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> +++ b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> @@ -29,6 +29,7 @@ aliases {
> i2c2 = &i2c2;
> i2c3 = &i2c3;
> i2c4 = &i2c4;
> + wifi0 = &rtl8723ds;
> };
>
> chosen {
> @@ -119,6 +120,12 @@ vcc5v_usb: regulator-vcc5v_usb {
> enable-active-high;
> regulator-always-on;
> };
> +
> + wifi_pwrseq: wifi-pwrseq {
> + compatible = "mmc-pwrseq-simple";
> + reset-gpios = <&ioexp2 4 GPIO_ACTIVE_LOW>;

This is not a valid phandle in the mainline dts for the th1520. Did you
base this patch on the vendor kernel?

Thanks,
Drew

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html