From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 557193806C2 for ; Sat, 25 Apr 2026 23:58:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777161538; cv=none; b=rFck97vqACZR6NLB9EixwG02k6XjfKc8RTdRv542OZu2/ZmkkbtD6JzmoJRS6hUzrODXtM/PfpqH/938e/hFbrOCDZ36mLJZni5KmWtVi6GbPCwLHWgAolUbMiGQIr2/3tSKC9YqKE5h0wLg1pzWgAXmaLPoAfwSUXRUPeYM3GM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777161538; c=relaxed/simple; bh=TmFIqwea7P1/3JG6bQ8FE5XxmSvpiyrmnBPxG9ZPJk0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ch1OxXWPacO7tqobcinS4J3KlNX2EH84GrnHUzuPIhxo51ZcT+xB/6kfafRdGIZmwoKDazhTsTyXqigtotBOuE11O7DEVvmZ1e4+skhCrhKPaN0eSs2owKyKbeu0bkWHSF18OTDapV0OfSmF6TJKbmaJFT19tRXsHw3mWb1MTQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=F0IUGd2u; arc=none smtp.client-ip=209.85.167.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="F0IUGd2u" Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-479e4835e26so3733214b6e.3 for ; Sat, 25 Apr 2026 16:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1777161535; x=1777766335; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=SKKJCH+5uQ5Lecx+O6GjrzJ1UpPIHJaSU1gVtB7eY38=; b=F0IUGd2uvg+qYP3c3V5Rdv8KDRKnjKd8IvnwJvXjDn2Viw777lX3a1HFEGgEXKxpSl tfm6B5r+m41i5wPGkJ2PgE1FCrxFgXqQkKhLZ25SfZQIqTHOAdopSMAM5++f2yGV01Dk 2B1YPQJWooSSMMQtebjdXdU0iCUrVmm/C4lSb8B57MUWi1In2QP19DjOuMvwjTT4bUyY NITlu2XT/e9CT4+dSHeTbQ2eoP+UN2SayAj6MHIV7huF7J7CyNg+QxeulD1eiefnSdnx +jqsrJrevgNCIpmKXurt89G1WpknAe8VnmJoNExQgR5vaLAXMrfm24X548z84u+JbTX7 yEpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777161535; x=1777766335; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SKKJCH+5uQ5Lecx+O6GjrzJ1UpPIHJaSU1gVtB7eY38=; b=bDrX26kj1Ke/zM2iVimXu+tLYMcXJin5DEHPWVjxCxPNLibuyGli0QD9978f3VA3+0 HrgAM95kYyS/bbgzmYx2aTYz9PcOnBkY2pHcU1EYtY/xbaPa7GvY2fbn6igGi2+RJUuP FKYQPD1Ru8v1J2KZl+Z8+2ZQB4GLgGEZFVU4MWRyGMv8BpWBqZsLzszS/12bpjMLZjw4 Q034v7c/5kJhe9+asrAiVE8uqldPUoHGpJYmWbZIwWwsw4wNFYKErBfxnvqCGcO5NNrd /Z170xCWe3jS498NOsL7rV4QS738yxzU9w0QUzM96cWVh4gbtxd8Off5CGbQev+Lidy1 UMVg== X-Forwarded-Encrypted: i=1; AFNElJ/XP/ZZDavMZHceWa1njxbN/ErUgsdSQhzg0Wk0iG7tKBqIZju8i/R3a6lCZMjOYc0awoXpUO1HvPwqOR8=@vger.kernel.org X-Gm-Message-State: AOJu0YxCgKuSxyIwBcjPWZpdVYGZYB2l/Oi4nV9hMZ0ONwhD0Z30+OqQ bOrXd/j7VTcnFaP8WoWkyuTSTo2K3E5jr/clFaD1OIQN0cWvFSJjhOHMI2/g4wy2sNE= X-Gm-Gg: AeBDieupeq65QzeZq1kLIVb3ffb9ZOYQ2KTNjTwui7156fzmFSSmm3Ylf5u6GEUScf4 x7YvV5G6pV+OklHc1p8YV5a3ADhuDlt/tXrVsCmVjUNctUwSEanIBPzhBD0sOCOIx/1/X29uD4e U/ct+DaPtXhUTJ4vdektTaij6zR/tg1whmQYn8RJLrzcI2lN6XY/lWPSjR8BbX3Gi/bDCvl+sSG WY1Wl8fcX1OCAvhpPq6L6h59pTr1hQSCnndHV1hg/jrWaJzgxLfAy9lrDKoOVwjFQAb2xhnWKO7 QA7X+radrOKzNUWBBh3npLOG+1tZ6TSbmQvTII/Drb6noraqD/YVipHBI0Gm1vHN5I2Gydzjpfh DedEFcrJtGK+AEaYXyCWfFWyNbVh1OWBFkNRDtAbL3x2XMt68HQMTd1XkMmoDEKa7QO+E53LGpf 3FyWoKM3XUCRhEAGQvSX3Fik+f1H+hbZoleep7koBG4OEeIvlIpR7ZjyIivg3X/PfBYwLlnpmfK K5XYouNQZeImL4zAOyR029tYA== X-Received: by 2002:a05:6808:4fec:b0:467:112e:4590 with SMTP id 5614622812f47-4799cb31b57mr20806105b6e.46.1777161535251; Sat, 25 Apr 2026 16:58:55 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:6f78:34bd:5e93:9329]) by smtp.gmail.com with ESMTPSA id 5614622812f47-479a028cab5sm18097578b6e.16.2026.04.25.16.58.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 16:58:53 -0700 (PDT) Date: Sat, 25 Apr 2026 18:58:48 -0500 From: Corey Minyard To: Matt Fleming Cc: Matt Fleming , openipmi-developer@lists.sourceforge.net, Tony Camuso , linux-kernel@vger.kernel.org, kernel-team@cloudflare.com, stable@vger.kernel.org Subject: Re: [PATCH 2/2] ipmi: Add limits to event and receive message requests Message-ID: Reply-To: corey@minyard.net References: <20260421132544.2666174-1-corey@minyard.net> <20260421132544.2666174-3-corey@minyard.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Apr 25, 2026 at 10:36:05AM +0100, Matt Fleming wrote: > On Tue, Apr 21, 2026 at 07:42:44AM -0500, Corey Minyard wrote: > > The driver would just fetch events and receive messages until the > > BMC said it was done. To avoid issues with BMCs that never say they are > > done, add a limit of 10 fetches at a time. > > > > This is a more general fix than the previous fix for the specific bad > > BMC, but should fix the more general issue of a BMC that won't stop > > saying it has data. > > > > This has been there from the beginning of the driver. > > > > Reported-by: Matt Fleming > > Closes: https://lore.kernel.org/lkml/20260415115930.3428942-1-matt@readmodwrite.com/ > > Fixes: <1da177e4c3f4> ("Linux-2.6.12-rc2") > > Cc: stable@vger.kernel.org > > Signed-off-by: Corey Minyard > > --- > > drivers/char/ipmi/ipmi_si_intf.c | 15 +++++++++++++++ > > drivers/char/ipmi/ipmi_ssif.c | 15 +++++++++++++++ > > 2 files changed, 30 insertions(+) > > [...] > > > @@ -410,6 +413,7 @@ static void start_getting_msg_queue(struct smi_info *smi_info) > > > > start_new_msg(smi_info, smi_info->curr_msg->data, > > smi_info->curr_msg->data_size); > > + smi_info->num_requests_in_a_row = 0; > > smi_info->si_state = SI_GETTING_MESSAGES; > > } > > > > @@ -421,6 +425,7 @@ static void start_getting_events(struct smi_info *smi_info) > > > > start_new_msg(smi_info, smi_info->curr_msg->data, > > smi_info->curr_msg->data_size); > > + smi_info->num_requests_in_a_row = 0; > > smi_info->si_state = SI_GETTING_EVENTS; > > } > > > > Would it be better to move this zeroing to handle_transaction_done()? > Otherwise we reset the counter in handle_flags() -> > start_getting_events() and the threshold is never reached. Oh, yeah. Moving it to handle_transaction_done() is not ideal, though. If something was spewing receive messages, it would never get to events, which is why I did it like I did. The following should fix this. You could also have different limits for receive messages and events, but I think the following is more clear. diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index 2a739123270c..e46f4150ceb5 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -413,8 +413,10 @@ static void start_getting_msg_queue(struct smi_info *smi_info) start_new_msg(smi_info, smi_info->curr_msg->data, smi_info->curr_msg->data_size); - smi_info->num_requests_in_a_row = 0; - smi_info->si_state = SI_GETTING_MESSAGES; + if (smi_info->si_state != SI_GETTING_MESSAGES) { + smi_info->num_requests_in_a_row = 0; + smi_info->si_state = SI_GETTING_MESSAGES; + } } static void start_getting_events(struct smi_info *smi_info) @@ -425,8 +427,10 @@ static void start_getting_events(struct smi_info *smi_info) start_new_msg(smi_info, smi_info->curr_msg->data, smi_info->curr_msg->data_size); - smi_info->num_requests_in_a_row = 0; - smi_info->si_state = SI_GETTING_EVENTS; + if (smi_info->si_state != SI_GETTING_EVENTS) { + smi_info->num_requests_in_a_row = 0; + smi_info->si_state = SI_GETTING_EVENTS; + } } /* > > Thanks, > Matt