From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B80F01F3B87 for ; Sun, 26 Apr 2026 04:24:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777177478; cv=none; b=KA/hzBlFImmryhfOb1cm6QteU2hCxEicUGcy38pUrkLHPXpNXbI4TKwJ4VWhu0W59FHmys7B+ym9GiAyZJGRBTo+6t1D+myxqcooAAXllvRYqrfg87KrGYD8w/Ob0oLLd3YHN3G27lPZJn4/y6a0KryeqmdFTa9lOAITvbv+t9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777177478; c=relaxed/simple; bh=jqKbTvrhLLv6M2A6PKYdhZjjnEdCSJ+gACEo1eh7pTY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FpmnxTzsFsqKB28ntXpMEgf2doaXn5V09faYi+V0O3aleGgqLCnlGZUDB/aVcOfUpGEOtlzxhPiGjBUHO6K9xdyg5309R1iIF9vIkQBE+eFz647k+0969+WHjUH2ctkgGbEOBYaM2n4t2buCzKht65G6+qrtFGU9xMdzFJdk7Nc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kot6lPpD; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kot6lPpD" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2d8ffdc31d0so1186540eec.0 for ; Sat, 25 Apr 2026 21:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777177477; x=1777782277; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+YpXivrfSMMmLk2Cw2soTR91gmDOVGg4r9ajSzwj7Ls=; b=Kot6lPpD5s5uGfENryq2Dm2tW0UrEzpefAZCxrK5+HUs4/f0UYoQ5kaBkAwW5Oxl8G cyML/ME+9xKageaPHlJVdp8sJ7t5/N/9zVUpzWbPdehZY2lxZ46N0bKJ/BzJbqOV7u3N kOfxCwy/OBltIP0abL7WgESyQuFwYhy0Fobn3FRRcmnm8uNL2O4+awlOusrOcwWI+XBi xrK8/N+ijbTaOgt4jZuGHb5d0rAPd0LIv4RSrXmKeB1B0IN0nP6jJ7I/4fhLz7BdNAv3 KQ96YQfT7LSRPGu5DeTXcngAxP/5UqSclJq+5ERhqYr5osEIlm7MrksR18MY7glNVdKL sVzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777177477; x=1777782277; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+YpXivrfSMMmLk2Cw2soTR91gmDOVGg4r9ajSzwj7Ls=; b=kFwI+GouXJJtzBxjppv+5TBK+urWyNPgRyrQZURNs3JgwIqcRlEK7lQtl5lw5PpC5Y voFaMrlIn8OElUIHj/VOLO6xVPONwjXPCK4edRsELU61KxaVj3D9THeqZ8+g/ZY8nvyg HtWkU5NSV8K1A7txyDOGj13pG5j49zQb/4QT2CD0nc/qrsX95goykSOS9kX77V3RJpVl Wd9TAaKgc858TGuQcPxhXct7dGAsBOMv9rrpiu24FQy4u5O1jzStDnIcCk/JNaOwqc+0 omiGXMRmt+g65qal2iHZVOm0XZo/exjZLY+ZB0kVanlYeNtx5QPI9X+yDm33ChtFLpZC j0mA== X-Forwarded-Encrypted: i=1; AFNElJ9BkJ/wVH0jwBPvwCziWsNVvxegKE5XSDqztZ8jvmLsuy3gT62W8cPvSaxKWzB1D9T4j7J5Y+B2L5Nnrok=@vger.kernel.org X-Gm-Message-State: AOJu0Yy38YFma56uAJo5xMTk/tQlELtE6U/8FAiptqm9an0mBXfXeQAC W4et1xurXNyi/NokIygDSKo6wxYR31/M0Z09KZ4ZOHSaYSmbuUd/sYzx X-Gm-Gg: AeBDiev82pCWZt7fIbs7h9xCNnE4FWVxq7VIOeGZuTiHvtOhZpX8kS7DOuZ9LdRBsnp bKDNINmpPqTPNHkzTUtSVZmg+kzatVLB5UydN2V98i1Zgzb22qTV+nEhDzBJltZunmfJIj8TIZU q7PREL9oPBIzWhz8V/mF65oaboXUbVq5zrpDQpF4PlTd6VkZzGCRvTmgS7WiNf6nGTwxTS9J8PY TWbRU8k9yFY8qUePwjA7GfJkmF84gcTHiPOeHE+unbDE2y1ES0zTUm20WEejLCkxXO2oe+vWIoO 2zsOc6dEMy7+UnpQz5281UU6XfSjfYNn8V1Ez8lqxMG5cxNnOu+eLZ4fFWTAJ5rh0KZMlwnwZ6Z ww2fD2IP5pRD3e0TRjK4SkEGXdESYxw+yaIj8E6+SwrgSAfBRlF6Ecx/eoAdx4bTohdDX5SASCa KfnahdR0ctfXRgzpwCDlyl270u27mXLKK7OwPeDQXuY4VqJQyAXz+AHJK5lT3RKGgl9fwt7CP1h qA= X-Received: by 2002:a05:693c:300c:b0:2dd:c066:bfe with SMTP id 5a478bee46e88-2e478a331bfmr24126557eec.21.1777177476748; Sat, 25 Apr 2026 21:24:36 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:f359:aa0c:530d:9dfd]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ab8b89csm38712982eec.12.2026.04.25.21.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 21:24:35 -0700 (PDT) Date: Sat, 25 Apr 2026 21:24:32 -0700 From: Dmitry Torokhov To: Bartosz Golaszewski Cc: Bartosz Golaszewski , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Brendan Higgins , David Gow , Rae Moar , Andy Shevchenko , driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Subject: Re: [PATCH v2 1/3] driver core: platform: remove software node on release() Message-ID: References: <20260423-swnode-remove-on-dev-unreg-v2-0-0e5213cde2ed@oss.qualcomm.com> <20260423-swnode-remove-on-dev-unreg-v2-1-0e5213cde2ed@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Apr 24, 2026 at 02:26:38PM +0200, Bartosz Golaszewski wrote: > On Thu, Apr 23, 2026 at 7:32 PM Dmitry Torokhov > wrote: > > > > > > > > + /* > > > + * If the primary firmware node is a software node and there's no > > > + * secondary firmware node, the primary will be affected by the call > > > + * to device_remove_software_node() in platform_device_release() and > > > + * its reference count will be dropped by one. Take another reference > > > + * here to make it have no effect. > > > + */ > > > + if (is_software_node(pdevinfo->fwnode) && !pdevinfo->swnode) > > > + fwnode_handle_get(pdevinfo->fwnode); > > > > It is possible to pass already registered node in pdevinfo->swnode > > (because device_add_software_node() can handle this just fine). In this > > case we also need to take an extra reference (or figure out whether we > > need to drop the reference when removing the device). > > > > But device_add_software_node() checks if the software node is > registered and - if so - just bumps the reference so the effect is the > same as when it registers the swnode. Ah, yes, you are right. Still please check sashiko review - I think some of the concerns about error unwinding are correct. Thanks. -- Dmitry